Review main Merged

61968[DOCS] Update TypoLink example inside of ViewHelper

Tizian Schmidlin CR +2 V +2 Easy +4 −1 updated 01/14/20, 10:30

Commit message

Since TYPO3 8 the way TypoLinks are represented has changed.
The new form is t3://page?uid= as prefix for page links.
The documentation of TypoLinkViewHelper is updated to reflect this.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Felix P. +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Felix P. +1
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1216

  1. Tizian Schmidlin uploaded patch set 1 10/14/19, 09:58

  2. Tizian Schmidlin updated the commit message in patch set 2 10/14/19, 09:58

  3. Tizian Schmidlin voted on patch set 2 V +1 CR +1 10/14/19, 09:59

  4. TYPO3com voted on patch set 1 V +1 10/14/19, 10:11 Completed build in 12m 33s on Mon, 14 Oct, 10:11 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37299

  5. TYPO3com voted on patch set 2 V +1 10/14/19, 10:13 Completed build in 14m 39s on Mon, 14 Oct, 10:13 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37300

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 10/14/19, 11:13

  7. Oli Bartsch commented on patch set 2 V 0 CR 0 10/14/19, 12:56

    Unresolved

    We could replace "page" by "internal" here so it gets clear that this only applies to internal links.

    Unresolved

    I would suggest something like "The example in the ViewHelper's PHPDoc now uses the correct syntax." as you changed it with this patch already.
  8. Daniel Siepmann commented on patch set 2 10/16/19, 12:20

    Unresolved

    That's already true for TYPO3 8 LTS.

    TypolinkViewHelper.php:31 Unresolved

    There is still a legacy handling fallback. Should we mention that one? `t3://page?uid=2&arg1=val1#9 _blank some-css-class "Title containing Whitespace"` would be a valid example. The existing one with `&X=y` is already wrong.
  9. Daniel Siepmann uploaded patch set 3 10/16/19, 12:41

  10. TYPO3com voted on patch set 3 V -1 10/16/19, 12:51 Completed build in 09m 49s on Wed, 16 Oct, 12:51 PM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37350

  11. Daniel Goerz commented on patch set 3 11/09/19, 12:43

    TypolinkViewHelper.php:31 Unresolved

    The "old" example works as well and will still be supported (if I am not mistaken), maybe we just add another example with the t3:// prefix?
  12. TYPO3com voted on patch set 3 V +1 11/09/19, 12:51 Completed build in 08m 23s on Sat, 9 Nov, 12:51 PM Test Summary: 48178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38165

  13. Steffen Frese voted on patch set 3 V +1 CR +1 01/14/20, 09:03

  14. Felix P. voted on patch set 3 V +1 CR +1 01/14/20, 09:38

  15. Daniel Goerz voted on patch set 3 V +2 CR +2 01/14/20, 10:30

  16. Daniel Goerz merged patch set 4 01/14/20, 10:30