61968[DOCS] Update TypoLink example inside of ViewHelper
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Felix P. +1
- Steffen Frese +1
-
Verified V +2 Done
- Daniel Goerz +2
- Felix P. +1
- Steffen Frese +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1216
-
Tizian Schmidlin uploaded patch set 1 10/14/19, 09:58
-
Tizian Schmidlin updated the commit message in patch set 2 10/14/19, 09:58
-
Tizian Schmidlin voted on patch set 2 V +1 CR +1 10/14/19, 09:59
-
TYPO3com voted on patch set 1 V +1 10/14/19, 10:11 Completed build in 12m 33s on Mon, 14 Oct, 10:11 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37299
-
TYPO3com voted on patch set 2 V +1 10/14/19, 10:13 Completed build in 14m 39s on Mon, 14 Oct, 10:13 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37300
-
Oli Bartsch voted on patch set 2 V +1 CR +1 10/14/19, 11:13
-
Oli Bartsch commented on patch set 2 V 0 CR 0 10/14/19, 12:56
Unresolved
I would suggest something like "The example in the ViewHelper's PHPDoc now uses the correct syntax." as you changed it with this patch already. -
Daniel Siepmann commented on patch set 2 10/16/19, 12:20
Unresolved
That's already true for TYPO3 8 LTS.TypolinkViewHelper.php:31UnresolvedThere is still a legacy handling fallback. Should we mention that one? `t3://page?uid=2&arg1=val1#9 _blank some-css-class "Title containing Whitespace"` would be a valid example. The existing one with `&X=y` is already wrong. -
Daniel Siepmann uploaded patch set 3 10/16/19, 12:41
-
TYPO3com voted on patch set 3 V -1 10/16/19, 12:51 Completed build in 09m 49s on Wed, 16 Oct, 12:51 PM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37350
-
Daniel Goerz commented on patch set 3 11/09/19, 12:43
TypolinkViewHelper.php:31UnresolvedThe "old" example works as well and will still be supported (if I am not mistaken), maybe we just add another example with the t3:// prefix? -
TYPO3com voted on patch set 3 V +1 11/09/19, 12:51 Completed build in 08m 23s on Sat, 9 Nov, 12:51 PM Test Summary: 48178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38165
-
Steffen Frese voted on patch set 3 V +1 CR +1 01/14/20, 09:03
-
Felix P. voted on patch set 3 V +1 CR +1 01/14/20, 09:38
-
Daniel Goerz voted on patch set 3 V +2 CR +2 01/14/20, 10:30
-
Daniel Goerz merged patch set 4 01/14/20, 10:30
Unresolved