Review main Merged

61969[TASK] Fix return type annotation of Extbase getArgument method

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 10/21/19, 10:34

Commit message

It is possible to have an array as argument, e.g. select, checkbox, …
Therefore also arrays can be returned by this method.

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
    • Daniel Goerz +1
    • Oliver Klee +1
    • Sybille Peters +1
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Daniel Siepmann uploaded patch set 1 10/14/19, 11:36

  2. Oliver Klee voted on patch set 1 CR +1 10/14/19, 11:43

  3. TYPO3com voted on patch set 1 V -1 10/14/19, 11:49 Completed build in 13m 10s on Mon, 14 Oct, 11:49 AM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37303

  4. TYPO3com commented on patch set 1 10/14/19, 13:34 Completed build in 10m 23s on Mon, 14 Oct, 01:34 PM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37308

  5. TYPO3com voted on patch set 1 V +1 10/18/19, 12:47 Completed build in 14m 19s on Fri, 18 Oct, 12:47 PM Test Summary: 47986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37385

  6. Daniel Goerz voted on patch set 1 V +1 CR +1 10/20/19, 13:12

  7. Sybille Peters voted on patch set 1 CR +1 10/21/19, 10:23

  8. Alexander Schnitzler commented on patch set 1 CR -1 10/21/19, 10:27

    Request.php:377 Unresolved

    What makes you so sure that this method only returns strings? What if you have a GET param like: tx_ext_pi['list'][]=1
  9. Alexander Schnitzler wrote 10/21/19, 10:32

    Removed Code-Review-1 by Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
  10. Alexander Schnitzler commented on patch set 1 10/21/19, 10:32

    > Patch Set 1: Code-Review-1 > > (1 comment) Nevermind, I am stupid.
  11. Alexander Schnitzler voted on patch set 1 V +2 CR +2 10/21/19, 10:32

  12. Alexander Schnitzler merged patch set 2 10/21/19, 10:34