Review 9.5 Merged

61978[TASK] Fix param type annotation of Extbase methods

Frank Nägler CR +2 V +2 Easy +7 −7 updated 10/17/19, 13:35

Commit message

It is possible to provide null for these arguments.
The defaults are even null. Therefore this should be documented, as this
is expected to trigger a specific behaviour.

E.g. not providing an extension or controller name results to the
current one.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Frank Nägler commented on patch set 1 10/17/19, 12:58

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/17/19, 13:12 Completed build in 14m 21s on Thu, 17 Oct, 01:12 PM Test Summary: 50765 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1324

  3. Daniel Siepmann voted on patch set 1 V +1 CR +1 10/17/19, 13:34

  4. Frank Nägler voted on patch set 1 V +2 CR +2 10/17/19, 13:35

  5. Frank Nägler merged patch set 2 10/17/19, 13:35