Review TYPO3_8-7 Merged

61985[TASK] Fix return type annotation of get_dirs method

Frank Nägler CR +2 V +2 Easy +2 −1 updated 10/18/19, 11:15

Commit message

As three different return types can be returned, they should all be
documented. This allows for better autocompletion and type safety through
static code analysis.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Frank Nägler commented on patch set 1 10/18/19, 10:39

    Cherry Picked from branch 9.5.
  2. TYPO3com voted on patch set 1 V +1 10/18/19, 10:54 Completed build in 14m 34s on Fri, 18 Oct, 10:54 AM Test Summary: 80400 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3669

  3. Frank Nägler voted on patch set 1 V +2 CR +2 10/18/19, 11:15

  4. Frank Nägler merged patch set 2 10/18/19, 11:15