Review main Merged

61999[BUGFIX] Make EXT:backend independent of EXT:install

Daniel Siepmann CR +2 V +2 Easy +19 −6 updated 11/09/19, 15:19

Commit message

EXT:backend generates a URL to EXT:install, but has no dependency. This
can lead to composer setups with EXT:backend but without EXT:install,
leading to an exception while generating route.

Therefore a suggest is added as a hint to install also EXT:install.
Existing code is wrapped with an try / catch in order to work under both
circumstances.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • Karavas Aristeidis +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1416

  1. Daniel Siepmann uploaded patch set 1 10/15/19, 11:24

  2. TYPO3com voted on patch set 1 V +1 10/15/19, 11:35 Completed build in 10m 20s on Tue, 15 Oct, 11:35 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37331

  3. Tobi Kretschmann voted on patch set 1 CR +1 10/16/19, 06:49

  4. Mathias Brodala updated the commit message in patch set 2 10/16/19, 14:01

  5. Mathias Brodala commented on patch set 2 10/16/19, 14:02

    TYPO3v9 is affected, too.
  6. TYPO3com voted on patch set 2 V +1 10/16/19, 14:11 Completed build in 09m 38s on Wed, 16 Oct, 02:11 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37354

  7. Karavas Aristeidis commented on patch set 2 CR +1 11/06/19, 13:48

    Simple solution as the link won't be generated if the uriBuilder fails to build the link.
  8. Alexander Schnitzler commented on patch set 2 11/07/19, 13:36

    That's what we talked about at t3init, right? Didn't we want to introduce events here, so one extension can hook into the other and resolve the dependencies that way?
  9. Daniel Siepmann commented on patch set 2 11/07/19, 15:57

    > Patch Set 2: > > That's what we talked about at t3init, right? Didn't we want to introduce events here, so one extension can hook into the other and resolve the dependencies that way? I guess you remember something from Sybille regarding LinkValidator and Hooks :) That's a different thing. Can't remember that we talked about this one. But should be an easy one, just remove hard dependency in order to prevent Exceptions.
  10. Andreas Kienast voted on patch set 2 V +1 CR +1 11/07/19, 15:59

  11. Georg Ringer voted on patch set 2 V +1 CR +1 11/07/19, 20:09

  12. Frank Nägler commented on patch set 2 11/08/19, 11:55

    I am not sure if this makes sense. EXT:install is "partOfFactoryDefault" and "partOfMinimalUsableSystem".
  13. Andreas Kienast commented on patch set 2 11/08/19, 17:53

    > Patch Set 2: > > I am not sure if this makes sense. > EXT:install is "partOfFactoryDefault" and "partOfMinimalUsableSystem". IIRC this only affects the extension manager. Technically, it's still removable via Composer.
  14. Susi Moog commented on patch set 2 V +1 CR +1 11/09/19, 15:19

    > Patch Set 2: > > > Patch Set 2: > > > > I am not sure if this makes sense. > > EXT:install is "partOfFactoryDefault" and "partOfMinimalUsableSystem". > > IIRC this only affects the extension manager. Technically, it's still removable via Composer. yes - and additionally, even if that wasn't the case, I'd say this is already making it future-proof and therefor ok.
  15. Susi Moog voted on patch set 2 V +2 CR +2 11/09/19, 15:19

  16. Susi Moog merged patch set 3 11/09/19, 15:19