Review 9.5 Merged

62001[BUGFIX] Render FlashMessages at ClearCache

Tobi Kretschmann CR +2 V +2 Easy +15 −8 updated 11/28/19, 06:41

Commit message

Custom Clear Cache implementations can provide their own summary of results.
The content of a JSON response can send a title and message to be displayed
as a Flash message. If an error occurs, a global error message is displayed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Henning Liebe +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Henning Liebe +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Tobi Kretschmann uploaded patch set 1 10/15/19, 12:43

  2. TYPO3com voted on patch set 1 V -1 10/15/19, 12:55 Completed build in 11m 43s on Tue, 15 Oct, 12:55 PM Test Summary: 50451 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1320

  3. TYPO3com voted on patch set 1 V +1 10/15/19, 13:14 Completed build in 12m 15s on Tue, 15 Oct, 01:14 PM Test Summary: 50763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1321

  4. Henning Liebe commented on patch set 1 V +1 CR +1 10/16/19, 05:35

    Works for me. Tested in 9.5.11-dev
  5. Guido Schmechel voted on patch set 1 V +1 CR +1 10/18/19, 06:14

  6. Frank Nägler commented on patch set 1 CR -1 10/18/19, 09:33

    ClearCacheMenu.ts:79 Unresolved

    as mentioned in the master patch, which is already merged, the message is not translatable
  7. Frank Nägler commented on patch set 1 CR 0 10/18/19, 09:37

    ok, I just saw, it was also before not translated, so ignore my comment, I create an own issue for this.
  8. Georg Ringer voted on patch set 1 V +2 CR +2 11/28/19, 06:41

  9. Georg Ringer merged patch set 2 11/28/19, 06:41