Review main Merged

62005[BUGFIX] Clipboard: Check whether FAL object is an existing file

Andreas Kienast CR +2 V +2 Easy +3 −2 updated 10/17/19, 16:14

Commit message

The clipboard now checks whether a FAL object is a valid and existing
file before creating an export link.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Frank Nägler +1
    • Christoph Lehmann +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1417

  1. Andreas Kienast uploaded patch set 1 10/16/19, 13:05

  2. Andreas Kienast updated the commit message in patch set 2 10/16/19, 13:06

  3. TYPO3com voted on patch set 1 V +1 10/16/19, 13:17 Completed build in 11m 32s on Wed, 16 Oct, 01:17 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37351

  4. TYPO3com voted on patch set 2 V +1 10/16/19, 13:19 Completed build in 13m 47s on Wed, 16 Oct, 01:19 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37352

  5. Daniel Goerz voted on patch set 2 CR +1 10/16/19, 13:54

  6. Manuel Selbach voted on patch set 2 CR +1 10/16/19, 14:17

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 10/17/19, 07:44

  8. Andreas Kienast commented on patch set 2 CR -1 10/17/19, 08:51

    Will check something
  9. Andreas Kienast voted on patch set 2 CR 0 10/17/19, 08:55

  10. Andreas Kienast commented on patch set 2 V -1 10/17/19, 09:44

    Frank is working on it
  11. Frank Nägler uploaded patch set 3 10/17/19, 09:58

  12. Frank Nägler voted on patch set 3 V +1 CR +1 10/17/19, 09:59

  13. TYPO3com voted on patch set 3 V +1 10/17/19, 10:08 Completed build in 09m 51s on Thu, 17 Oct, 10:08 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37367

  14. Christoph Lehmann commented on patch set 3 V +1 10/17/19, 11:45

    I checked with 8.7.28 and cut/paste of folders works again
  15. Oli Bartsch voted on patch set 3 CR +1 10/17/19, 15:32

  16. Daniel Goerz voted on patch set 3 V +2 CR +2 10/17/19, 16:14

  17. Daniel Goerz merged patch set 4 10/17/19, 16:14