Review main Merged

62006[TASK] Fix param type annotation of Extbase methods

Daniel Siepmann CR +2 V +2 Easy +7 −7 updated 10/17/19, 12:57

Commit message

It is possible to provide null for these arguments.
The defaults are even null. Therefore this should be documented, as this
is expected to trigger a specific behaviour.

E.g. not providing an extension or controller name results to the
current one.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Daniel Siepmann uploaded patch set 1 10/16/19, 13:37

  2. TYPO3com voted on patch set 1 V +1 10/16/19, 13:47 Completed build in 09m 50s on Wed, 16 Oct, 01:47 PM Test Summary: 47980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37353

  3. Oliver Klee voted on patch set 1 CR +1 10/16/19, 14:37

  4. Oli Bartsch voted on patch set 1 CR +1 10/16/19, 14:52

  5. Frank Nägler voted on patch set 1 V +2 CR +2 10/17/19, 12:57

  6. Frank Nägler merged patch set 2 10/17/19, 12:57