Review main Merged

62007[TASK] Introduce bit operation and helper methods in BitSet class

Alexander Schnitzler CR +2 V +2 Normal +156 −0 updated 10/21/19, 07:53

Commit message

This commit introduces the following set of bit operation methods

- and
- or
- xor
- andNot

as well as the following helper methods

- clear
- __toInt
- __toString

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1317

  1. Alexander Schnitzler uploaded patch set 1 10/16/19, 15:13

  2. TYPO3com voted on patch set 1 V -1 10/16/19, 15:23 Completed build in 10m 29s on Wed, 16 Oct, 03:23 PM Test Summary: 1 of 48365 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37355

  3. TYPO3com voted on patch set 1 V +1 10/16/19, 15:24 Completed build in 21m 49s on Wed, 16 Oct, 03:24 PM Test Summary: 48006 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37355

  4. Alexander Schnitzler updated the commit message in patch set 2 10/16/19, 15:30

  5. TYPO3com voted on patch set 2 V +1 10/16/19, 15:41 Completed build in 10m 57s on Wed, 16 Oct, 03:41 PM Test Summary: 48006 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37356

  6. Chris Müller commented on patch set 2 10/17/19, 06:39

    BitSet.php:122

    The next version will be 10.2, it is intended to use 10.3?

    BitSet.php:134 Unresolved

    The next version will be 10.2, it is intended to use 10.3?

    BitSet.php:147 Unresolved

    The next version will be 10.2, it is intended to use 10.3?

    BitSet.php:164 Unresolved

    The next version will be 10.2, it is intended to use 10.3?

    BitSet.php:175 Unresolved

    The next version will be 10.2, it is intended to use 10.3?

    BitSet.php:188 Unresolved

    The next version will be 10.2, it is intended to use 10.3?

    BitSet.php:199 Unresolved

    The next version will be 10.2, it is intended to use 10.3?
  7. Andreas Kienast commented on patch set 2 10/17/19, 07:13

    Two remarks here: - I think we shouldn't use @since annotations, at least I personally don't see a benefit here - I'm not sure whether this is a "real" feature and deserves a ReST
  8. Alexander Schnitzler commented on patch set 2 10/17/19, 08:11

    > Patch Set 2: > > (7 comments) 10.3 wasn't intentional, I thought we already have 10.2 released. ^^
  9. Alexander Schnitzler commented on patch set 2 10/17/19, 08:17

    > Patch Set 2: > > Two remarks here: > > - I think we shouldn't use @since annotations, at least I personally don't see a benefit here Well, I agree looking at the current situation of not using the doc blocks properly to render documentation. The question is, if we want to give more semantic meaning to doc blocks or not. We can remove those, don't have any hard feelings here. > - I'm not sure whether this is a "real" feature and deserves a ReST Well, that is a very good question. I think from a user perspective this is not a feature-patch. It's nothing to "advertise", really. It's more or less missing functionality you would expect a BitSet class to have anyway. However, in the end, those are public methods but I think they will mostly be used by sub classes that expose a more meaningful api anyway as many people don't understand or want to cope with bit operations.
  10. Georg Ringer commented on patch set 2 10/17/19, 11:07

    wouldn't it make sense to have this in 9.5. as well?

    BitSet.php:122 Reply Unresolved

    we don't to such tags, we have git for such stuff or if important a rst, so pls remove
  11. Alexander Schnitzler commented on patch set 2 10/17/19, 11:09

    > Patch Set 2: > > (1 comment) > > wouldn't it make sense to have this in 9.5. as well? We'd need to backport the whole class to 9.5. So, no.
  12. Alexander Schnitzler uploaded patch set 3 10/17/19, 11:12

  13. TYPO3com voted on patch set 3 V +1 10/17/19, 11:23 Completed build in 10m 41s on Thu, 17 Oct, 11:23 AM Test Summary: 48006 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37368

  14. Andreas Kienast voted on patch set 3 CR +1 10/17/19, 11:59

  15. Georg Ringer voted on patch set 3 V +1 CR +1 10/17/19, 23:22

  16. Daniel Goerz voted on patch set 3 V +2 CR +2 10/21/19, 07:53

  17. Daniel Goerz merged patch set 4 10/21/19, 07:53