Review main Merged

62008[BUGFIX] Set pageInfo in ElementInformation popup for non-related records

Benni Mack CR +2 V +2 Easy +2 −0 updated 10/17/19, 07:41

Commit message

When accessing a non-versioned record, pageInfo needs to be fetched as well,
otherwise "live" records will never allow a popup to be shown.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Achim Fritz +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Sven Juergens +1
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 10/16/19, 19:00

  2. Benni Mack updated the commit message in patch set 2 10/16/19, 19:01

  3. TYPO3com voted on patch set 1 V +1 10/16/19, 19:13 Completed build in 12m 26s on Wed, 16 Oct, 07:13 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37362

  4. TYPO3com voted on patch set 2 V +1 10/16/19, 19:15 Completed build in 11m 15s on Wed, 16 Oct, 07:15 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37363

  5. Achim Fritz voted on patch set 2 V +1 CR +1 10/17/19, 06:49

  6. Sven Juergens voted on patch set 2 V +1 10/17/19, 07:28

  7. Andreas Kienast voted on patch set 2 CR +1 10/17/19, 07:31

  8. Daniel Goerz voted on patch set 2 V +2 CR +2 10/17/19, 07:41

  9. Daniel Goerz merged patch set 3 10/17/19, 07:41