Review main Merged

62020[BUGFIX] Synchronize TCA enable columns from workspace version

Achim Fritz CR +2 V +2 Hard +298 −39 updated 11/20/19, 15:34

Commit message

In case workspace placeholders (new or move) are involved corresponding
explicit TCA control settings in either shadowColumnsForMovePlaceholders
or shadowColumnsForNewPlaceholders are used to update those field values
and synchronize workspace versions with their placeholder records.

Since the data-retrieval process first queries live version pendants and
then tries to overlay those records with version information, values for
enable columns shall be synchronized automatically - otherwise possible
HiddenRestriction or StartTimeRestriction would deny selecting live
versions already in the first place.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Achim Fritz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1623

  1. Achim Fritz uploaded patch set 1 10/18/19, 15:18

  2. TYPO3com voted on patch set 1 V -1 10/18/19, 15:29 Completed build in 10m 37s on Fri, 18 Oct, 03:29 PM Test Summary: 1 of 48345 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37387

  3. Oli Bartsch updated the commit message in patch set 2 10/18/19, 16:32

  4. TYPO3com voted on patch set 2 V +1 10/18/19, 16:42 Completed build in 10m 08s on Fri, 18 Oct, 04:42 PM Test Summary: 47986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37388

  5. Oliver Hader commented on patch set 2 CR -1 11/08/19, 14:54

    I'm trying to prepare some tests...
  6. Oliver Hader commented on patch set 2 V -1 11/08/19, 17:29

    I'd opt for a different approach - proof-of-concept is ready... but have to wait until Bamboo is finished since it's a chain of multiple (preparation) patches
  7. Oliver Hader uploaded patch set 3 11/09/19, 09:10

  8. TYPO3com voted on patch set 3 V +1 11/09/19, 09:25 Completed build in 13m 02s on Sat, 9 Nov, 09:25 AM Test Summary: 48178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38146

  9. Benni Mack uploaded patch set 4 11/09/19, 09:46

  10. TYPO3com voted on patch set 4 V +1 11/09/19, 09:55 Completed build in 08m 54s on Sat, 9 Nov, 09:55 AM Test Summary: 48187 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38148

  11. Oliver Hader commented on patch set 4 11/09/19, 09:58

    moveContentToDifferentPageAndHide.csv:15

    Seems you found a missing piece here... placeholder (live pendant) is not updated, which is wrong...
  12. Oliver Hader uploaded patch set 5 11/19/19, 16:00

  13. Oliver Hader commented on patch set 5 11/19/19, 16:01

    moveContentToDifferentPageAndHide.csv:15 Reply

    Done
  14. TYPO3com voted on patch set 5 V +1 11/19/19, 16:07 Completed build in 07m 16s on Tue, 19 Nov, 04:07 PM Test Summary: 48353 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38487

  15. Oliver Hader updated the commit message in patch set 6 11/19/19, 16:13

  16. TYPO3com voted on patch set 6 V +1 11/19/19, 16:20 Completed build in 07m 25s on Tue, 19 Nov, 04:20 PM Test Summary: 48353 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38488

  17. Achim Fritz voted on patch set 6 V +1 CR +1 11/20/19, 14:12

  18. Benni Mack uploaded patch set 7 11/20/19, 14:18

  19. Benni Mack voted on patch set 7 V +1 CR +1 11/20/19, 14:18

  20. TYPO3com voted on patch set 7 V +1 11/20/19, 14:25 Completed build in 07m 24s on Wed, 20 Nov, 02:25 PM Test Summary: 48353 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38499

  21. Achim Fritz voted on patch set 7 V +1 CR +1 11/20/19, 15:33

  22. Benni Mack voted on patch set 7 V +2 CR +2 11/20/19, 15:34

  23. Benni Mack merged patch set 8 11/20/19, 15:34