62032[FEATURE] Show link to online docs in extension manager
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/core/Documentation/Changelog/master/Feature-89458-ShowLinkToOnlineDocsInExtensionManager.rstnew+22 −0
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php3+21 −0
- typo3/sysext/extensionmanager/Classes/Utility/Importer/ExtensionListUtility.php+4 −2
- typo3/sysext/extensionmanager/Classes/Utility/Parser/AbstractExtensionXmlParser.php+17 −1
- typo3/sysext/extensionmanager/Classes/Utility/Parser/ExtensionXmlPullParser.php+3 −0
- typo3/sysext/extensionmanager/Classes/Utility/Parser/ExtensionXmlPushParser.php+3 −0
- typo3/sysext/extensionmanager/Configuration/TCA/tx_extensionmanager_domain_model_extension.php+8 −2
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/TerSingleLine.html+7 −0
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/TerTable.html+1 −0
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/ShowAllVersions.html+1 −1
- typo3/sysext/extensionmanager/ext_tables.sql+1 −0
Review log 1727
Show 2 earlier messages
-
TYPO3com voted on patch set 1 V -1 10/19/19, 00:03 Completed build in 09m 28s on Sat, 19 Oct, 12:03 AM Test Summary: 1 of 48084 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37393
-
TYPO3com voted on patch set 1 V +1 10/19/19, 11:15 Completed build in 11h 30m 42s on Sat, 19 Oct, 11:15 AM Test Summary: 47986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37393
-
Chris Müller commented on patch set 1 10/28/19, 16:33
Extension.php:623As the other setters don't return anything, the return statement should be removed to be in sync with them. -
Oli Bartsch commented on patch set 1 10/28/19, 16:46
Extension.php:623Reply UnresolvedMethod chaining is very useful and therefore I don't think removing it only to unify with existing setters isn't reasonable. But since it is also not used in this case, I'm with you here. -
Georg Ringer uploaded patch set 2 10/31/19, 06:40
-
TYPO3com voted on patch set 2 V -1 10/31/19, 06:55 Completed build in 15m 27s on Thu, 31 Oct, 06:55 AM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37880
-
TYPO3com voted on patch set 2 V +1 10/31/19, 07:48 Completed build in 1h 23m 19s on Thu, 31 Oct, 07:48 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37880
-
Markus Klein commented on patch set 3 10/31/19, 07:59
Published edit on patch set 2. -
Markus Klein updated the commit message in patch set 4 10/31/19, 07:59
-
Markus Klein commented on patch set 4 10/31/19, 08:00
Extension.php:611Unresolvedwhy no :string typehint here? -
TYPO3com voted on patch set 3 V -1 10/31/19, 08:11 Completed build in 12m 36s on Thu, 31 Oct, 08:11 AM Test Summary: 47829 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37882
-
TYPO3com voted on patch set 4 V -1 10/31/19, 08:14 Completed build in 15m 20s on Thu, 31 Oct, 08:14 AM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37883
-
TYPO3com voted on patch set 4 V +1 10/31/19, 08:26 Completed build in 42m 23s on Thu, 31 Oct, 08:26 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37883
-
Georg Ringer uploaded patch set 5 11/05/19, 08:41
-
TYPO3com voted on patch set 5 V +1 11/05/19, 08:51 Completed build in 09m 11s on Tue, 5 Nov, 08:51 AM Test Summary: 48123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37999
-
Markus Klein commented on patch set 5 11/05/19, 09:00
Feature-89458-ShowCorrectManualLinkInExtensionManager.rst:13The detail view can not be reached from the "installed extensions" view. IMO this should be accessible there. I rarely (almost never) look into the detail view of an extension. Moverover, the detail view is not available if it is a composer installation. -
Benni Mack uploaded patch set 6 11/09/19, 17:25
-
Benni Mack commented on patch set 6 V +1 CR +1 11/09/19, 17:25
Feature-89458-ShowCorrectManualLinkInExtensionManager.rst:13Reply UnresolvedI added it to the list view as well. -
Andreas Kienast commented on patch set 6 CR -1 11/09/19, 17:30
I'll change the icon -
Andreas Kienast uploaded patch set 7 11/09/19, 17:31
-
Andreas Kienast voted on patch set 7 V +1 CR +1 11/09/19, 17:31
-
TYPO3com voted on patch set 6 V +1 11/09/19, 17:34 Completed build in 08m 50s on Sat, 9 Nov, 05:34 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38213
-
TYPO3com voted on patch set 7 V +1 11/09/19, 17:40 Completed build in 09m 39s on Sat, 9 Nov, 05:40 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38214
-
Benni Mack voted on patch set 7 V +2 CR +2 11/09/19, 17:58
-
Benni Mack merged patch set 8 11/09/19, 17:58