Review main Merged

62032[FEATURE] Show link to online docs in extension manager

Georg Ringer CR +2 V +2 Normal +91 −6 updated 11/09/19, 17:58

Commit message

The export of extensions provided by https://extensions.typo3.org
has been extended with the link to the documentation.

This link is now shown in the list and detail view of extensions
in the extensions manager.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1727

Show 2 earlier messages
  1. Georg Ringer uploaded patch set 1 10/18/19, 23:53

  2. Georg Ringer commented on patch set 1 10/18/19, 23:54

    This change is ready for review.
  1. TYPO3com voted on patch set 1 V -1 10/19/19, 00:03 Completed build in 09m 28s on Sat, 19 Oct, 12:03 AM Test Summary: 1 of 48084 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37393

  2. TYPO3com voted on patch set 1 V +1 10/19/19, 11:15 Completed build in 11h 30m 42s on Sat, 19 Oct, 11:15 AM Test Summary: 47986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37393

  3. Chris Müller commented on patch set 1 10/28/19, 16:33

    Extension.php:623

    As the other setters don't return anything, the return statement should be removed to be in sync with them.
  4. Oli Bartsch commented on patch set 1 10/28/19, 16:46

    Extension.php:623 Reply Unresolved

    Method chaining is very useful and therefore I don't think removing it only to unify with existing setters isn't reasonable. But since it is also not used in this case, I'm with you here.
  5. Georg Ringer uploaded patch set 2 10/31/19, 06:40

  6. TYPO3com voted on patch set 2 V -1 10/31/19, 06:55 Completed build in 15m 27s on Thu, 31 Oct, 06:55 AM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37880

  7. TYPO3com voted on patch set 2 V +1 10/31/19, 07:48 Completed build in 1h 23m 19s on Thu, 31 Oct, 07:48 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37880

  8. Markus Klein commented on patch set 3 10/31/19, 07:59

    Published edit on patch set 2.
  9. Markus Klein updated the commit message in patch set 4 10/31/19, 07:59

  10. Markus Klein commented on patch set 4 10/31/19, 08:00

    Extension.php:611 Unresolved

    why no :string typehint here?
  11. TYPO3com voted on patch set 3 V -1 10/31/19, 08:11 Completed build in 12m 36s on Thu, 31 Oct, 08:11 AM Test Summary: 47829 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37882

  12. TYPO3com voted on patch set 4 V -1 10/31/19, 08:14 Completed build in 15m 20s on Thu, 31 Oct, 08:14 AM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37883

  13. TYPO3com voted on patch set 4 V +1 10/31/19, 08:26 Completed build in 42m 23s on Thu, 31 Oct, 08:26 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37883

  14. Georg Ringer uploaded patch set 5 11/05/19, 08:41

  15. TYPO3com voted on patch set 5 V +1 11/05/19, 08:51 Completed build in 09m 11s on Tue, 5 Nov, 08:51 AM Test Summary: 48123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37999

  16. Markus Klein commented on patch set 5 11/05/19, 09:00

    Feature-89458-ShowCorrectManualLinkInExtensionManager.rst:13

    The detail view can not be reached from the "installed extensions" view. IMO this should be accessible there. I rarely (almost never) look into the detail view of an extension. Moverover, the detail view is not available if it is a composer installation.
  17. Benni Mack uploaded patch set 6 11/09/19, 17:25

  18. Benni Mack commented on patch set 6 V +1 CR +1 11/09/19, 17:25

    Feature-89458-ShowCorrectManualLinkInExtensionManager.rst:13 Reply Unresolved

    I added it to the list view as well.
  19. Andreas Kienast commented on patch set 6 CR -1 11/09/19, 17:30

    I'll change the icon
  20. Andreas Kienast uploaded patch set 7 11/09/19, 17:31

  21. Andreas Kienast voted on patch set 7 V +1 CR +1 11/09/19, 17:31

  22. TYPO3com voted on patch set 6 V +1 11/09/19, 17:34 Completed build in 08m 50s on Sat, 9 Nov, 05:34 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38213

  23. TYPO3com voted on patch set 7 V +1 11/09/19, 17:40 Completed build in 09m 39s on Sat, 9 Nov, 05:40 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38214

  24. Benni Mack voted on patch set 7 V +2 CR +2 11/09/19, 17:58

  25. Benni Mack merged patch set 8 11/09/19, 17:58