Review 9.5 Abandoned

62034[BUGFIX] Respect "access" option on backend routes

Markus Poerschke CR 0 V 0 Normal +139 −71 updated 11/04/19, 15:48

Commit message

When setting the option "access" to "public" in the configuration file
Configuration/Backend/AjaxRoutes.php, then the route is expected to be
publicly available. Before only a couple of hard coded paths within
the class BackendUserAuthenticator were considered as public and routes
with the "access" option set to "public" were not be able to access
without login.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 46

  1. Markus Poerschke uploaded patch set 1 10/21/19, 11:57

  2. TYPO3com voted on patch set 1 V -1 10/21/19, 12:09 Completed build in 12m 11s on Mon, 21 Oct, 12:09 PM Test Summary: 67 of 51241 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1339

  3. Markus Poerschke uploaded patch set 2 10/21/19, 15:06

  4. TYPO3com voted on patch set 2 V +1 10/21/19, 15:52 Completed build in 44m 12s on Mon, 21 Oct, 03:52 PM Test Summary: 50773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1343

  5. Markus Poerschke commented on patch set 2 11/04/19, 10:42

    This change is ready for review.
  6. Markus Poerschke abandoned the change 11/04/19, 15:48

    The change is not needed since an easy workaround in the third-party extension can solve the problem. The backend routes registration will be reworked in v10, therefore this change is obsolete.