Review main Merged

62039[TASK] Deprecate injection of EnvironmentService in Web Request

Alexander Schnitzler CR +2 V +2 Normal +123 −1 updated 10/25/19, 09:07

Commit message

The EnvironmentService is not needed any longer in the Web
Request of Extbase, therefore the property and the injection
method of said property have been deprecated.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1321

  1. Alexander Schnitzler uploaded patch set 1 10/21/19, 13:23

  2. TYPO3com voted on patch set 1 V +1 10/21/19, 13:34 Completed build in 11m 03s on Mon, 21 Oct, 01:34 PM Test Summary: 48010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37416

  3. Alexander Schnitzler uploaded patch set 2 10/21/19, 14:21

  4. Alexander Schnitzler uploaded patch set 3 10/21/19, 14:52

  5. TYPO3com voted on patch set 2 V +1 10/21/19, 14:53 Completed build in 16m 33s on Mon, 21 Oct, 02:53 PM Test Summary: 48016 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37427

  6. TYPO3com voted on patch set 3 V -1 10/21/19, 15:37 Completed build in 29m 06s on Mon, 21 Oct, 03:37 PM Test Summary: 1 of 48375 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37432

  7. TYPO3com voted on patch set 3 V +1 10/21/19, 16:57 Completed build in 2h 18m 45s on Mon, 21 Oct, 04:57 PM Test Summary: 48016 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37432

  8. Alexander Schnitzler commented on patch set 3 10/21/19, 16:59

    This change is ready for review.
  9. Susi Moog commented on patch set 3 CR -1 10/21/19, 17:19

    please add a scanner entry
  10. Alexander Schnitzler uploaded patch set 4 10/22/19, 08:10

  11. TYPO3com voted on patch set 4 V +1 10/22/19, 08:20 Completed build in 10m 21s on Tue, 22 Oct, 08:20 AM Test Summary: 48016 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37439

  12. Alexander Schnitzler commented on patch set 4 10/22/19, 14:21

    This change is ready for review.
  13. Daniel Siepmann voted on patch set 4 CR +1 10/23/19, 09:21

  14. Daniel Goerz commented on patch set 5 10/23/19, 09:28

    Published edit on patch set 4.
  15. Daniel Goerz voted on patch set 5 V +1 CR +1 10/23/19, 09:30

  16. TYPO3com voted on patch set 5 V -1 10/23/19, 09:40 Completed build in 11m 45s on Wed, 23 Oct, 09:40 AM Test Summary: 1 of 48375 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37494

  17. TYPO3com voted on patch set 5 V +1 10/23/19, 09:59 Completed build in 42m 23s on Wed, 23 Oct, 09:59 AM Test Summary: 48016 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37494

  18. TYPO3com commented on patch set 5 10/23/19, 10:03 Completed build in 14m 02s on Wed, 23 Oct, 10:03 AM Test Summary: 48016 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37498

  19. Daniel Siepmann voted on patch set 5 CR +1 10/24/19, 13:10

  20. Anja Leichsenring voted on patch set 5 V +2 CR +2 10/25/19, 09:07

  21. Anja Leichsenring merged patch set 6 10/25/19, 09:07