Review main Merged

62040[TASK] Add seo extension docs

Kay Strobach CR +2 V +2 Hard +626 −0 updated 10/23/19, 08:54

Commit message

Provide a starting point to find all the SEO related information
directly from the extension seo.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 17

Review log 2839

Show 1114 earlier messages
  1. Kay Strobach uploaded patch set 1 10/21/19, 13:53

  2. TYPO3com voted on patch set 1 V +1 10/21/19, 14:11 Completed build in 16m 13s on Mon, 21 Oct, 02:11 PM Test Summary: 48010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37420

  3. Kay Strobach uploaded patch set 2 10/21/19, 14:13

  4. Kay Strobach commented on patch set 2 10/21/19, 14:17

    🎉
  5. Kay Strobach wrote 10/21/19, 14:18

    Topic set to DOCS / SEO
  6. Kay Strobach wrote 10/21/19, 14:18

    Topic DOCS / SEO removed
  7. Kay Strobach wrote 10/21/19, 14:18

    Topic set to DOC
  8. Kay Strobach uploaded patch set 3 10/21/19, 14:19

  9. TYPO3com voted on patch set 2 V +1 10/21/19, 14:31 Completed build in 16m 21s on Mon, 21 Oct, 02:31 PM Test Summary: 48010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37424

  10. TYPO3com voted on patch set 3 V +1 10/21/19, 14:47 Completed build in 26m 13s on Mon, 21 Oct, 02:47 PM Test Summary: 48013 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37426

  11. Daniel Siepmann uploaded patch set 4 10/22/19, 07:29

  12. Daniel Siepmann voted on patch set 4 V +1 CR +1 10/22/19, 07:29

  13. Daniel Siepmann uploaded patch set 5 10/22/19, 07:37

  14. Daniel Siepmann voted on patch set 5 V +1 CR +1 10/22/19, 07:37

  1. TYPO3com voted on patch set 4 V +1 10/22/19, 07:38 Completed build in 09m 35s on Tue, 22 Oct, 07:38 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37435

  2. TYPO3com voted on patch set 5 V +1 10/22/19, 07:47 Completed build in 10m 42s on Tue, 22 Oct, 07:47 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37436

  3. Oli Bartsch updated the commit message in patch set 6 10/22/19, 08:35

  4. Richard Haeser commented on patch set 6 CR -1 10/22/19, 08:37

    On it
  5. Richard Haeser uploaded patch set 7 10/22/19, 08:39

  6. Richard Haeser voted on patch set 7 V +1 CR +1 10/22/19, 08:39

  7. TYPO3com voted on patch set 6 V -1 10/22/19, 08:46 Completed build in 10m 39s on Tue, 22 Oct, 08:46 AM Test Summary: 47512 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37440

  8. TYPO3com voted on patch set 7 V +1 10/22/19, 08:50 Completed build in 10m 46s on Tue, 22 Oct, 08:50 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37441

  9. Chris Müller commented on patch set 7 10/22/19, 11:27

    Some typos and some questions, that raised for me

    Index.rst:41

    an -> and comma before and after "for example"

    Index.rst:53

    Locale -> locale Language Tag -> language tag

    Index.rst:59

    see line 53

    Index.rst:79

    keen -> keep

    Index.rst:89

    URL's -> URLs What do you mean with "robot HTTP headers"? X-Robots-Tag?

    Index.rst:36

    I would prefer to write "tab" in lowercase

    Index.rst:48

    Segment -> segment (as in next paragraph)

    Index.rst:54

    I don't agree with the advise: - If you move the page or change the title of one of the parent pages, the URL segment should be adjusted (which results in a needed redirect) - If you have some levels, the URL could be very long. - A short URL is also more SEO-friedly, because the relevant part of the URL is the recent page, not necessarily the parent segments. So I recommend to remove this advise.

    Index.rst:73

    Title -> title Here is some article missing: "The title for the search engine field"

    Index.rst:80

    Title -> title Or is it a reference to the page field? The perhaps `Title`?

    Index.rst:98

    wether -> whether

    Index.rst:103

    wether -> whether

    Index.rst:108

    Why penalized? As far as I know, search engines don't know, which page to use with duplicate content. So the algorithm tests it in the search results (as far as I know Google does it this way) which page performs better. So you can give a hint with the canonical URL, so the pages with the same content doesn't show up both.

    Includes.txt:22

    Add .. role:: html(code) to highlight html attribute from Introduction/Index.rst

    Index.rst:18

    wether -> whether

    Index.rst:22

    "metatags" or "meta tags"? (like in the line below)

    Index.rst:56

    "multi language" -> "multi-language"

    Index.rst:61

    I think we should use the code formatting: :html:`hreflang`
  10. Chris Müller voted on patch set 7 CR -1 10/22/19, 11:27

  11. Sybille Peters uploaded patch set 8 10/22/19, 12:40

  12. TYPO3com voted on patch set 8 V +1 10/22/19, 12:54 Completed build in 13m 51s on Tue, 22 Oct, 12:54 PM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37449

  13. Sybille Peters commented on patch set 8 10/22/19, 12:55

    I pushed some language improvements.

    Index.rst:41 Reply

    Done

    Index.rst:79 Reply

    Done

    Index.rst:36 Reply

    Done

    Index.rst:48

    Either, "the user enters" or "the users enter"

    Index.rst:73 Reply

    I suggest to use :guilabel:`some text` to refer to fields in the GUI. This will make spelling more clear to reviewers. And it should later be rendered differently in the frontend (not implemented yet)

    Index.rst:78

    "not too long and not too short" is very vague. Maybe add recommendations for title length (backed up by linking to a resource).

    Index.rst:80 Reply

    If you want to point out that you are using the spelling from the BE, you could set it in :guilabel:`Title`. This will currently not be rendered differently, but should in the future and this will also be a hint for reviewers that the spelling is intentional.

    Index.rst:98 Reply

    Done

    Index.rst:103 Reply

    Done

    Index.rst:108 Reply

    Maybe just write that the ranking may suffer by duplicate content.

    Index.rst:18 Reply

    Done
  14. Richard Haeser commented on patch set 8 10/22/19, 13:22

    Index.rst:48 Reply

    The user enters is the best one I guess

    Index.rst:54 Reply

    The structure of your website is rather important for search engines to understand your website. If you have structured data for your breadcrumb, you're all fine and you can create short URL's without a problem. Otherwise it is better to tell search engines how your site structure looks like. But as this is not a SEO manual, I will remove that.

    Index.rst:78 Reply

    Problem is that it is not based on number of characters but on the width of your title. You can have a title with more characters if you use the i a lot. If you use the w a lot, you will have less characters available. But I will try to rephrase this one.

    Index.rst:80 Reply

    Will use the :guilabel:`` markup

    Index.rst:108 Reply

    Penalized is indeed not the right word. But it can definitely influence your ranking. If two pages are "fighting" with the same content, Google will try to define what is the best page and not show the other one (why having two same results). So the idea of Sybille is the best solution I guess.
  15. Richard Haeser uploaded patch set 9 10/22/19, 14:19

  16. Richard Haeser commented on patch set 9 V +1 CR +1 10/22/19, 14:22

    Index.rst:53 Reply

    Done by adding :guilabel:`field`

    Index.rst:59 Reply

    Done

    Index.rst:89 Reply

    Done

    Index.rst:48 Reply

    Done

    Index.rst:48 Reply

    Done

    Index.rst:54 Reply

    Done

    Index.rst:73 Reply

    Done

    Index.rst:78 Reply

    Done

    Index.rst:80 Reply

    Done

    Index.rst:108 Reply

    Done

    Includes.txt:22 Reply

    Done

    Index.rst:22 Reply

    Done

    Index.rst:56 Reply

    Done

    Index.rst:61 Reply

    Done
  17. TYPO3com voted on patch set 9 V -1 10/22/19, 14:30 Completed build in 10m 44s on Tue, 22 Oct, 02:30 PM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37453

  18. TYPO3com voted on patch set 9 V +1 10/22/19, 14:37 Completed build in 28m 45s on Tue, 22 Oct, 02:37 PM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37453

  19. Daniel Goerz commented on patch set 9 CR -1 10/23/19, 08:25

    On it
  20. Daniel Goerz uploaded patch set 10 10/23/19, 08:39

  21. Daniel Goerz voted on patch set 10 V +1 CR +1 10/23/19, 08:39

  22. Richard Haeser voted on patch set 10 V +1 CR +1 10/23/19, 08:42

  23. TYPO3com voted on patch set 10 V +1 10/23/19, 08:54 Completed build in 14m 33s on Wed, 23 Oct, 08:54 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37489

  24. Richard Haeser voted on patch set 10 V +2 CR +2 10/23/19, 08:54

  25. Richard Haeser merged patch set 11 10/23/19, 08:54