Review main Merged

62042[TASK] Change to named keys in EXT:seo when using generateMetaTags hook

Richard Haeser CR +2 V +2 Easy +3 −3 updated 10/22/19, 14:27

Commit message

For EXT:seo we now use named keys for the hooks we register for
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Frontend\Page\PageGenerator']['generateMetaTags']. This will make it easier to disable specific
generators.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Chris Müller +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Chris Müller +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Richard Haeser uploaded patch set 1 10/22/19, 10:53

  2. TYPO3com voted on patch set 1 V -1 10/22/19, 11:02 Completed build in 09m 37s on Tue, 22 Oct, 11:02 AM Test Summary: 47764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37444

  3. TYPO3com voted on patch set 1 V +1 10/22/19, 11:37 Completed build in 54m 16s on Tue, 22 Oct, 11:37 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37444

  4. Chris Müller voted on patch set 1 V +1 CR +1 10/22/19, 11:46

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 10/22/19, 14:27

  6. Andreas Kienast merged patch set 2 10/22/19, 14:27