62043[TASK] Use array as service chains instead of comma-separated list
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Daniel Goerz +1
- Oli Bartsch +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Oliver Hader +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+4 −4
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+1 −0
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-89579-ServiceChainsRequireAnArrayForExcludedServiceKeys.rstnew+45 −0
Review log 1318
-
Benni Mack uploaded patch set 1 10/22/19, 11:12
-
TYPO3com voted on patch set 1 V +1 10/22/19, 11:21 Completed build in 09m 04s on Tue, 22 Oct, 11:21 AM Test Summary: 48013 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37445
-
Benni Mack uploaded patch set 2 11/04/19, 14:41
-
TYPO3com voted on patch set 2 V +1 11/04/19, 14:52 Completed build in 11m 05s on Mon, 4 Nov, 02:52 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37974
-
Oli Bartsch voted on patch set 2 CR +1 11/05/19, 08:51
-
Daniel Goerz commented on patch set 3 11/06/19, 08:35
Published edit on patch set 2. -
Daniel Goerz voted on patch set 3 CR +1 11/06/19, 08:35
-
TYPO3com voted on patch set 3 V -1 11/06/19, 08:44 Completed build in 09m 23s on Wed, 6 Nov, 08:44 AM Test Summary: 1 of 48228 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38030
-
TYPO3com commented on patch set 3 11/06/19, 09:05 Completed build in 13m 33s on Wed, 6 Nov, 09:05 AM Test Summary: 1 of 48490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38032
-
TYPO3com voted on patch set 3 V +1 11/06/19, 09:10 Completed build in 32m 32s on Wed, 6 Nov, 09:10 AM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38032
-
Oli Bartsch voted on patch set 3 CR +1 11/06/19, 15:35
-
Alexander Schnitzler commented on patch set 3 CR -1 11/07/19, 13:27
Let's add some scanner entries here. It's just weak matches but better than none. -
Benni Mack commented on patch set 3 11/07/19, 14:52
> Patch Set 3: Code-Review-1 > > Let's add some scanner entries here. It's just weak matches but better than none. yeah, let me know how to do that... having strict types for a method argument would be really nice, but I don't think we can currently that? -
Alexander Schnitzler voted on patch set 3 CR 0 11/20/19, 14:10
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 11/21/19, 11:53
-
Oliver Hader voted on patch set 3 CR +1 11/21/19, 12:00
-
Oliver Hader voted on patch set 3 V +2 CR +2 11/21/19, 12:06
-
Oliver Hader merged patch set 4 11/21/19, 12:07