Review main Merged

62048[TASK] Introduce constants for sys log writer method arguments

Alexander Schnitzler CR +2 V +2 Hard +489 −222 updated 10/25/19, 08:57

Commit message

There are several places in the core where messages are written
to the database table sys_log. Said table has the following
columns that hold unique integer values:

- type
- action
- error

Until now, those integer values had been directly put into the
log method calls which made the method calls quite unreadable.
All those integer values are now replaced with meaningful
constants.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Manuel Selbach +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Manuel Selbach +1
    • TYPO3com +1 CI

Issues 1

Files 20

Review log 2135

Show 510 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 10/22/19, 16:15

  2. TYPO3com voted on patch set 1 V -1 10/22/19, 16:27 Completed build in 11m 25s on Tue, 22 Oct, 04:26 PM Test Summary: 22 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37462

  3. Alexander Schnitzler uploaded patch set 2 10/22/19, 17:42

  4. TYPO3com voted on patch set 2 V -1 10/22/19, 17:51 Completed build in 08m 41s on Tue, 22 Oct, 05:51 PM Test Summary: 9 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37463

  5. Alexander Schnitzler uploaded patch set 3 10/22/19, 20:13

  6. Alexander Schnitzler uploaded patch set 4 10/22/19, 20:23

  7. TYPO3com voted on patch set 3 V -1 10/22/19, 20:25 Completed build in 11m 29s on Tue, 22 Oct, 08:25 PM Test Summary: 9 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37469

  8. TYPO3com voted on patch set 4 V -1 10/22/19, 20:33 Completed build in 10m 02s on Tue, 22 Oct, 08:33 PM Test Summary: 9 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37471

  9. Alexander Schnitzler uploaded patch set 5 10/22/19, 20:38

  10. TYPO3com voted on patch set 5 V -1 10/22/19, 20:48 Completed build in 10m 23s on Tue, 22 Oct, 08:48 PM Test Summary: 5 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37473

  1. TYPO3com commented on patch set 5 10/22/19, 20:52 Completed build in 24m 25s on Tue, 22 Oct, 08:52 PM Test Summary: 4 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37473

  2. TYPO3com commented on patch set 5 10/22/19, 20:55 Completed build in 40m 57s on Tue, 22 Oct, 08:55 PM Test Summary: 4 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37473

  3. Alexander Schnitzler uploaded patch set 6 10/22/19, 20:59

  4. TYPO3com voted on patch set 6 V -1 10/22/19, 21:09 Completed build in 09m 59s on Tue, 22 Oct, 09:09 PM Test Summary: 2 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37474

  5. Alexander Schnitzler uploaded patch set 7 10/22/19, 21:12

  6. TYPO3com voted on patch set 7 V +1 10/22/19, 21:21 Completed build in 09m 10s on Tue, 22 Oct, 09:21 PM Test Summary: 48013 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37475

  7. Alexander Schnitzler uploaded patch set 8 10/23/19, 07:37

  8. TYPO3com voted on patch set 8 V +1 10/23/19, 07:54 Completed build in 15m 37s on Wed, 23 Oct, 07:54 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37485

  9. Alexander Schnitzler commented on patch set 8 10/23/19, 08:00

    This change is ready for review.
  10. Alexander Schnitzler uploaded patch set 9 10/23/19, 08:40

  11. TYPO3com voted on patch set 9 V +1 10/23/19, 09:01 Completed build in 18m 37s on Wed, 23 Oct, 09:01 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37491

  12. Benni Mack commented on patch set 9 10/23/19, 09:33

    GREAT work! A few remarks

    Cache.php:21 Unresolved

    I know - unpopular opinion, but how about we name the classes CacheAction, FileAction etc. This makes it much more easier to read when I read the log() methods then.
  13. Alexander Schnitzler uploaded patch set 10 10/23/19, 09:46

  14. TYPO3com voted on patch set 10 V +1 10/23/19, 10:09 Completed build in 19m 35s on Wed, 23 Oct, 10:09 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37499

  15. Manuel Selbach commented on patch set 10 CR -1 10/23/19, 12:50

    BackendUserAuthentication.php:2150

    Action should be SystemLogGenericAction here

    DataHandler.php:1275

    Action should be SystemLogGenericAction here

    DataHandler.php:4462

    Action should be SystemLogGenericAction here

    DataHandler.php:4808

    Action should be SystemLogGenericAction here

    DataHandler.php:8155

    Action should be SystemLogGenericAction here
  16. Alexander Schnitzler uploaded patch set 11 10/23/19, 13:10

  17. TYPO3com voted on patch set 11 V +1 10/23/19, 13:20 Completed build in 10m 11s on Wed, 23 Oct, 01:20 PM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37514

  18. Manuel Selbach commented on patch set 11 CR +1 10/23/19, 14:20

    BackendUserAuthentication.php:2150 Reply

    Done

    DataHandler.php:1275 Reply

    Done

    DataHandler.php:4462 Reply

    Done

    DataHandler.php:4808 Reply

    Done

    DataHandler.php:8155 Reply

    Done
  19. Manuel Selbach voted on patch set 11 V +1 10/23/19, 14:34

  20. Alexander Schnitzler uploaded patch set 12 10/24/19, 13:28

  21. TYPO3com voted on patch set 12 V +1 10/24/19, 13:41 Completed build in 11m 54s on Thu, 24 Oct, 01:41 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37594

  22. Manuel Selbach voted on patch set 12 V +1 CR +1 10/24/19, 14:34

  23. Daniel Goerz voted on patch set 12 V +2 CR +2 10/25/19, 08:56

  24. Daniel Goerz merged patch set 13 10/25/19, 08:56

  25. Benni Mack commented on patch set 13 10/25/19, 08:57

    Thanks for everybody involved, this is a HUGE win!