62048[TASK] Introduce constants for sys log writer method arguments
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Manuel Selbach +1
-
Verified V +2 Done
- Daniel Goerz +2
- Manuel Selbach +1
- TYPO3com +1 CI
Issues 1
Files 20
- typo3/sysext/backend/Classes/Controller/LogoutController.php+4 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+5 −2
- typo3/sysext/core/Classes/Authentication/AuthenticationService.php+8 −5
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php2+6 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php8+79 −74
- typo3/sysext/core/Classes/Error/AbstractExceptionHandler.php+6 −3
- typo3/sysext/core/Classes/Error/ErrorHandler.php+7 −3
- typo3/sysext/core/Classes/SysLog/Action/Cache.php1new+24 −0
- typo3/sysext/core/Classes/SysLog/Action/Database.phpnew+28 −0
- typo3/sysext/core/Classes/SysLog/Action/File.phpnew+37 −0
- typo3/sysext/core/Classes/SysLog/Action/Login.phpnew+27 −0
- typo3/sysext/core/Classes/SysLog/Action/Setting.phpnew+24 −0
- typo3/sysext/core/Classes/SysLog/Action.phpnew+24 −0
- typo3/sysext/core/Classes/SysLog/Error.phpnew+36 −0
- typo3/sysext/core/Classes/SysLog/Type.phpnew+30 −0
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+100 −99
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+6 −4
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+6 −3
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+4 −1
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+28 −25
Review log 2135
Show 510 earlier messages
-
Alexander Schnitzler uploaded patch set 1 10/22/19, 16:15
-
TYPO3com voted on patch set 1 V -1 10/22/19, 16:27 Completed build in 11m 25s on Tue, 22 Oct, 04:26 PM Test Summary: 22 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37462
-
Alexander Schnitzler uploaded patch set 2 10/22/19, 17:42
-
TYPO3com voted on patch set 2 V -1 10/22/19, 17:51 Completed build in 08m 41s on Tue, 22 Oct, 05:51 PM Test Summary: 9 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37463
-
Alexander Schnitzler uploaded patch set 3 10/22/19, 20:13
-
Alexander Schnitzler uploaded patch set 4 10/22/19, 20:23
-
TYPO3com voted on patch set 3 V -1 10/22/19, 20:25 Completed build in 11m 29s on Tue, 22 Oct, 08:25 PM Test Summary: 9 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37469
-
TYPO3com voted on patch set 4 V -1 10/22/19, 20:33 Completed build in 10m 02s on Tue, 22 Oct, 08:33 PM Test Summary: 9 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37471
-
Alexander Schnitzler uploaded patch set 5 10/22/19, 20:38
-
TYPO3com voted on patch set 5 V -1 10/22/19, 20:48 Completed build in 10m 23s on Tue, 22 Oct, 08:48 PM Test Summary: 5 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37473
-
TYPO3com commented on patch set 5 10/22/19, 20:52 Completed build in 24m 25s on Tue, 22 Oct, 08:52 PM Test Summary: 4 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37473
-
TYPO3com commented on patch set 5 10/22/19, 20:55 Completed build in 40m 57s on Tue, 22 Oct, 08:55 PM Test Summary: 4 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37473
-
Alexander Schnitzler uploaded patch set 6 10/22/19, 20:59
-
TYPO3com voted on patch set 6 V -1 10/22/19, 21:09 Completed build in 09m 59s on Tue, 22 Oct, 09:09 PM Test Summary: 2 of 48373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37474
-
Alexander Schnitzler uploaded patch set 7 10/22/19, 21:12
-
TYPO3com voted on patch set 7 V +1 10/22/19, 21:21 Completed build in 09m 10s on Tue, 22 Oct, 09:21 PM Test Summary: 48013 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37475
-
Alexander Schnitzler uploaded patch set 8 10/23/19, 07:37
-
TYPO3com voted on patch set 8 V +1 10/23/19, 07:54 Completed build in 15m 37s on Wed, 23 Oct, 07:54 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37485
-
Alexander Schnitzler commented on patch set 8 10/23/19, 08:00
This change is ready for review. -
Alexander Schnitzler uploaded patch set 9 10/23/19, 08:40
-
TYPO3com voted on patch set 9 V +1 10/23/19, 09:01 Completed build in 18m 37s on Wed, 23 Oct, 09:01 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37491
-
Benni Mack commented on patch set 9 10/23/19, 09:33
GREAT work! A few remarksCache.php:21UnresolvedI know - unpopular opinion, but how about we name the classes CacheAction, FileAction etc. This makes it much more easier to read when I read the log() methods then. -
Alexander Schnitzler uploaded patch set 10 10/23/19, 09:46
-
TYPO3com voted on patch set 10 V +1 10/23/19, 10:09 Completed build in 19m 35s on Wed, 23 Oct, 10:09 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37499
-
Manuel Selbach commented on patch set 10 CR -1 10/23/19, 12:50
BackendUserAuthentication.php:2150Action should be SystemLogGenericAction hereDataHandler.php:1275Action should be SystemLogGenericAction hereDataHandler.php:4462Action should be SystemLogGenericAction hereDataHandler.php:4808Action should be SystemLogGenericAction hereDataHandler.php:8155Action should be SystemLogGenericAction here -
Alexander Schnitzler uploaded patch set 11 10/23/19, 13:10
-
TYPO3com voted on patch set 11 V +1 10/23/19, 13:20 Completed build in 10m 11s on Wed, 23 Oct, 01:20 PM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37514
-
Manuel Selbach commented on patch set 11 CR +1 10/23/19, 14:20
BackendUserAuthentication.php:2150ReplyDoneDataHandler.php:1275ReplyDoneDataHandler.php:4462ReplyDoneDataHandler.php:4808ReplyDoneDataHandler.php:8155ReplyDone -
Manuel Selbach voted on patch set 11 V +1 10/23/19, 14:34
-
Alexander Schnitzler uploaded patch set 12 10/24/19, 13:28
-
TYPO3com voted on patch set 12 V +1 10/24/19, 13:41 Completed build in 11m 54s on Thu, 24 Oct, 01:41 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37594
-
Manuel Selbach voted on patch set 12 V +1 CR +1 10/24/19, 14:34
-
Daniel Goerz voted on patch set 12 V +2 CR +2 10/25/19, 08:56
-
Daniel Goerz merged patch set 13 10/25/19, 08:56
-
Benni Mack commented on patch set 13 10/25/19, 08:57
Thanks for everybody involved, this is a HUGE win!