Review main Merged

62049[DOCS] Improve chapter for adding content elements

Daniel Siepmann CR +2 V +2 Hard +137 −131 updated 10/24/19, 13:19

Commit message

- Simplify wording
- Add one more example for Data Processor use case
- Add crosslink to icon registry and data processor
- Enable cross references in Settings.cfg
- Re-structure tutorial
- Use logical blocks instead of file blocks for less experienced
  developers.
- Use step syntax instead of plain headlines
- Include rst format class for proper rendering of numbered lists
- Use numbered headlines with shortlinks
- Unify writing style to address the reader

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Sybille Peters +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Sybille Peters +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Daniel Siepmann uploaded patch set 1 10/22/19, 18:47

  2. Daniel Siepmann wrote 10/22/19, 18:48

    Topic set to DOC
  3. TYPO3com voted on patch set 1 V +1 10/22/19, 18:57 Completed build in 09m 29s on Tue, 22 Oct, 06:57 PM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37464

  4. Sybille Peters uploaded patch set 2 10/23/19, 13:14

  5. TYPO3com voted on patch set 2 V +1 10/23/19, 13:24 Completed build in 09m 25s on Wed, 23 Oct, 01:24 PM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37515

  6. Jörg Bösche commented on patch set 2 CR -1 10/24/19, 07:25

    Index.rst:189

    Should be "data.bodytext -> ..."

    Index.rst:303

    Add declare strict = 1

    Settings.cfg:41

    Please fix the indention

    Settings.cfg:56

    Please fix the indention
  7. Sybille Peters uploaded patch set 3 10/24/19, 12:22

  8. Sybille Peters commented on patch set 3 V +1 CR +1 10/24/19, 12:24

    Index.rst:189 Reply

    Done

    Index.rst:303 Reply

    Done

    Settings.cfg:41 Reply

    Done

    Settings.cfg:56 Reply

    Done
  9. Jörg Bösche voted on patch set 3 V +1 CR +1 10/24/19, 12:31

  10. TYPO3com voted on patch set 3 V +1 10/24/19, 12:32 Completed build in 10m 10s on Thu, 24 Oct, 12:32 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37580

  11. Daniel Goerz voted on patch set 3 V +2 CR +2 10/24/19, 13:19

  12. Daniel Goerz merged patch set 4 10/24/19, 13:19