Review TYPO3_8-7 Merged

62054[TASK] Fix return type annotation of Extbase getArgument method

Alexander Schnitzler CR +2 V +2 Easy +1 −1 updated 10/21/19, 10:59

Commit message

It is possible to have an array as argument, e.g. select, checkbox, …
Therefore also arrays can be returned by this method.

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Alexander Schnitzler commented on patch set 1 10/21/19, 10:35

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/21/19, 10:51 Completed build in 13m 43s on Mon, 21 Oct, 10:51 AM Test Summary: 80400 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3672

  3. Oliver Klee voted on patch set 1 CR +1 10/21/19, 10:55

  4. Alexander Schnitzler voted on patch set 1 V +2 CR +2 10/21/19, 10:59

  5. Alexander Schnitzler merged patch set 2 10/21/19, 10:59