Review 9.5 Merged

62057[TASK] Change to named keys in EXT:seo when using generateMetaTags hook

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 10/22/19, 14:44

Commit message

For EXT:seo we now use named keys for the hooks we register for
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Frontend\Page\PageGenerator']['generateMetaTags']. This will make it easier to disable specific
generators.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Andreas Kienast commented on patch set 1 10/22/19, 14:27

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 10/22/19, 14:40 Completed build in 12m 07s on Tue, 22 Oct, 02:40 PM Test Summary: 1 of 50918 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1350

  3. TYPO3com voted on patch set 1 V +1 10/22/19, 14:44 Completed build in 28m 29s on Tue, 22 Oct, 02:44 PM Test Summary: 50765 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1350

  4. Richard Haeser voted on patch set 1 V +2 CR +2 10/22/19, 14:44

  5. Richard Haeser merged patch set 2 10/22/19, 14:44