Review 9.5 Merged

62061[BUGFIX] Fix 'pidonly' check in backend search

Daniel Goerz CR +2 V +2 Easy +4 −6 updated 10/23/19, 13:42

Commit message

The TCA setting 'pidonly', which is used to limit a field to be only
searched in the single page view in the list module, was broken and
didn't behave as described in the official TCA documentation.

First, the 'pidonly' setting is expected to be a boolean. However, the
'if' condition would fail for a boolean because the in_array() check in
the code was using strict type mode. Also, this check would never care
about the actual value of 'pidonly', only if it was set.

Second, you couldn't search for an integer value, while not using the
'pidonly' setting, at all.

This patch fixes this behaviour.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Daniel Goerz commented on patch set 1 10/23/19, 09:58

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/23/19, 10:13 Completed build in 14m 26s on Wed, 23 Oct, 10:13 AM Test Summary: 50769 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1362

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 10/23/19, 13:42

  4. Daniel Goerz merged patch set 2 10/23/19, 13:42