Review 9.5 Merged

62062[BUGFIX] Use Hreflang for HTML tag

Richard Haeser CR +2 V +2 Easy +1 −1 updated 10/23/19, 13:54

Commit message

With the introduction of sites the wrong siteLanguage attribute was
taken to generate the HTML tag lang attribute.

This patch changes this behavior and uses now the getHreflang getter
to fetch the correct value from the siteLanguage.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • David Gurk +1
  • Verified V +2 Done
    • Richard Haeser +2
    • David Gurk +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Richard Haeser commented on patch set 1 10/23/19, 12:48

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Http/RequestHandler.php
  2. Richard Haeser uploaded patch set 2 10/23/19, 12:51

  3. TYPO3com voted on patch set 1 V -1 10/23/19, 12:52 Completed build in 29s on Wed, 23 Oct, 12:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1365

  4. Richard Haeser commented on patch set 2 10/23/19, 12:52

    This change is ready for review.
  5. David Gurk voted on patch set 2 V +1 CR +1 10/23/19, 12:53

  6. TYPO3com voted on patch set 2 V +1 10/23/19, 13:09 Completed build in 17m 29s on Wed, 23 Oct, 01:09 PM Test Summary: 50769 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1366

  7. Richard Haeser voted on patch set 2 V +2 CR +2 10/23/19, 13:54

  8. Richard Haeser merged patch set 3 10/23/19, 13:54