Review 9.5 Merged

62071[BUGFIX] Use strict type checking for in_array() calls in JsonView

Susi Moog CR +2 V +2 Easy +31 −4 updated 10/28/19, 19:55

Commit message

If the JsonView traverses array with numeric indexes and an exclude
configuration is set, the first array element is now handled correctly.

The comparison of array index 0 with a string within in_array() yields
TRUE, hence the first element was skipped.

Review

  • Code review CR +2 Done
    • Susi Moog +2
  • Verified V +2 Done
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 35

  1. Susi Moog commented on patch set 1 10/28/19, 19:14

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 10/28/19, 19:27 Completed build in 13m 21s on Mon, 28 Oct, 07:27 PM Test Summary: 50489 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1394

  3. TYPO3com voted on patch set 1 V +1 10/28/19, 19:54 Completed build in 53m 12s on Mon, 28 Oct, 07:54 PM Test Summary: 50784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1394

  4. Susi Moog commented on patch set 1 V +2 CR +2 10/28/19, 19:55

    straigt backport, straight merge
  5. Susi Moog merged patch set 2 10/28/19, 19:55