Review main Merged

62081[BUGFIX] Use Hreflang for HTML tag

Simon Gilli CR +2 V +2 Easy +1 −1 updated 10/23/19, 12:49

Commit message

With the introduction of sites the wrong siteLanguage attribute was
taken to generate the HTML tag lang attribute.

This patch changes this behavior and uses now the getHreflang getter
to fetch the correct value from the siteLanguage.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • David Gurk +1
  • Verified V +2 Done
    • Richard Haeser +2
    • David Gurk +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Simon Gilli uploaded patch set 1 10/23/19, 10:39

  2. TYPO3com voted on patch set 1 V +1 10/23/19, 10:50 Completed build in 11m 19s on Wed, 23 Oct, 10:50 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37502

  3. Benni Mack voted on patch set 1 CR +1 10/23/19, 11:24

  4. Oliver Klee updated the commit message in patch set 2 10/23/19, 11:41

  5. TYPO3com voted on patch set 2 V +1 10/23/19, 11:51 Completed build in 09m 33s on Wed, 23 Oct, 11:51 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37505

  6. Richard Haeser voted on patch set 2 V +1 CR +1 10/23/19, 12:38

  7. David Gurk voted on patch set 2 CR +1 10/23/19, 12:45

  8. David Gurk voted on patch set 2 V +1 10/23/19, 12:47

  9. Richard Haeser voted on patch set 2 V +2 CR +2 10/23/19, 12:48

  10. Richard Haeser merged patch set 3 10/23/19, 12:48

  11. David Gurk commented on patch set 2 10/23/19, 12:49

    I testet in v9.5 in line 294 $htmlLang = $siteLanguage->getHreflang(); and it worked as well.