Review main Merged

62086[BUGFIX] Limit amount of data fetched by the page tree

Tymoteusz Motylewski CR +2 V +2 Hard +703 −132 updated 08/07/20, 11:46

Commit message

Page tree will fetch just 2 levels of pages plus pages which
are expanded on the initial load.
Next levels are fetched on demand via Ajax when expanding the node.
Search work server side now (hit enter). To clear search, click on "x"
button.
If you select a page when filtering, it's kept selected after
removing the filter.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Marcus Schwemer +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Uwe Trotzek +1
    • Sybille Peters +1
    • Marcus Schwemer +1
    • Dennis Prinse +1
    • TYPO3com +1 CI

Issues 3

Files 8

Review log 93144

Show 71119 earlier messages
  1. Tymoteusz Motylewski uploaded patch set 1 10/23/19, 17:28

  2. TYPO3com voted on patch set 1 V +1 10/23/19, 17:37 Completed build in 09m 08s on Wed, 23 Oct, 05:37 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37534

  3. Tymoteusz Motylewski uploaded patch set 2 10/23/19, 18:40

  4. TYPO3com voted on patch set 2 V +1 10/23/19, 18:50 Completed build in 09m 56s on Wed, 23 Oct, 06:50 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37538

  5. Tymoteusz Motylewski uploaded patch set 3 10/25/19, 20:53

  6. TYPO3com voted on patch set 3 V -1 10/25/19, 20:53 Completed build in 13s on Fri, 25 Oct, 08:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37746

  7. Tymoteusz Motylewski uploaded patch set 4 10/26/19, 10:09

  8. TYPO3com voted on patch set 4 V -1 10/26/19, 10:09 Completed build in 12s on Sat, 26 Oct, 10:09 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37776

  9. Tymoteusz Motylewski uploaded patch set 5 10/26/19, 11:47

  10. TYPO3com voted on patch set 5 V +1 10/26/19, 11:59 Completed build in 11m 33s on Sat, 26 Oct, 11:59 AM Test Summary: 48067 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37782

  11. Tymoteusz Motylewski commented on patch set 5 CR -1 11/15/19, 06:14

  12. Tymoteusz Motylewski uploaded patch set 6 12/02/19, 11:59

  13. Tymoteusz Motylewski commented on patch set 6 12/02/19, 12:00

  14. TYPO3com voted on patch set 6 V -1 12/02/19, 12:45 Completed build in 46m 25s on Mon, 2 Dec, 12:45 PM Test Summary: 1 of 48720 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39006

  15. TYPO3com voted on patch set 6 V +1 12/09/19, 11:52 Completed build in 0h 39m 19s on Mon, 9 Dec, 11:52 AM Test Summary: 48378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39006

  16. Richard Haeser uploaded patch set 7 12/09/19, 12:08

  17. TYPO3com voted on patch set 7 V -1 12/09/19, 12:21 Completed build in 12m 33s on Mon, 9 Dec, 12:21 PM Test Summary: 36377 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39283

  18. TYPO3com voted on patch set 7 V +1 12/09/19, 12:52 Completed build in 56m 56s on Mon, 9 Dec, 12:52 PM Test Summary: 68710 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39283

  19. Richard Haeser voted on patch set 7 V +1 12/17/19, 09:25

  20. Richard Haeser voted on patch set 7 CR +1 01/22/20, 09:39

  21. Richard Haeser commented on patch set 7 01/22/20, 09:40

    Tymoteusz you wanted to refactor some code?
  22. Tymoteusz Motylewski commented on patch set 7 01/22/20, 13:31

    Hi The missing part is 1) make search work with workspaces (right now you can't find page by workspace title) 2) remove code duplication/refactor
  23. Uwe Trotzek commented on patch set 7 V -1 02/12/20, 10:22

    I'm currently upgrading an 8.7 instance to version 10.2 and I'm also experiencing the described performance issues with the page tree. I have a page tree with ~11k pages with a max nesting level of 7 levels. Even with the applied patch of https://review.typo3.org/c/Packages/TYPO3.CMS/+/62086 the page tries to validate the permissions of every page. After debugging a bit I could find out that my setup obviously completely bypass the "load pages on demand solution". /** * Returns JSON representing page tree * * @param ServerRequestInterface $request * @return ResponseInterface */ public function fetchDataAction(ServerRequestInterface $request): ResponseInterface { $this->initializeConfiguration(); $items = []; if (!empty($request->getQueryParams()['pid'])) { // Fetching a part of a page tree $entryPoints = $this->getAllEntryPointPageTrees((int)$request->getQueryParams() ['pid']); $mountPid = (int)($request->getQueryParams()['mount'] ?? 0); $parentDepth = (int)($request->getQueryParams()['pidDepth'] ?? 0); $this->levelsToFetch = $parentDepth + 2; foreach ($entryPoints as $page) { $items = array_merge($items, $this->pagesToFlatArray($page, $mountPid, $parentDepth)); } } else { $entryPoints = $this->getAllEntryPointPageTrees(); foreach ($entryPoints as $page) { $items = array_merge($items, $this->pagesToFlatArray($page, (int)$page['uid'])); } } return new JsonResponse($items); } In my setup the condition "!empty($request->getQueryParams()['pid'])" is always false, which leads to a loading of the entire pagetree. I don't know when the parameter "$request->getQueryParams()['pid']" is set. I can provide some details to the setup which we are using: * We have only ONE mount point for all users. They all start at a root page. * To restrict access to certain subpages, we configure the visibility for certain pages via the access module only for a defined group * User who should "see" a page, are member of one or more groups. I don't know if the "one mount point for all" setup is exotic, but this worked for us for many years in a bunch of projects. --------- As Tymoteusz metioned here https://forge.typo3.org/issues/88474#note-14 I double checked if the Javascript file is cached. The file is not cached! Further investigations showed me that only the initial loading of the page tree loads the whole subtree. Once the tree is loaded and I click on a page to open the subpages your solution seems to work as it will go into the `if (!empty($request->getQueryParams()['pid'])) {` part to load the next two levels. May it possible to adjust the patch, that only the two levels of the pagetree are fetched on the initial loading as well?
  24. Tymoteusz Motylewski rebased onto patch set 8 02/26/20, 13:28

  25. TYPO3com voted on patch set 8 V -1 02/26/20, 13:38 Completed build in 10m 17s on Wed, 26 Feb, 01:38 PM Test Summary: 1 of 72481 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-716

  26. Tymoteusz Motylewski uploaded patch set 9 04/14/20, 05:55

  27. TYPO3com voted on patch set 9 V -1 04/14/20, 06:28 Completed build in 18m 31s on Tue, 14 Apr, 06:28 AM Test Summary: 1 of 73301 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2469

  28. Tymoteusz Motylewski commented on patch set 9 04/14/20, 15:12

    TreeController.php:553

    do we still need to check it after the https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848 was merged?
  29. Tymoteusz Motylewski commented on patch set 9 04/14/20, 15:14

    TreeController.php:553 Reply Unresolved

  30. Markus Klein uploaded patch set 10 04/15/20, 08:28

  31. TYPO3com voted on patch set 10 V -1 04/15/20, 08:49 Completed build in 21m 27s on Wed, 15 Apr, 08:49 AM Test Summary: 1 of 74004 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2557

  32. Tymoteusz Motylewski uploaded patch set 11 05/20/20, 21:53

  33. TYPO3com voted on patch set 11 V -1 05/20/20, 22:05 Completed build in 11m 56s on Wed, 20 May, 10:05 PM Test Summary: 7 of 74295 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3475

  34. Benni Mack updated the commit message in patch set 12 05/25/20, 18:52

  35. Richard Haeser uploaded patch set 13 05/27/20, 14:49

  36. TYPO3com voted on patch set 13 V -1 05/27/20, 15:08 Completed build in 18m 59s on Wed, 27 May, 03:08 PM Test Summary: 7 of 74208 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3593

  37. Uwe Trotzek commented on patch set 13 V -1 05/28/20, 06:26

    The latest patch improves the performance tremendously. In addition to the missing workspace support - which is already on the TODO list - I found this one: The page tree does not remember the expanded nodes lower than level 2 and collapses all nodes after the tree gets reloaded.
  38. Richard Haeser commented on patch set 13 05/28/20, 07:28

    > Patch Set 13: Verified-1 > > The latest patch improves the performance tremendously. > > In addition to the missing workspace support - which is already on the TODO list - I found this one: > > The page tree does not remember the expanded nodes lower than level 2 and collapses all nodes after the tree gets reloaded. I should have mentioned that in the todo indeed. Known behaviour. Working on that
  39. Richard Haeser uploaded patch set 14 06/02/20, 07:49

  40. TYPO3com voted on patch set 14 V -1 06/02/20, 08:01 Completed build in 11m 08s on Tue, 2 Jun, 08:01 AM Test Summary: 7 of 73341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3738

  41. Richard Haeser uploaded patch set 15 06/02/20, 10:01

  42. TYPO3com voted on patch set 15 V -1 06/02/20, 10:12 Completed build in 10m 37s on Tue, 2 Jun, 10:11 AM Test Summary: 7 of 73341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3741

  43. Richard Haeser uploaded patch set 16 06/03/20, 18:01

  44. TYPO3com voted on patch set 16 V -1 06/03/20, 18:12 Completed build in 11m 12s on Wed, 3 Jun, 06:12 PM Test Summary: 7 of 73335 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3788

  45. Richard Haeser uploaded patch set 17 06/03/20, 19:20

  46. TYPO3com voted on patch set 17 V -1 06/03/20, 19:32 Completed build in 11m 31s on Wed, 3 Jun, 07:32 PM Test Summary: 7 of 73335 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3795

  47. Richard Haeser uploaded patch set 18 06/03/20, 19:59

  48. TYPO3com voted on patch set 18 V -1 06/03/20, 20:12 Completed build in 12m 43s on Wed, 3 Jun, 08:12 PM Test Summary: 7 of 73335 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3799

  49. Stephan Großberndt marked it work in progress 06/04/20, 08:10

  50. Richard Haeser uploaded patch set 19 06/04/20, 14:07

  51. TYPO3com voted on patch set 19 V -1 06/04/20, 14:19 Completed build in 12m 02s on Thu, 4 Jun, 02:19 PM Test Summary: 7 of 73335 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3823

  52. Richard Haeser uploaded patch set 20 06/04/20, 14:35

  53. TYPO3com voted on patch set 20 V -1 06/04/20, 14:47 Completed build in 12m 02s on Thu, 4 Jun, 02:47 PM Test Summary: 7 of 73335 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3825

  54. Richard Haeser uploaded patch set 21 06/04/20, 15:05

  55. TYPO3com voted on patch set 21 V -1 06/04/20, 15:18 Completed build in 13m 02s on Thu, 4 Jun, 03:18 PM Test Summary: 41 of 73335 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3826

  56. TYPO3com commented on patch set 21 06/04/20, 15:28 Completed build in 11m 48s on Thu, 4 Jun, 03:28 PM Test Summary: 41 of 73335 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3827

  57. TYPO3com commented on patch set 21 06/04/20, 18:10 Completed build in 12m 20s on Thu, 4 Jun, 06:10 PM Test Summary: 41 of 73329 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3829

  58. Richard Haeser uploaded patch set 22 06/04/20, 18:28

  59. TYPO3com voted on patch set 22 V -1 06/04/20, 18:41 Completed build in 13m 00s on Thu, 4 Jun, 06:41 PM Test Summary: 7 of 73329 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3832

  60. Richard Haeser uploaded patch set 23 06/04/20, 19:29

  61. TYPO3com voted on patch set 23 V -1 06/04/20, 20:21 Completed build in 37m 30s on Thu, 4 Jun, 08:21 PM Test Summary: 7 of 73329 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3839

  62. Richard Haeser uploaded patch set 24 06/04/20, 21:03

  63. TYPO3com voted on patch set 24 V -1 06/04/20, 21:16 Completed build in 13m 30s on Thu, 4 Jun, 09:16 PM Test Summary: 8 of 73329 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3845

  64. Richard Haeser uploaded patch set 25 06/05/20, 13:33

  65. TYPO3com voted on patch set 25 V -1 06/05/20, 13:46 Completed build in 12m 51s on Fri, 5 Jun, 01:46 PM Test Summary: 7 of 73299 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3859

  66. Richard Haeser uploaded patch set 26 06/08/20, 12:38

  67. TYPO3com voted on patch set 26 V -1 06/08/20, 12:51 Completed build in 12m 41s on Mon, 8 Jun, 12:51 PM Test Summary: 7 of 73299 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3884

  68. Richard Haeser uploaded patch set 27 06/08/20, 14:50

  69. TYPO3com voted on patch set 27 V -1 06/08/20, 15:02 Completed build in 11m 55s on Mon, 8 Jun, 03:02 PM Test Summary: 4 of 73299 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3887

  70. Richard Haeser uploaded patch set 28 06/08/20, 20:27

  71. TYPO3com voted on patch set 28 V -1 06/08/20, 20:45 Completed build in 17m 19s on Mon, 8 Jun, 08:45 PM Test Summary: 1 of 73323 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3891

  72. TYPO3com commented on patch set 28 07/10/20, 07:36 Completed build in 18m 55s on Fri, 10 Jul, 07:36 AM Test Summary: 1 of 73362 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4058

  73. Richard Haeser rebased onto patch set 29 07/10/20, 19:21

  74. TYPO3com voted on patch set 29 V -1 07/10/20, 19:35 Completed build in 13m 39s on Fri, 10 Jul, 07:35 PM Test Summary: 1 of 73362 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4065

  75. Richard Haeser uploaded patch set 30 07/10/20, 21:44

  76. TYPO3com voted on patch set 30 V -1 07/10/20, 22:45 Completed build in 39m 33s on Fri, 10 Jul, 10:45 PM Test Summary: 1 of 73362 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4066

  77. Richard Haeser uploaded patch set 31 07/12/20, 18:28

  78. Richard Haeser uploaded patch set 32 07/12/20, 18:39

  79. TYPO3com voted on patch set 31 V -1 07/12/20, 18:43 Completed build in 14m 49s on Sun, 12 Jul, 06:43 PM Test Summary: 1 of 73362 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4071

  80. TYPO3com voted on patch set 32 V -1 07/12/20, 18:54 Completed build in 14m 49s on Sun, 12 Jul, 06:54 PM Test Summary: 1 of 73362 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4072

  81. Richard Haeser uploaded patch set 33 07/12/20, 19:09

  82. TYPO3com voted on patch set 33 V -1 07/12/20, 19:22 Completed build in 13m 36s on Sun, 12 Jul, 07:22 PM Test Summary: 1 of 73362 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4073

  83. Richard Haeser uploaded patch set 34 07/12/20, 19:33

  84. TYPO3com voted on patch set 34 V -1 07/12/20, 19:48 Completed build in 15m 13s on Sun, 12 Jul, 07:48 PM Test Summary: 1 of 73362 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4074

  85. Richard Haeser uploaded patch set 35 07/12/20, 20:32

  86. Richard Haeser uploaded patch set 36 07/12/20, 20:38

  87. TYPO3com voted on patch set 35 V +1 07/12/20, 20:51 Completed build in 18m 49s on Sun, 12 Jul, 08:51 PM Test Summary: 72875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4075

  88. TYPO3com voted on patch set 36 V +1 07/12/20, 20:59 Completed build in 18m 37s on Sun, 12 Jul, 08:59 PM Test Summary: 72875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4076

  89. Tymoteusz Motylewski commented on patch set 36 07/13/20, 05:40

    This change is ready for review.
  90. Oliver Klee commented on patch set 36 07/13/20, 10:11

    > This change is ready for review. Are you sure? The commit message still has the [WIP] marker, and there still are some TODOs listed in the commit message.
  91. Richard Haeser commented on patch set 36 07/13/20, 10:14

    The Gerrit WIP state is removed to make sure it can be reviewed as soon as I finished it. As you say: the title still states WIP and that is still that state (for today)
  92. Richard Haeser uploaded patch set 37 07/13/20, 19:08

  93. TYPO3com voted on patch set 37 V +1 07/13/20, 19:20 Completed build in 11m 35s on Mon, 13 Jul, 07:20 PM Test Summary: 72875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4086

  94. Richard Haeser uploaded patch set 38 07/13/20, 19:38

  95. TYPO3com voted on patch set 38 V -1 07/13/20, 19:50 Completed build in 11m 26s on Mon, 13 Jul, 07:50 PM Test Summary: 72875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4087

  96. Richard Haeser uploaded patch set 39 07/13/20, 19:53

  97. TYPO3com voted on patch set 39 V +1 07/13/20, 20:06 Completed build in 13m 14s on Mon, 13 Jul, 08:06 PM Test Summary: 72875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4088

  98. Oliver Hader commented on patch set 39 CR -1 07/13/20, 20:39

    TreeController.php:449 Unresolved

    parameter types

    TreeController.php:496 Unresolved

    please avoid this dual usage as integer and array - e.g. something like `entryPointId` and `entryPointRecord` would be good

    PageTreeRepository.php:162 Unresolved

    types

    PageTreeRepository.php:174 Unresolved

    `array_column($pageRecords, 'uid')`

    PageTreeRepository.php:189 Unresolved

    actually only required in case the tree is fetched having a valid (>0) workspace Context

    PageTreeRepository.php:231 Unresolved

    createNamedParameter & INT_ARRAY - otherwise it can be used as SQL injection

    PageTreeRepository.php:257 Unresolved

    createNamedParameter & INT_ARRAY - otherwise it can be used as SQL injection
  99. Richard Haeser uploaded patch set 40 07/13/20, 21:00

  100. Richard Haeser commented on patch set 40 07/13/20, 21:00

    > Patch Set 39: Code-Review-1 > > (7 comments) Thanks for the feedback! Fixed all the mentioned issues
  101. TYPO3com voted on patch set 40 V +1 07/13/20, 21:13 Completed build in 13m 13s on Mon, 13 Jul, 09:13 PM Test Summary: 72875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4090

  102. Uwe Trotzek commented on patch set 40 V -1 07/14/20, 12:02

    I'm currently testing the provided patch which works quite well except of the following points. These are all related to the filter function of the page tree. Maybe the errors are instance related. But I have no idea which configuration could lead to that. 1. Filter Page by title as an admin This leads to an infinite loop in PageTreeRepository->addChildrenToPage. After a bit of debugging I found out that PageTreeRepository->filterPagesOnMountPoints returns an array with an element which looks like: [ 'uid' => 0, 'pid' => NULL, 'title' => NULL, 'doktype' => NULL, 'slug' => NULL, 'tsconfig_includes' => NULL, 'TSconfig' => NULL, 'is_siteroot' => NULL, 't3ver_oid' => NULL, 't3ver_wsid' => NULL, 't3ver_state' => NULL, 't3ver_stage' => NULL, 'backend_layout_next_level' => NULL, 'hidden' => NULL, 'starttime' => NULL, 'endtime' => NULL, 'fe_group' => NULL, 'nav_hide' => NULL, 'content_from_pid' => NULL, 'module' => NULL, 'extendToSubpages' => NULL, 'sorting' => NULL, 'nav_title' => NULL, 'php_tree_stop' => NULL, 't3ver_tstamp' => NULL, 't3ver_move_id' => NULL, 'perms_userid' => NULL, 'perms_user' => NULL, 'perms_groupid' => NULL, 'perms_group' => NULL, 'perms_everybody' => NULL, 'mount_pid' => NULL, 'shortcut' => NULL, 'shortcut_mode' => NULL, 'mount_pid_ol' => NULL, 'url' => NULL, 'sys_language_uid' => NULL, 'l10n_parent' => NULL, ) ] I'm not sure why this "null" element will be added, but it will be returned from: $rootline = BackendUtility::BEgetRootLine( $pageRecord['uid'], '', $this->getBackendUser()->workspace != 0, $this->fields ); in PageTreeRepository->filterPagesOnMountPoints. If I remove this element by hand, the filter function works as expected. May it possible to skip those elements in the loop? 2. Filter page tree by title as a non admin The following error is thrown. The cause is the same as I mentioned under 1. PHP Fatal error: Uncaught RuntimeException: The given page record is invalid. Missing uid. in /app/WWW/typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php:393\nStack trace:\n#0 /app/WWW/typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php(547): TYPO3\\CMS\\Core\\Authentication\\BackendUserAuthentication->isInWebMount()\n#1 /app/WWW/typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php(497): TYPO3\\CMS\\Backend\\Tree\\Repository\\PageTreeRepository->filterPagesOnMountPoints()\n#2 /app/WWW/typo3/sysext/backend/Classes/Controller/Page/TreeController.php(475): TYPO3\\CMS\\Backend\\Tree\\Repository\\PageTreeRepository->fetchFilteredTree()\n#3 /app/WWW/typo3/sysext/backend/Classes/Controller/Page/TreeController.php(254): TYPO3\\CMS\\Backend\\Controller\\Page\\TreeController->getAllEntryPointPageTrees()\n#4 [internal function]: TYPO3\\CMS\\Backend\\Controller\\Page\\TreeController->filterDataAction()\n#5 /app/WWW/typo3/sysext/backend/Classes/Http/RouteDispatcher.php(66): call_user_func_array()\n#6 /app/WWW/typo3/syse in /app/WWW/typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php on line 393 3. Created page in draft mode will be shown twice after filtering the page tree I think this is a minor bug. It seems that the new placeholder of a page will be shown in the page tree. Steps to reproduce: * switch to workspace * create a page with title 'a new page' * filter the page tree by 'a new page' Expected behaviour: The created page should be shown in the page tree Actual behaviour: The created page is shown twice. The new placeholder and the version.
  103. Marcus Schwemer commented on patch set 40 07/14/20, 14:35

    Hi,
  104. Marcus Schwemer commented on patch set 40 07/14/20, 14:37

    I can't confirm the search issue for admins, but for non admins.
  105. Marcus Schwemer voted on patch set 40 V -1 07/14/20, 14:38

  106. Richard Haeser commented on patch set 40 07/14/20, 14:38

    Me too. Working on patch
  107. Marcus Schwemer commented on patch set 40 07/14/20, 15:03

    As the search behaviour changed from "autocompletion" to an explicit action, we should a hint to the search bar placeholder. May it be a symbol or a text like "type and hit enter"
  108. Marcus Schwemer commented on patch set 40 07/14/20, 15:32

    TreeController.php:124

    This line could be moved to the method "initializeConfiguration",. Then we have the collection of all settings stuff in one place.
  109. Richard Haeser uploaded patch set 41 07/14/20, 20:55

  110. Richard Haeser uploaded patch set 42 07/14/20, 21:01

  111. Richard Haeser uploaded patch set 43 07/14/20, 21:05

  112. Richard Haeser uploaded patch set 44 07/14/20, 21:07

  113. TYPO3com voted on patch set 41 V +1 07/14/20, 21:08 Completed build in 12m 37s on Tue, 14 Jul, 09:08 PM Test Summary: 72875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4093

  114. Richard Haeser commented on patch set 44 07/14/20, 21:12

    > Patch Set 40: Verified-1 > > I'm currently testing the provided patch which works quite well except of the following points. These are all related to the filter function of the page tree. > Maybe the errors are instance related. But I have no idea which configuration could lead to that. > > 1. Filter Page by title as an admin > > This leads to an infinite loop in PageTreeRepository->addChildrenToPage. > After a bit of debugging I found out that PageTreeRepository->filterPagesOnMountPoints returns an array with an element which looks like: > [ > 'uid' => 0, > 'pid' => NULL, > 'title' => NULL, > 'doktype' => NULL, > 'slug' => NULL, > 'tsconfig_includes' => NULL, > 'TSconfig' => NULL, > 'is_siteroot' => NULL, > 't3ver_oid' => NULL, > 't3ver_wsid' => NULL, > 't3ver_state' => NULL, > 't3ver_stage' => NULL, > 'backend_layout_next_level' => NULL, > 'hidden' => NULL, > 'starttime' => NULL, > 'endtime' => NULL, > 'fe_group' => NULL, > 'nav_hide' => NULL, > 'content_from_pid' => NULL, > 'module' => NULL, > 'extendToSubpages' => NULL, > 'sorting' => NULL, > 'nav_title' => NULL, > 'php_tree_stop' => NULL, > 't3ver_tstamp' => NULL, > 't3ver_move_id' => NULL, > 'perms_userid' => NULL, > 'perms_user' => NULL, > 'perms_groupid' => NULL, > 'perms_group' => NULL, > 'perms_everybody' => NULL, > 'mount_pid' => NULL, > 'shortcut' => NULL, > 'shortcut_mode' => NULL, > 'mount_pid_ol' => NULL, > 'url' => NULL, > 'sys_language_uid' => NULL, > 'l10n_parent' => NULL, > ) > ] > > I'm not sure why this "null" element will be added, but it will be returned from: > > $rootline = BackendUtility::BEgetRootLine( > $pageRecord['uid'], > '', > $this->getBackendUser()->workspace != 0, > $this->fields > ); > > in PageTreeRepository->filterPagesOnMountPoints. If I remove this element by hand, the filter function works as expected. May it possible to skip those elements in the loop? > > 2. Filter page tree by title as a non admin > > The following error is thrown. The cause is the same as I mentioned under 1. > > PHP Fatal error: Uncaught RuntimeException: The given page record is invalid. Missing uid. in /app/WWW/typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php:393\nStack trace:\n#0 /app/WWW/typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php(547): TYPO3\\CMS\\Core\\Authentication\\BackendUserAuthentication->isInWebMount()\n#1 /app/WWW/typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php(497): TYPO3\\CMS\\Backend\\Tree\\Repository\\PageTreeRepository->filterPagesOnMountPoints()\n#2 /app/WWW/typo3/sysext/backend/Classes/Controller/Page/TreeController.php(475): TYPO3\\CMS\\Backend\\Tree\\Repository\\PageTreeRepository->fetchFilteredTree()\n#3 /app/WWW/typo3/sysext/backend/Classes/Controller/Page/TreeController.php(254): TYPO3\\CMS\\Backend\\Controller\\Page\\TreeController->getAllEntryPointPageTrees()\n#4 [internal function]: TYPO3\\CMS\\Backend\\Controller\\Page\\TreeController->filterDataAction()\n#5 /app/WWW/typo3/sysext/backend/Classes/Http/RouteDispatcher.php(66): call_user_func_array()\n#6 /app/WWW/typo3/syse in /app/WWW/typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php on line 393 > > > 3. Created page in draft mode will be shown twice after filtering the page tree > > I think this is a minor bug. It seems that the new placeholder of a page will be shown in the page tree. Steps to reproduce: > > * switch to workspace > * create a page with title 'a new page' > * filter the page tree by 'a new page' > > Expected behaviour: > The created page should be shown in the page tree > > Actual behaviour: > The created page is shown twice. The new placeholder and the version. These issues are fixed now
  115. Richard Haeser commented on patch set 44 07/14/20, 21:12

    > Patch Set 40: > > As the search behaviour changed from "autocompletion" to an explicit action, we should a hint to the search bar placeholder. May it be a symbol or a text like "type and hit enter" Fixed
  116. Richard Haeser commented on patch set 44 07/14/20, 21:13

    TreeController.php:124 Reply

    Done
  117. TYPO3com voted on patch set 42 V +1 07/14/20, 21:14 Completed build in 12m 14s on Tue, 14 Jul, 09:14 PM Test Summary: 72875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4094

  118. TYPO3com voted on patch set 43 V +1 07/14/20, 21:18 Completed build in 13m 04s on Tue, 14 Jul, 09:18 PM Test Summary: 72875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4095

  119. TYPO3com voted on patch set 44 V +1 07/14/20, 21:23 Completed build in 14m 24s on Tue, 14 Jul, 09:23 PM Test Summary: 72875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4096

  1. Uwe Trotzek commented on patch set 44 V +1 07/15/20, 07:19

    LGTM! Nice work. Tested it in an instance with about 11000 pages with workspaces enabled and it's really fast. The issues I reported earlier are not reproducible anymore.
  2. Marieke de Bruin commented on patch set 44 V +1 07/15/20, 08:13

    Works well! Tested in an instance with about 90.000 pages.
  3. Sybille Peters commented on patch set 44 07/15/20, 09:18

    The commit message says that issue https://forge.typo3.org/issues/88259 should be resolved too but my tests do not confirm this: If filtering by page uid, the subpages of the page are not displayed. (I actually think this might be a good idea to handle this separately, but then the commit msg should get changed).
  4. Sybille Peters commented on patch set 44 V +1 07/15/20, 09:33

    Search (in top right, not filter) now takes very long (70 seconds) with my testsystem of 38767 pages. I rarely use search and just using the filter is usually sufficient but it might be something to look at in future. Overall performance has improved significantly. For some operations the spinner appears for a short time (~ 2s) but all operations are much smoother including login, inserting a page, editing a page, moving a page etc. I did not test workspaces.
  5. Sybille Peters commented on patch set 44 07/15/20, 10:26

    > Patch Set 44: > > The commit message says that issue https://forge.typo3.org/issues/88259 should be resolved too but my tests do not confirm this: If filtering by page uid, the subpages of the page are not displayed. (I actually think this might be a good idea to handle this separately, but then the commit msg should get changed). Correction: The subpages will now be displayed if you click on the arrow. I did not see that. Nicely done. Works here.
  6. Marcus Schwemer commented on patch set 44 V +1 CR +1 07/15/20, 12:31

    Thanks :-) Works here as expected.
  7. Richard Haeser commented on patch set 44 V +1 CR +1 07/16/20, 12:35

    A vote of another core-dev is best as both Tymoteusz and I have worked on this patch. I verified the patch with 3 client-setups and all working smoothly.
  8. anonymized-52878 commented on patch set 44 CR +1 07/17/20, 18:59

    One very little thing: in AjaxRoutes.php I suggest to change the comment from "// Get data for page tree" to "// Get filter for page tree". Other then that it looks good to me.
  9. Markus Klein commented on patch set 44 CR -1 07/17/20, 19:50

    Unresolved

    works

    TreeController.php:223

    add a comment why this number "2" is here!

    TreeController.php:246 Unresolved

    Search word "0" will not be found! use !== '' instead

    TreeController.php:448 Unresolved

    please describe what this can be used for

    PageTreeRepository.php:163

    missing return type annotation

    PageTreeRepository.php:181

    here too

    PageTreeRepository.php:212

    here too
  10. Richard Haeser uploaded patch set 45 07/18/20, 07:38

  11. TYPO3com voted on patch set 45 V -1 07/18/20, 07:49 Completed build in 11m 09s on Sat, 18 Jul, 07:49 AM Test Summary: 8 of 73444 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4147

  12. Richard Haeser uploaded patch set 46 07/18/20, 08:46

  13. TYPO3com voted on patch set 46 V +1 07/18/20, 08:57 Completed build in 10m 58s on Sat, 18 Jul, 08:57 AM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4148

  14. Markus Klein commented on patch set 46 07/20/20, 07:09

    TreeController.php:223 Reply

    Done

    TreeController.php:246

    my last comment here is still unresolved. any reason you did not adjust? otherwise I will adjust

    TreeController.php:448

    Sorry for nagging, but this description does not help so much. "What" can I supply here? A SQL string? Does it have to start with " AND" or something?

    PageTreeRepository.php:163 Reply

    Done

    PageTreeRepository.php:181 Reply

    Done

    PageTreeRepository.php:212 Reply

    Done
  15. Benni Mack commented on patch set 46 07/20/20, 07:18

    PageTreeRepository.php:128

    should we use a non-default value for $levels? Also, int $entryPoint, int $levels would be cool, I guess.

    PageTreeRepository.php:170

    if $depth is always given, I wouldn't build it as an "optional" parameter.

    PageTreeRepository.php:214

    isn't this superfluous? as this is done in line 205 already?

    PageTreeRepository.php:291

    if (!empty($pageRecords)) is faster here

    PageTreeRepository.php:580

    use $this->getBackendUser() instead of $GLOBALS[BE_USER]

    PlainDataResolver.php:182

    check out the $keepDeletedPlaceholder option
  16. Richard Haeser uploaded patch set 47 07/20/20, 18:52

  17. Richard Haeser commented on patch set 46 07/20/20, 18:52

    TreeController.php:246 Reply

    Done

    TreeController.php:448 Reply

    Done

    PageTreeRepository.php:128 Reply Unresolved

    This comment is based on an old patchset. Type hinting is already done in latest patch set. We use a different number of levels for example when searching and just want to get 1 (extra) level of pages.

    PageTreeRepository.php:170 Reply

    Done

    PageTreeRepository.php:214 Reply

    Done

    PageTreeRepository.php:291 Reply

    Done

    PageTreeRepository.php:580 Reply

    Done

    PlainDataResolver.php:182 Reply Unresolved

    Changed it back. Don't know why I changed it in the first place as it seems to work fine without this.
  18. TYPO3com voted on patch set 47 V +1 07/20/20, 19:04 Completed build in 11m 27s on Mon, 20 Jul, 07:04 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4165

  19. Sybille Peters voted on patch set 47 V +1 07/21/20, 13:03

  20. Dennis Prinse voted on patch set 47 V +1 07/21/20, 15:02

  21. Marcus Schwemer voted on patch set 47 V +1 CR +1 07/21/20, 15:42

  22. Uwe Trotzek voted on patch set 47 V +1 07/22/20, 09:36

  23. Richard Haeser commented on patch set 47 V +2 CR +2 07/23/20, 08:16

    After discussion with Benni, we will merge this one.
  24. Richard Haeser merged patch set 48 07/23/20, 08:16

  25. Benni Mack wrote 08/07/20, 11:46

    Created a revert of this change as I03b6ff9e63a1425fae3745f70bbd9b8a2a94c081