62088[TASK] Harden \TYPO3\CMS\Extbase\Persistence\Generic\Mapper\DataMap
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMap.php2+77 −344
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+0 −55
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+7 −10
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+1 −1
Review log 1321
-
Alexander Schnitzler uploaded patch set 1 10/23/19, 19:37
-
TYPO3com voted on patch set 1 V +1 10/23/19, 19:47 Completed build in 09m 44s on Wed, 23 Oct, 07:47 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37542
-
Alexander Schnitzler updated the commit message in patch set 2 10/23/19, 20:00
-
TYPO3com voted on patch set 2 V +1 10/23/19, 20:10 Completed build in 10m 21s on Wed, 23 Oct, 08:10 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37544
-
Alexander Schnitzler uploaded patch set 3 10/25/19, 08:30
-
TYPO3com voted on patch set 3 V -1 10/25/19, 08:40 Completed build in 09m 54s on Fri, 25 Oct, 08:40 AM Test Summary: 4 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37635
-
Oliver Klee commented on patch set 3 10/25/19, 08:42
-
Daniel Goerz updated the commit message in patch set 4 10/25/19, 09:05
-
TYPO3com voted on patch set 4 V -1 10/25/19, 09:36 Completed build in 28m 21s on Fri, 25 Oct, 09:36 AM Test Summary: 5 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37648
-
Daniel Goerz rebased onto patch set 5 10/25/19, 10:05
-
TYPO3com voted on patch set 5 V -1 10/25/19, 10:30 Completed build in 15m 20s on Fri, 25 Oct, 10:30 AM Test Summary: 5 of 48368 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37658
-
TYPO3com commented on patch set 5 12/06/19, 12:47 Completed build in 07m 57s on Fri, 6 Dec, 12:47 PM Test Summary: 6 of 69213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39151
-
TYPO3com commented on patch set 5 12/15/19, 15:50 Completed build in 3h 18m 32s on Sun, 15 Dec, 03:50 PM Test Summary: 6 of 69213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39151
-
Susi Moog commented on patch set 6 12/15/19, 15:53
Published edit on patch set 5. -
TYPO3com voted on patch set 6 V +1 12/15/19, 16:01 Completed build in 07m 14s on Sun, 15 Dec, 04:01 PM Test Summary: 68726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39437
-
Benni Mack commented on patch set 6 12/27/19, 22:46
DataMap.php:118I think the initial idea of the Factory was that the DataMap does not "know" about global TCA state? -
Alexander Schnitzler commented on patch set 6 CR -1 12/28/19, 14:01
DataMap.php:118Reply UnresolvedThat's true. We should pass in the control section of the TCA instead I guess. -
Alexander Schnitzler marked it work in progress 01/12/20, 12:20
-
Benni Mack wrote 11/29/21, 10:01
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 7 11/29/21, 13:16
-
Alexander Schnitzler abandoned the change 04/01/23, 17:15
Unresolved