Review main Merged

62090[BUGFIX] Load uncached site configuration in editAction

Kevin Appelt CR +2 V +2 Easy +32 −9 updated 01/25/20, 15:08

Commit message

By loading the uncached site configuration, no direct
changes to the configuration files are overridden when
using the Site management module.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Sascha Rademacher +1
    • Henning Liebe +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Susi Moog +2
    • Sascha Rademacher +1
    • Henning Liebe +1
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 3141

Show 1016 earlier messages
  1. Kevin Appelt uploaded patch set 1 10/24/19, 07:56

  2. Simon Gilli commented on patch set 1 10/24/19, 08:05

    SiteFinder.php:73

    Maybe instead of creating a new instance here it would be better to use the instance from the constructor which can be easy stored there to a protected or private var
  3. Simon Gilli commented on patch set 1 10/24/19, 08:07

    not for 9.5 as it's a bugfix?
  4. Kevin Appelt commented on patch set 1 10/24/19, 08:11

    Reply

    Currently checking if it needs a backport - but the backport needs to be bigger as the "useCache" parameter in SiteConfiguration->resolveAllExistingSites was added in v10 and is not available in v9. But will check it and provide a complete backport if needed.
  5. TYPO3com voted on patch set 1 V -1 10/24/19, 08:15 Completed build in 15m 15s on Thu, 24 Oct, 08:15 AM Test Summary: 1 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37558

  6. TYPO3com commented on patch set 1 10/24/19, 08:45 Completed build in 25m 07s on Thu, 24 Oct, 08:45 AM Test Summary: 1 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37565

  7. Kevin Appelt commented on patch set 1 10/24/19, 08:45

    Reply

    Confirmed, backport needed and provided here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62093
  8. TYPO3com voted on patch set 1 V +1 10/24/19, 08:58 Completed build in 1h 12m 57s on Thu, 24 Oct, 08:58 AM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37558

  9. Kevin Appelt uploaded patch set 2 10/24/19, 08:58

  10. TYPO3com voted on patch set 2 V -1 10/24/19, 08:59 Completed build in 21s on Thu, 24 Oct, 08:59 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37569

  11. Kevin Appelt uploaded patch set 3 10/24/19, 09:00

  12. TYPO3com voted on patch set 3 V -1 10/24/19, 09:01 Completed build in 16s on Thu, 24 Oct, 09:01 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37570

  13. Kevin Appelt uploaded patch set 4 10/24/19, 09:03

  14. TYPO3com voted on patch set 4 V +1 10/24/19, 09:13 Completed build in 09m 46s on Thu, 24 Oct, 09:13 AM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37571

  15. Kevin Appelt abandoned the change 10/24/19, 09:39

    Wrong change id
  16. Kevin Appelt restored the change 10/24/19, 09:40

  1. Kevin Appelt commented on patch set 4 10/24/19, 09:48

    SiteFinder.php:73 Reply

    Done
  2. Oliver Klee commented on patch set 4 10/24/19, 09:59

    SiteFinder.php:73

    Instead of having a boolean parameter to switch between two different sets of behavior (which is a bad code smell), I propose adding a new method getAllSitesWithoutCache (or something like this). And if it is possible, also rename the old method to getAllSitesWitchCache.
  3. Kevin Appelt commented on patch set 4 10/24/19, 12:03

    SiteFinder.php:73 Reply

    As the renaming of a public method would be breaking and I see no significant performance improvement with two methods I would stick with this change and not introduce a new method for this.
  4. Oliver Klee commented on patch set 4 10/24/19, 12:06

    SiteFinder.php:73 Reply

    I think I haven't made my point sufficiently clear. It's not about performance, it's about clear communication to the reader (i.e., clean code).
  5. Simon Gilli commented on patch set 4 10/24/19, 12:15

    Reply

    You don't have to provide a backport, that's the part of the core. But you have to add the version here, change this line to `master, 9.5`, that's all...
  6. Simon Gilli commented on patch set 4 10/24/19, 12:16

    SiteFinder.php:73 Reply

    Ack
  7. Kevin Appelt commented on patch set 4 10/24/19, 12:25

    Reply

    The new (correct) backport is this one: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62094 As it needs further code changes that are new in v10 and therefore not available in v9 it have to be an own patch. :)
  8. Simon Gilli commented on patch set 4 10/24/19, 12:33

    Reply

    As mentioned in the core-dev-channel, a core team member is resposible for that. So please add the missing version here
  9. Susi Moog updated the commit message in patch set 5 10/24/19, 17:00

  10. TYPO3com voted on patch set 5 V +1 10/24/19, 17:10 Completed build in 10m 17s on Thu, 24 Oct, 05:10 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37615

  11. Kevin Appelt commented on patch set 5 10/25/19, 18:14

    Reply

    Done
  12. Richard Haeser updated the commit message in patch set 6 10/25/19, 18:22

  13. Richard Haeser voted on patch set 6 V +1 CR +1 10/25/19, 18:24

  14. TYPO3com voted on patch set 6 V +1 10/25/19, 18:37 Completed build in 12m 16s on Fri, 25 Oct, 06:37 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37730

  15. Simon Gilli voted on patch set 6 V +1 CR +1 10/26/19, 02:10

  16. Oliver Hader commented on patch set 6 CR -1 10/26/19, 09:58

    Looks like `editAction` is the wrong place to trigger this... Having uncached results then seems to be a side-effect for (other) processes that are using `SiteConfiguration` (which is a state-preserving singleton object).

    SiteConfigurationController.php:155 Unresolved

    only `getRootPageId()` are used in this action from (uncached) `$allSites` - real resolving happens somewhere deep down in FormEngine's resolvers (e.g. `SiteResolving` or `SiteDatebaseEditRow`)...
  17. Oliver Hader uploaded patch set 7 10/26/19, 11:01

  18. TYPO3com voted on patch set 7 V -1 10/26/19, 11:01 Completed build in 12s on Sat, 26 Oct, 11:01 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37778

  19. Kevin Appelt uploaded patch set 8 10/26/19, 11:53

  20. TYPO3com voted on patch set 8 V +1 10/26/19, 12:05 Completed build in 12m 35s on Sat, 26 Oct, 12:05 PM Test Summary: 48067 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37787

  21. Steffen Frese voted on patch set 8 V +1 CR +1 01/16/20, 13:21

  22. Sascha Rademacher voted on patch set 8 V +1 CR +1 01/16/20, 13:37

  23. Henning Liebe voted on patch set 8 V +1 CR +1 01/17/20, 08:36

  24. Susi Moog voted on patch set 8 V +2 CR +2 01/25/20, 15:08

  25. Susi Moog merged patch set 9 01/25/20, 15:08