62090[BUGFIX] Load uncached site configuration in editAction
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Sascha Rademacher +1
- Henning Liebe +1
- Steffen Frese +1
-
Verified V +2 Done
- Susi Moog +2
- Sascha Rademacher +1
- Henning Liebe +1
- Steffen Frese +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 3141
Show 1016 earlier messages
-
Kevin Appelt uploaded patch set 1 10/24/19, 07:56
-
Simon Gilli commented on patch set 1 10/24/19, 08:05
-
Simon Gilli commented on patch set 1 10/24/19, 08:07
not for 9.5 as it's a bugfix? -
Kevin Appelt commented on patch set 1 10/24/19, 08:11
Reply
Currently checking if it needs a backport - but the backport needs to be bigger as the "useCache" parameter in SiteConfiguration->resolveAllExistingSites was added in v10 and is not available in v9. But will check it and provide a complete backport if needed. -
TYPO3com voted on patch set 1 V -1 10/24/19, 08:15 Completed build in 15m 15s on Thu, 24 Oct, 08:15 AM Test Summary: 1 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37558
-
TYPO3com commented on patch set 1 10/24/19, 08:45 Completed build in 25m 07s on Thu, 24 Oct, 08:45 AM Test Summary: 1 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37565
-
Kevin Appelt commented on patch set 1 10/24/19, 08:45
Reply
Confirmed, backport needed and provided here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62093 -
TYPO3com voted on patch set 1 V +1 10/24/19, 08:58 Completed build in 1h 12m 57s on Thu, 24 Oct, 08:58 AM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37558
-
Kevin Appelt uploaded patch set 2 10/24/19, 08:58
-
TYPO3com voted on patch set 2 V -1 10/24/19, 08:59 Completed build in 21s on Thu, 24 Oct, 08:59 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37569
-
Kevin Appelt uploaded patch set 3 10/24/19, 09:00
-
TYPO3com voted on patch set 3 V -1 10/24/19, 09:01 Completed build in 16s on Thu, 24 Oct, 09:01 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37570
-
Kevin Appelt uploaded patch set 4 10/24/19, 09:03
-
TYPO3com voted on patch set 4 V +1 10/24/19, 09:13 Completed build in 09m 46s on Thu, 24 Oct, 09:13 AM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37571
-
Kevin Appelt abandoned the change 10/24/19, 09:39
Wrong change id -
Kevin Appelt restored the change 10/24/19, 09:40
-
Kevin Appelt commented on patch set 4 10/24/19, 09:48
SiteFinder.php:73ReplyDone -
Oliver Klee commented on patch set 4 10/24/19, 09:59
SiteFinder.php:73Instead of having a boolean parameter to switch between two different sets of behavior (which is a bad code smell), I propose adding a new method getAllSitesWithoutCache (or something like this). And if it is possible, also rename the old method to getAllSitesWitchCache. -
Kevin Appelt commented on patch set 4 10/24/19, 12:03
SiteFinder.php:73ReplyAs the renaming of a public method would be breaking and I see no significant performance improvement with two methods I would stick with this change and not introduce a new method for this. -
Oliver Klee commented on patch set 4 10/24/19, 12:06
SiteFinder.php:73ReplyI think I haven't made my point sufficiently clear. It's not about performance, it's about clear communication to the reader (i.e., clean code). -
Simon Gilli commented on patch set 4 10/24/19, 12:15
Reply
You don't have to provide a backport, that's the part of the core. But you have to add the version here, change this line to `master, 9.5`, that's all... -
Simon Gilli commented on patch set 4 10/24/19, 12:16
SiteFinder.php:73ReplyAck -
Kevin Appelt commented on patch set 4 10/24/19, 12:25
Reply
The new (correct) backport is this one: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62094 As it needs further code changes that are new in v10 and therefore not available in v9 it have to be an own patch. :) -
Simon Gilli commented on patch set 4 10/24/19, 12:33
Reply
As mentioned in the core-dev-channel, a core team member is resposible for that. So please add the missing version here -
Susi Moog updated the commit message in patch set 5 10/24/19, 17:00
-
TYPO3com voted on patch set 5 V +1 10/24/19, 17:10 Completed build in 10m 17s on Thu, 24 Oct, 05:10 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37615
-
Kevin Appelt commented on patch set 5 10/25/19, 18:14
Reply
Done -
Richard Haeser updated the commit message in patch set 6 10/25/19, 18:22
-
Richard Haeser voted on patch set 6 V +1 CR +1 10/25/19, 18:24
-
TYPO3com voted on patch set 6 V +1 10/25/19, 18:37 Completed build in 12m 16s on Fri, 25 Oct, 06:37 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37730
-
Simon Gilli voted on patch set 6 V +1 CR +1 10/26/19, 02:10
-
Oliver Hader commented on patch set 6 CR -1 10/26/19, 09:58
Looks like `editAction` is the wrong place to trigger this... Having uncached results then seems to be a side-effect for (other) processes that are using `SiteConfiguration` (which is a state-preserving singleton object).SiteConfigurationController.php:155Unresolvedonly `getRootPageId()` are used in this action from (uncached) `$allSites` - real resolving happens somewhere deep down in FormEngine's resolvers (e.g. `SiteResolving` or `SiteDatebaseEditRow`)... -
Oliver Hader uploaded patch set 7 10/26/19, 11:01
-
TYPO3com voted on patch set 7 V -1 10/26/19, 11:01 Completed build in 12s on Sat, 26 Oct, 11:01 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37778
-
Kevin Appelt uploaded patch set 8 10/26/19, 11:53
-
TYPO3com voted on patch set 8 V +1 10/26/19, 12:05 Completed build in 12m 35s on Sat, 26 Oct, 12:05 PM Test Summary: 48067 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37787
-
Steffen Frese voted on patch set 8 V +1 CR +1 01/16/20, 13:21
-
Sascha Rademacher voted on patch set 8 V +1 CR +1 01/16/20, 13:37
-
Henning Liebe voted on patch set 8 V +1 CR +1 01/17/20, 08:36
-
Susi Moog voted on patch set 8 V +2 CR +2 01/25/20, 15:08
-
Susi Moog merged patch set 9 01/25/20, 15:08
SiteFinder.php:73