Review main Merged

62092[DOCS] Extend seo extension docs

Kay Strobach CR +2 V +2 Normal +101 −3 updated 10/25/19, 18:20

Commit message

Add TypoScript examples and general recommendations.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Sybille Peters +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Sybille Peters +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1217

  1. Kay Strobach uploaded patch set 1 10/24/19, 08:38

  2. Kay Strobach commented on patch set 1 10/24/19, 08:39

    please take another look on the improvements thank you
  3. TYPO3com voted on patch set 1 V -1 10/24/19, 09:01 Completed build in 17m 04s on Thu, 24 Oct, 09:01 AM Test Summary: 1 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37568

  4. Oli Bartsch commented on patch set 1 10/24/19, 09:02

    Please make the first letter of your commit message uppercase :)

    Index.rst:121

    Maybe "This" sounds better

    Index.rst:123

    because ...

    Index.rst:129

    Meta Tag API.

    Index.rst:154

    Add a ":" or "." here.

    Index.rst:15 Unresolved

    I don't know if there is a definition what "great seo" is.

    Index.rst:15 Unresolved

    various APIs

    Index.rst:19 Unresolved

    ":"
  5. Oli Bartsch updated the commit message in patch set 2 10/24/19, 09:13

  6. TYPO3com voted on patch set 2 V +1 10/24/19, 09:22 Completed build in 09m 19s on Thu, 24 Oct, 09:22 AM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37572

  7. Sybille Peters commented on patch set 2 10/24/19, 14:01

    Index.rst:76 Unresolved

    Why the double underline? You can use the recommended underlining styles: https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/WritingReST/CheatSheet.html#rest-sphinx-cheat-sheet We don't enforce this everywhere. Technically you can order underlining styles any way you want but for making it easier to edit anywhere in the docs, I think it is best to stick with the recommended style.

    Index.rst:129

    The TYPO3 > TYPO3

    Index.rst:130

    powerfull > powerful

    Index.rst:154

    an >> a

    Index.rst:178 Unresolved

    This is duplicate with "danger" note on Recommendations page. Maybe it is enought to add the link here?
  8. Daniel Siepmann uploaded patch set 3 10/25/19, 17:34

  9. Daniel Siepmann voted on patch set 3 V +1 CR +1 10/25/19, 17:34

  10. TYPO3com voted on patch set 3 V -1 10/25/19, 17:44 Completed build in 09m 35s on Fri, 25 Oct, 05:44 PM Test Summary: 37994 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37722

  11. TYPO3com voted on patch set 3 V +1 10/25/19, 17:49 Completed build in 24m 14s on Fri, 25 Oct, 05:49 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37722

  12. Richard Haeser uploaded patch set 4 10/25/19, 18:06

  13. Richard Haeser voted on patch set 4 V +1 CR +1 10/25/19, 18:06

  14. Sybille Peters commented on patch set 4 V +1 CR +1 10/25/19, 18:07

    Index.rst:121 Reply Unresolved

    Done

    Index.rst:123 Reply

    Done

    Index.rst:129 Reply

    Done

    Index.rst:129 Reply

    Done

    Index.rst:130 Reply

    Done

    Index.rst:154 Reply

    Done

    Index.rst:154 Reply

    Done
  15. TYPO3com voted on patch set 4 V +1 10/25/19, 18:16 Completed build in 10m 17s on Fri, 25 Oct, 06:16 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37728

  16. Richard Haeser voted on patch set 4 V +2 CR +2 10/25/19, 18:19

  17. Richard Haeser merged patch set 5 10/25/19, 18:20