Review main Merged

62097[TASK] Use dedicated PHPUnit assertion methods

Alexander Schnitzler CR +2 V +2 Easy +26 −24 updated 10/25/19, 08:08

Commit message

PHPUnit assertion method calls like ::assertSame(true, $foo)
should be written with dedicated method like ::assertTrue($foo).

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 69

  1. Alexander Schnitzler uploaded patch set 1 10/24/19, 13:25

  2. TYPO3com voted on patch set 1 V -1 10/24/19, 13:37 Completed build in 12m 13s on Thu, 24 Oct, 01:37 PM Test Summary: 8 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37593

  3. Alexander Schnitzler uploaded patch set 2 10/24/19, 13:48

  4. TYPO3com voted on patch set 2 V +1 10/24/19, 13:58 Completed build in 09m 43s on Thu, 24 Oct, 01:58 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37596

  5. Alexander Schnitzler uploaded patch set 3 10/24/19, 18:13

  6. TYPO3com voted on patch set 3 V +1 10/24/19, 18:23 Completed build in 10m 04s on Thu, 24 Oct, 06:23 PM Test Summary: 48016 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37620

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 10/25/19, 07:30

  8. Daniel Goerz voted on patch set 3 V +2 CR +2 10/25/19, 08:08

  9. Daniel Goerz merged patch set 4 10/25/19, 08:08