62097[TASK] Use dedicated PHPUnit assertion methods
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Andreas Kienast +1
-
Verified V +2 Done
- Daniel Goerz +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 9
- Build/.php_cs+1 −0
- typo3/sysext/core/Tests/Unit/Imaging/IconRegistryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Utility/RootlineUtilityTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+11 −11
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+5 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+2 −2
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/ExternalLinktypeTest.php+1 −1
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+1 −1
Review log 69
-
Alexander Schnitzler uploaded patch set 1 10/24/19, 13:25
-
TYPO3com voted on patch set 1 V -1 10/24/19, 13:37 Completed build in 12m 13s on Thu, 24 Oct, 01:37 PM Test Summary: 8 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37593
-
Alexander Schnitzler uploaded patch set 2 10/24/19, 13:48
-
TYPO3com voted on patch set 2 V +1 10/24/19, 13:58 Completed build in 09m 43s on Thu, 24 Oct, 01:58 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37596
-
Alexander Schnitzler uploaded patch set 3 10/24/19, 18:13
-
TYPO3com voted on patch set 3 V +1 10/24/19, 18:23 Completed build in 10m 04s on Thu, 24 Oct, 06:23 PM Test Summary: 48016 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37620
-
Andreas Kienast voted on patch set 3 V +1 CR +1 10/25/19, 07:30
-
Daniel Goerz voted on patch set 3 V +2 CR +2 10/25/19, 08:08
-
Daniel Goerz merged patch set 4 10/25/19, 08:08