Review main Merged

62098[FEATURE] Add stdWrap properties to references in FilesProcessor

Stefan Froemken CR +2 V +2 Normal +56 −9 updated 02/21/20, 10:18

Commit message

Add stdWrap properties to references like it is done
in FilesContentObject. That way it is possible to select
FileResources from rootline.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Tobi Kretschmann +1
    • Jörg Bösche +1
    • Felix P. +1
  • Verified V +2 Done
    • Susi Moog +2
    • Tobi Kretschmann +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1722

  1. Stefan Froemken uploaded patch set 1 10/24/19, 14:14

  2. Mathias Brodala commented on patch set 1 V -1 10/24/19, 14:17

    Unresolved

    Features can only go into master. Also you must add a feature RST.
  3. TYPO3com voted on patch set 1 V -1 10/24/19, 14:24 Completed build in 10m 23s on Thu, 24 Oct, 02:24 PM Test Summary: 47784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37601

  4. Stefan Froemken uploaded patch set 2 10/24/19, 16:22

  5. Stefan Froemken commented on patch set 2 10/24/19, 16:24

    As this is already possible in FilesContentObject and is missing in FilesProcessor since years I don't know if this is realy a Feature or more a Bugfix. What do you think?
  6. TYPO3com voted on patch set 2 V +1 10/24/19, 16:32 Completed build in 10m 03s on Thu, 24 Oct, 04:32 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37613

  7. Jo Hasenau commented on patch set 2 CR -1 10/25/19, 13:23

    I would agree that this is bugfix. Still we should postpone this until #88627 has been merged or we should just include it with the patch of #88627 and abandon this patch.
  8. Georg Ringer commented on patch set 2 CR -1 11/01/19, 19:22

    it is a feature. if somebody wanted that, he can just use a custom dataprocessor anyway. please remove the 9.5 from commit msg
  9. Stefan Froemken uploaded patch set 3 11/04/19, 10:35

  10. TYPO3com voted on patch set 3 V +1 11/04/19, 10:52 Completed build in 12m 58s on Mon, 4 Nov, 10:52 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37965

  11. Wolfgang Klinger updated the commit message in patch set 4 11/05/19, 12:04

  12. TYPO3com voted on patch set 4 V -1 11/05/19, 12:14 Completed build in 10m 16s on Tue, 5 Nov, 12:14 PM Test Summary: 2 of 48482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38002

  13. Jörg Bösche uploaded patch set 5 01/15/20, 08:58

  14. TYPO3com voted on patch set 5 V +1 01/15/20, 09:10 Completed build in 11m 49s on Wed, 15 Jan, 09:10 AM Test Summary: 69524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39953

  15. Jörg Bösche voted on patch set 5 V +1 CR +1 01/16/20, 09:13

  16. Tobi Kretschmann voted on patch set 5 V +1 CR +1 01/16/20, 10:16

  17. Felix P. voted on patch set 5 CR +1 01/16/20, 10:45

  18. Benni Mack commented on patch set 5 01/16/20, 15:21

    Why would we stdWrap "references." itself? There is nothing we could do with that as far as I read the RST.
  19. Jo Hasenau commented on patch set 5 01/16/20, 15:51

    > Patch Set 5: > > Why would we stdWrap "references." itself? There is nothing we could do with that as far as I read the RST. Because this will add the 'data' property shown in the example as well as some other options to get the referenced IDs from, including 'field', 'cObject' and 'current'
  20. Susi Moog voted on patch set 5 V +2 CR +2 02/21/20, 08:19

  21. Susi Moog merged patch set 6 02/21/20, 08:19

  22. Tymoteusz Motylewski commented on patch set 6 02/21/20, 10:18

    Wpuld be nice to also update tsref.xml so the new property is suggested in phpstorm and backend