Review main Abandoned

62099[TASK] Use dedicated PHPUnit assert methods

Alexander Schnitzler CR 0 V 0 Normal +114 −113 updated 10/29/19, 11:01

Commit message

PHPUnit assertions like assertInternalType, assertFileExists etc.
should be used over assertTrue.

Review

  • Code review CR 0
  • Verified V 0

Files 41

Show 21 more files

Review log 34

  1. Alexander Schnitzler uploaded patch set 1 10/24/19, 14:15

  2. TYPO3com voted on patch set 1 V -1 10/24/19, 14:28 Completed build in 11m 49s on Thu, 24 Oct, 02:28 PM Test Summary: 16 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37602

  3. Alexander Schnitzler commented on patch set 1 CR -2 10/24/19, 14:42

    > Patch Set 1: Verified-1 > > Completed build in 11m 49s on Thu, 24 Oct, 02:28 PM > Test Summary: 16 of 48376 failed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37602 This, unfortunately, does not work properly because php-cs-fixer replaces methods like self::assertFalse(is_resource($handle)) with self::assertNotInternalType('resource', $handle) but assertNotInternalType itself is already deprecated.
  4. Alexander Schnitzler abandoned the change 10/29/19, 11:01

    Not working at the moment.