62099[TASK] Use dedicated PHPUnit assert methods
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 41
- Build/.php_cs+1 −0
- typo3/sysext/core/Tests/Functional/IO/PharStreamWrapperInterceptorTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Session/Backend/DatabaseSessionBackendTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Session/Backend/RedisSessionBackendTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Argon2iPasswordHashTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/BcryptPasswordHashTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/MessageTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/StreamTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Http/UploadedFileTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Locking/FileLockStrategyTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Locking/SimpleLockStrategyTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+10 −10
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+14 −14
- typo3/sysext/core/Tests/Unit/Utility/MailUtilityTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryParserTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+3 −3
Show 21 more files
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/SessionTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Security/Cryptography/HashServiceTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Utility/ExtensionUtilityTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AlphanumericValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/ConjunctionValidatorTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/EmailAddressValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/FloatValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/IntegerValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NotEmptyValidatorTest.php+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/DownloadQueueTest.php+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Report/ExtensionStatusTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+12 −12
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractFormElementTest.php+7 −7
- typo3/sysext/form/Tests/Unit/Domain/FormElements/SectionTest.php+7 −7
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+3 −3
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php+5 −5
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+1 −1
- typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php+7 −7
Review log 34
-
Alexander Schnitzler uploaded patch set 1 10/24/19, 14:15
-
TYPO3com voted on patch set 1 V -1 10/24/19, 14:28 Completed build in 11m 49s on Thu, 24 Oct, 02:28 PM Test Summary: 16 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37602
-
Alexander Schnitzler commented on patch set 1 CR -2 10/24/19, 14:42
> Patch Set 1: Verified-1 > > Completed build in 11m 49s on Thu, 24 Oct, 02:28 PM > Test Summary: 16 of 48376 failed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37602 This, unfortunately, does not work properly because php-cs-fixer replaces methods like self::assertFalse(is_resource($handle)) with self::assertNotInternalType('resource', $handle) but assertNotInternalType itself is already deprecated. -
Alexander Schnitzler abandoned the change 10/29/19, 11:01
Not working at the moment.