Review main Merged

62100[TASK] Use short returns in PHPUnit tests

Alexander Schnitzler CR +2 V +2 Nightmare +1349 −1350 updated 10/24/19, 17:26

Commit message

Usage of PHPUnit’s mock e.g. ->will($this->returnValue(..)) must be
replaced by its shorter equivalent such as ->willReturn(...).

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • TYPO3com +1 CI

Issues 1

Files 148

Show 128 more files

Review log 58

  1. Alexander Schnitzler uploaded patch set 1 10/24/19, 14:55

  2. TYPO3com voted on patch set 1 V -1 10/24/19, 15:07 Completed build in 12m 29s on Thu, 24 Oct, 03:07 PM Test Summary: 1 of 47872 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37604

  3. TYPO3com voted on patch set 1 V +1 10/24/19, 15:18 Completed build in 36m 06s on Thu, 24 Oct, 03:18 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37604

  4. Alexander Schnitzler updated the commit message in patch set 2 10/24/19, 15:19

  5. TYPO3com voted on patch set 2 V +1 10/24/19, 15:28 Completed build in 09m 03s on Thu, 24 Oct, 03:28 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37609

  6. Oliver Klee voted on patch set 2 V +1 CR +1 10/24/19, 16:13

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 10/24/19, 17:26

  8. Daniel Goerz merged patch set 3 10/24/19, 17:26