62100[TASK] Use short returns in PHPUnit tests
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
-
Verified V +2 Done
- Daniel Goerz +2
- Oliver Klee +1
- TYPO3com +1 CI
Issues 1
Files 148
- Build/.php_cs+1 −0
- typo3/sysext/backend/Tests/Unit/Controller/File/FileControllerTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Form/NodeFactoryTest.php+17 −17
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/BackendLayoutCollectionTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/DataProviderCollectionTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/View/BackendLayoutViewTest.php+2 −2
- typo3/sysext/belog/Tests/Unit/Domain/Repository/LogEntryRepositoryTest.php+1 −1
- typo3/sysext/belog/Tests/Unit/Domain/Repository/WorkspaceRepositoryTest.php+1 −1
- typo3/sysext/beuser/Tests/Unit/Service/ModuleDataStorageServiceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+17 −17
- typo3/sysext/core/Tests/Unit/Cache/Backend/ApcuBackendTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php+30 −30
- typo3/sysext/core/Tests/Unit/Cache/Backend/PdoBackendTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Cache/Backend/WincacheBackendTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Cache/Frontend/PhpFrontendTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Cache/Frontend/VariableFrontendTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Cache/CacheManagerTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Command/SendEmailCommandTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+20 −20
Show 128 more files
- typo3/sysext/core/Tests/Unit/Database/Query/BulkInsertTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php+10 −10
- typo3/sysext/core/Tests/Unit/Database/RelationHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Domain/Repository/PageRepositoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Error/ProductionExceptionHandlerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/FormProtection/AbstractFormProtectionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Imaging/IconFactoryTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Log/Processor/IntrospectionProcessorTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Log/LoggerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Resource/Index/ExtractorRegistryTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Resource/OnlineMedia/Helpers/VimeoHelperTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Processing/LocalPreviewHelperTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php+7 −7
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/PlainTextExtractorTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/TextExtractorRegistryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/AbstractFileTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/BaseTestCase.php+4 −4
- typo3/sysext/core/Tests/Unit/Resource/FileReferenceTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Resource/FolderTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Resource/MetaDataAspectTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+39 −39
- typo3/sysext/core/Tests/Unit/Service/FlexFormServiceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/DatabaseTreeDataProviderTest.php+4 −4
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Utility/File/ExtendedFileUtilityTest.php+7 −7
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+26 −26
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Configuration/AbstractConfigurationManagerTest.php+46 −46
- typo3/sysext/extbase/Tests/Unit/Configuration/BackendConfigurationManagerTest.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+15 −15
- typo3/sysext/extbase/Tests/Unit/Domain/Repository/BackendUserGroupRepositoryTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Domain/Repository/BackendUserRepositoryTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Domain/Repository/CategoryRepositoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Domain/Repository/FileMountRepositoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/AbstractControllerTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentsTest.php+25 −25
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+35 −35
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/RequestBuilderTest.php+22 −22
- typo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Object/Container/ContainerTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+13 −13
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+17 −17
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+18 −18
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/BackendTest.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+9 −9
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/SessionTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php+35 −35
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/DateTimeConverterTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/ObjectConverterTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/PersistentObjectConverterTest.php+23 −23
- typo3/sysext/extbase/Tests/Unit/Property/PropertyMapperTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+16 −16
- typo3/sysext/extbase/Tests/Unit/SignalSlot/DispatcherTest.php+10 −10
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/CollectionValidatorTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/ConjunctionValidatorTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DisjunctionValidatorTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+5 −5
- typo3/sysext/extensionmanager/Tests/Unit/Controller/DownloadControllerTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Controller/UploadExtensionFileControllerTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Repository/RepositoryRepositoryTest.php+4 −4
- typo3/sysext/extensionmanager/Tests/Unit/Report/ExtensionStatusTest.php+45 −45
- typo3/sysext/extensionmanager/Tests/Unit/Service/ExtensionManagementServiceTest.php+20 −20
- typo3/sysext/extensionmanager/Tests/Unit/Task/UpdateExtensionListTaskTest.php+4 −4
- typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php+43 −43
- typo3/sysext/extensionmanager/Tests/Unit/Utility/ExtensionModelUtilityTest.php+3 −3
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+8 −8
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+4 −4
- typo3/sysext/extensionmanager/Tests/Unit/Utility/ListUtilityTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/Core/Widget/AbstractWidgetControllerTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/Core/Widget/AbstractWidgetViewHelperTest.php+12 −12
- typo3/sysext/fluid/Tests/Unit/Core/Widget/WidgetRequestBuilderTest.php+10 −10
- typo3/sysext/fluid/Tests/Unit/Core/Widget/WidgetRequestTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/View/AbstractTemplateViewTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/Select/OptionViewHelperTest.php+8 −8
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormFieldViewHelperTest.php+16 −16
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/HiddenViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SelectViewHelperTest.php+7 −7
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/CropViewHelperTest.php+4 −4
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/EmailViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/ExternalViewHelperTest.php+4 −4
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/PageViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/TypolinkViewHelperTest.php+4 −4
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Widget/Controller/PaginateControllerTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FlashMessagesViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php+11 −11
- typo3/sysext/form/Tests/Unit/Controller/FormManagerControllerTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/TypoScriptServiceTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+3 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+10 −10
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+21 −21
- typo3/sysext/frontend/Tests/Unit/ContentObject/FilesContentObjectTest.php+28 −28
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+8 −8
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Processor/GalleryProcessorTest.php+2 −2
- typo3/sysext/install/Tests/Unit/FolderStructure/AbstractNodeTest.php+22 −22
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+78 −78
- typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php+100 −100
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php+42 −42
- typo3/sysext/install/Tests/Unit/FolderStructure/RootNodeTest.php+18 −18
- typo3/sysext/install/Tests/Unit/FolderStructure/StructureFacadeTest.php+2 −2
- typo3/sysext/install/Tests/Unit/Service/CoreVersionServiceTest.php+10 −10
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+16 −16
- typo3/sysext/recycler/Tests/Unit/Task/CleanerFieldProviderTest.php+2 −2
- typo3/sysext/scheduler/Tests/Unit/Task/CachingFrameworkGarbageCollectionTest.php+2 −2
- typo3/sysext/seo/Tests/Unit/XmlSitemap/PagesXmlSitemapDataProviderTest.php+4 −6
Review log 58
-
Alexander Schnitzler uploaded patch set 1 10/24/19, 14:55
-
TYPO3com voted on patch set 1 V -1 10/24/19, 15:07 Completed build in 12m 29s on Thu, 24 Oct, 03:07 PM Test Summary: 1 of 47872 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37604
-
TYPO3com voted on patch set 1 V +1 10/24/19, 15:18 Completed build in 36m 06s on Thu, 24 Oct, 03:18 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37604
-
Alexander Schnitzler updated the commit message in patch set 2 10/24/19, 15:19
-
TYPO3com voted on patch set 2 V +1 10/24/19, 15:28 Completed build in 09m 03s on Thu, 24 Oct, 03:28 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37609
-
Oliver Klee voted on patch set 2 V +1 CR +1 10/24/19, 16:13
-
Daniel Goerz voted on patch set 2 V +2 CR +2 10/24/19, 17:26
-
Daniel Goerz merged patch set 3 10/24/19, 17:26