Review main Merged

62102[TASK] Move field "description" to SEO tab in page properties

Kevin Appelt CR +2 V +2 Easy +8 −1 updated 11/10/19, 09:02

Commit message

The description field is one of the most important fields
for SEO. When EXT:seo is installed, the description field can
be found on the SEO tab of the page properties. If EXT:seo
is not installed, the field will still be on the Metadata tab.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • Kevin Appelt +1
  • Verified V +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • Kevin Appelt +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 3952

Show 1927 earlier messages
  1. Kevin Appelt uploaded patch set 1 10/24/19, 16:27

  2. TYPO3com voted on patch set 1 V -1 10/24/19, 16:37 Completed build in 09m 41s on Thu, 24 Oct, 04:37 PM Test Summary: 12 of 48376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37614

  3. Kevin Appelt uploaded patch set 2 10/24/19, 17:13

  4. TYPO3com voted on patch set 2 V -1 10/24/19, 17:18 Completed build in 05m 11s on Thu, 24 Oct, 05:18 PM Test Summary: 40509 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37616

  5. TYPO3com commented on patch set 2 10/24/19, 17:34 Completed build in 08m 21s on Thu, 24 Oct, 05:34 PM Test Summary: 40509 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37617

  6. Alexander Schnitzler uploaded patch set 3 10/24/19, 18:20

  7. TYPO3com voted on patch set 3 V -1 10/24/19, 18:29 Completed build in 08m 50s on Thu, 24 Oct, 06:29 PM Test Summary: 12 of 48424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37621

  8. Oli Bartsch commented on patch set 3 10/25/19, 05:42

    SeoFieldsMovementUpdate.php:95

    Could we either make the description more meaningful or remove it completely as function name is already self-explaining?
  9. Mathias Brodala commented on patch set 3 V -1 10/25/19, 06:42

    Notice that this is technically a breaking change which is not allowed until v11.0. So I'd recommend to keep the field as is but append a "(deprecated)" to its label. Then EXT:seo can override this label with the regular one. In any case matching RST should be added.
  10. Kevin Appelt uploaded patch set 4 10/25/19, 07:23

  11. Frank Nägler commented on patch set 4 10/25/19, 07:30

    > Notice that this is technically a breaking change which is not allowed until v11.0. Why this patch should be breaking? The field exists, an upgrade wizard can install EXT:seo if required. Also a check for pages which use the fields are part of upgrade wizard. > In any case matching RST should be added. Agree, an important RST would be good.
  12. TYPO3com voted on patch set 4 V +1 10/25/19, 07:34 Completed build in 10m 41s on Fri, 25 Oct, 07:34 AM Test Summary: 48065 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37629

  13. Kevin Appelt uploaded patch set 5 10/25/19, 07:39

  14. Kevin Appelt commented on patch set 5 10/25/19, 07:40

    SeoFieldsMovementUpdate.php:95 Reply

    I've adjusted the description to be much more meaningful.
  15. TYPO3com voted on patch set 5 V +1 10/25/19, 07:48 Completed build in 09m 09s on Fri, 25 Oct, 07:48 AM Test Summary: 48065 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37630

  16. Richard Haeser commented on patch set 5 10/25/19, 07:59

    There is also a non-breaking change possible. Remove the description field from the default pages TCA configuration and add the field to palette metatags when EXT:seo is not installed in the override. If EXT:seo is installed, add the field to the seo palette of EXT:SEO
  17. Richard Haeser commented on patch set 5 10/25/19, 08:00

    > Patch Set 5: > > There is also a non-breaking change possible. Remove the description field from the default pages TCA configuration and add the field to palette metatags when EXT:seo is not installed in the override. > > If EXT:seo is installed, add the field to the seo palette of EXT:SEO We don't need upgrade wizards in that case. Only thing; if you install EXT:seo the field is on another tab than without EXT:seo installed and might be confusing for users.
  18. Benni Mack commented on patch set 5 10/25/19, 08:19

    > Patch Set 3: Verified-1 > > Notice that this is technically a breaking change which is not allowed until v11.0. > > So I'd recommend to keep the field as is but append a "(deprecated)" to its label. Then EXT:seo can override this label with the regular one. > > In any case matching RST should be added. Can you elaborate how this is breaking technically? Mostly, I'd say it's breaking as the DB field is not added via EXT:core anymore (which we could leave in there until v11.0).

    SeoFieldsMovementUpdate.php:2

    strict type?

    PagesLanguageOverlayVisibleFieldsTest.php:2

    strict typing?

    PagesVisibleFieldsTest.php:2

    strict typing?
  19. Alexander Schnitzler commented on patch set 5 10/25/19, 08:37

    SeoFieldsMovementUpdate.php:24

    No need to mark this @internal if you make it final.

    pages.php:62

    Shouldn't that label go into the SEO extension?

    pages.php:301

    Don't know the convention here but I'd usually not just add list items via string operations but explode the array, add the item and implode it again.

    pages.php:302

    dito

    PagesLanguageOverlayVisibleFieldsTest.php:27

    If you only need to load extensions it the setup you can simply override the property and save the setUp method.
  20. Richard Haeser commented on patch set 5 10/25/19, 08:48

    pages.php:61

    Is there a reason why you created a new palette in stead of adding it to seo palette?
  21. Mathias Brodala commented on patch set 5 10/25/19, 12:05

    > Patch Set 5: > > (3 comments) > > > Patch Set 3: Verified-1 > > > > Notice that this is technically a breaking change which is not allowed until v11.0. > > > > So I'd recommend to keep the field as is but append a "(deprecated)" to its label. Then EXT:seo can override this label with the regular one. > > > > In any case matching RST should be added. > > Can you elaborate how this is breaking technically? Mostly, I'd say it's breaking as the DB field is not added via EXT:core anymore (which we could leave in there until v11.0). Because the TCA definition is also gone with this change. This affects BE display and Extbase.
  22. Kevin Appelt uploaded patch set 6 10/25/19, 12:50

  23. Mathias Brodala commented on patch set 6 V -1 10/25/19, 13:03

    I'm still convinced that this is a breaking change. Please make the adjustments I suggested or tell me if I missed something.
  24. TYPO3com voted on patch set 6 V +1 10/25/19, 13:04 Completed build in 13m 00s on Fri, 25 Oct, 01:04 PM Test Summary: 48067 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37672

  25. Kevin Appelt uploaded patch set 7 10/25/19, 15:01

  26. Kevin Appelt commented on patch set 7 10/25/19, 15:04

    SeoFieldsMovementUpdate.php:2 Reply

    Done

    SeoFieldsMovementUpdate.php:24 Reply

    Done

    pages.php:61 Reply

    I've moved it to the seo palette.

    pages.php:62 Reply

    I've moved the field to another palette, so this label is gone.

    pages.php:301 Reply

    Done

    pages.php:302 Reply

    Done

    PagesLanguageOverlayVisibleFieldsTest.php:2 Reply

    Done

    PagesLanguageOverlayVisibleFieldsTest.php:27 Reply

    Done

    PagesVisibleFieldsTest.php:2 Reply

    Done
  27. TYPO3com voted on patch set 7 V +1 10/25/19, 15:25 Completed build in 14m 25s on Fri, 25 Oct, 03:25 PM Test Summary: 48066 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37697

  1. Kevin Appelt uploaded patch set 8 10/25/19, 17:28

  2. TYPO3com voted on patch set 8 V -1 10/25/19, 17:39 Completed build in 11m 36s on Fri, 25 Oct, 05:39 PM Test Summary: 47861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37721

  3. TYPO3com voted on patch set 8 V +1 10/25/19, 17:42 Completed build in 25m 44s on Fri, 25 Oct, 05:42 PM Test Summary: 48107 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37721

  4. Richard Haeser commented on patch set 8 CR +1 10/25/19, 17:50

    Couldn't verify install of the extension SEO because of error in upgrade wizard. See https://forge.typo3.org/issues/89504
  5. Richard Haeser commented on patch set 8 V +1 10/25/19, 17:54

    When you install EXT:seo by the Extension Manager, it all works fine. As the other bug is not due to this patch, I will verify this patch.
  6. Simon Gilli commented on patch set 8 10/26/19, 02:24

    Important-86516-MoveDescriptionFieldToSEOTab.rst:12

  7. Kevin Appelt uploaded patch set 9 10/26/19, 07:04

  8. Kevin Appelt commented on patch set 9 10/26/19, 07:05

    Important-86516-MoveDescriptionFieldToSEOTab.rst:12 Reply

    Done
  9. TYPO3com voted on patch set 9 V +1 10/26/19, 07:14 Completed build in 09m 31s on Sat, 26 Oct, 07:14 AM Test Summary: 48107 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37756

  10. Richard Haeser voted on patch set 9 V +1 CR +1 10/26/19, 08:13

  11. Benni Mack commented on patch set 9 11/09/19, 12:16

    Why move the field to the EXT:seo extension (make it potentially breaking) instead of just re-ordering everything in the tab? And: If we move the field, why description and not "keywords"?
  12. Richard Haeser commented on patch set 9 V 0 CR 0 11/09/19, 18:55

    > Patch Set 9: > > Why move the field to the EXT:seo extension (make it potentially breaking) instead of just re-ordering everything in the tab? > > And: If we move the field, why description and not "keywords"? The description field is now on the metadata tab. As the description is one of the most important fields for SEO, you want to move that to the SEO tab. Only problem is that the SEO tab is added bij EXT:seo. As said before, we can make this a non-breaking change and I personally prefer that way. In that case the description field is on the metadata tab by default. If you have installed the EXT:seo, the field is moved towards the SEO tab. I guess I don't have to explain that the keywords field has nothing to do with SEO for a couple of years ;-) Personally I would love to get rid of that field as it is still confusing people. So my 2 cents on this: make it less breaking by just alter TCA config. No upgrade wizards needed etc.
  13. Susi Moog commented on patch set 9 11/09/19, 18:57

    > Patch Set 9: -Verified -Code-Review > > > Patch Set 9: > > > > Why move the field to the EXT:seo extension (make it potentially breaking) instead of just re-ordering everything in the tab? > > > > And: If we move the field, why description and not "keywords"? > > The description field is now on the metadata tab. As the description is one of the most important fields for SEO, you want to move that to the SEO tab. Only problem is that the SEO tab is added bij EXT:seo. As said before, we can make this a non-breaking change and I personally prefer that way. In that case the description field is on the metadata tab by default. If you have installed the EXT:seo, the field is moved towards the SEO tab. > > I guess I don't have to explain that the keywords field has nothing to do with SEO for a couple of years ;-) Personally I would love to get rid of that field as it is still confusing people. > > So my 2 cents on this: make it less breaking by just alter TCA config. No upgrade wizards needed etc. I agree.
  14. Richard Haeser commented on patch set 9 11/09/19, 18:57

    > Patch Set 9: -Verified -Code-Review > > > Patch Set 9: > > > > Why move the field to the EXT:seo extension (make it potentially breaking) instead of just re-ordering everything in the tab? > > > > And: If we move the field, why description and not "keywords"? > > The description field is now on the metadata tab. As the description is one of the most important fields for SEO, you want to move that to the SEO tab. Only problem is that the SEO tab is added bij EXT:seo. As said before, we can make this a non-breaking change and I personally prefer that way. In that case the description field is on the metadata tab by default. If you have installed the EXT:seo, the field is moved towards the SEO tab. > > I guess I don't have to explain that the keywords field has nothing to do with SEO for a couple of years ;-) Personally I would love to get rid of that field as it is still confusing people. > > So my 2 cents on this: make it less breaking by just alter TCA config. No upgrade wizards needed etc. See my comments on patch set 5
  15. Susi Moog commented on patch set 9 11/09/19, 18:59

    > Patch Set 9: > > > Patch Set 9: -Verified -Code-Review > > > > > Patch Set 9: > > > > > > Why move the field to the EXT:seo extension (make it potentially breaking) instead of just re-ordering everything in the tab? > > > > > > And: If we move the field, why description and not "keywords"? > > > > The description field is now on the metadata tab. As the description is one of the most important fields for SEO, you want to move that to the SEO tab. Only problem is that the SEO tab is added bij EXT:seo. As said before, we can make this a non-breaking change and I personally prefer that way. In that case the description field is on the metadata tab by default. If you have installed the EXT:seo, the field is moved towards the SEO tab. > > > > I guess I don't have to explain that the keywords field has nothing to do with SEO for a couple of years ;-) Personally I would love to get rid of that field as it is still confusing people. > > > > So my 2 cents on this: make it less breaking by just alter TCA config. No upgrade wizards needed etc. > > I agree. and: the keywords field has no purpose whatsoever anymore as far as I can see - or does anybody use the field for something useful?
  16. Richard Haeser commented on patch set 9 11/09/19, 19:03

    > Patch Set 9: > > > Patch Set 9: > > > > > Patch Set 9: -Verified -Code-Review > > > > > > > Patch Set 9: > > > > > > > > Why move the field to the EXT:seo extension (make it potentially breaking) instead of just re-ordering everything in the tab? > > > > > > > > And: If we move the field, why description and not "keywords"? > > > > > > The description field is now on the metadata tab. As the description is one of the most important fields for SEO, you want to move that to the SEO tab. Only problem is that the SEO tab is added bij EXT:seo. As said before, we can make this a non-breaking change and I personally prefer that way. In that case the description field is on the metadata tab by default. If you have installed the EXT:seo, the field is moved towards the SEO tab. > > > > > > I guess I don't have to explain that the keywords field has nothing to do with SEO for a couple of years ;-) Personally I would love to get rid of that field as it is still confusing people. > > > > > > So my 2 cents on this: make it less breaking by just alter TCA config. No upgrade wizards needed etc. > > > > I agree. > > and: the keywords field has no purpose whatsoever anymore as far as I can see - or does anybody use the field for something useful? As said: I would love to remove this field but the menu content element related content, is based on this field. So that will be quite a breaking change ;-)
  17. Richard Haeser commented on patch set 9 11/09/19, 19:03

    > Patch Set 9: > > > Patch Set 9: -Verified -Code-Review > > > > > Patch Set 9: > > > > > > Why move the field to the EXT:seo extension (make it potentially breaking) instead of just re-ordering everything in the tab? > > > > > > And: If we move the field, why description and not "keywords"? > > > > The description field is now on the metadata tab. As the description is one of the most important fields for SEO, you want to move that to the SEO tab. Only problem is that the SEO tab is added bij EXT:seo. As said before, we can make this a non-breaking change and I personally prefer that way. In that case the description field is on the metadata tab by default. If you have installed the EXT:seo, the field is moved towards the SEO tab. > > > > I guess I don't have to explain that the keywords field has nothing to do with SEO for a couple of years ;-) Personally I would love to get rid of that field as it is still confusing people. > > > > So my 2 cents on this: make it less breaking by just alter TCA config. No upgrade wizards needed etc. > > I agree. Will create a new patch for this.
  18. Richard Haeser uploaded patch set 10 11/09/19, 19:58

  19. TYPO3com voted on patch set 10 V -1 11/09/19, 20:06 Completed build in 07m 36s on Sat, 9 Nov, 08:06 PM Test Summary: 47809 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38230

  20. TYPO3com voted on patch set 10 V +1 11/09/19, 20:11 Completed build in 19m 45s on Sat, 9 Nov, 08:11 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38230

  21. Kevin Appelt voted on patch set 10 V +1 CR +1 11/09/19, 21:29

  22. Oli Bartsch voted on patch set 10 CR +1 11/09/19, 21:48

  23. Oli Bartsch voted on patch set 10 V +1 11/10/19, 07:06

  24. Susi Moog voted on patch set 10 V +2 CR +2 11/10/19, 08:19

  25. Richard Haeser merged patch set 11 11/10/19, 09:02