Review main Merged

62107[BUGFIX] Fix incompatible dataProvider comment with method name

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 10/25/19, 15:24

Commit message

With #89290 comment spelling issues were fixed, but due to a
missing adjustment of the corresponding dataProvider method name,
the tests concerning this dataProvider were no longer executed.

By fixing the spelling mistake in the dataProvider method name,
the tests are properly executed again.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Markus Klein +1
    • Andreas Kienast +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • Andreas Kienast +1
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 89

  1. Anja Leichsenring uploaded patch set 1 10/25/19, 09:55

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 10/25/19, 09:57

  3. Daniel Goerz voted on patch set 1 CR +1 10/25/19, 10:00

  4. TYPO3com voted on patch set 1 V +1 10/25/19, 10:15 Completed build in 18m 59s on Fri, 25 Oct, 10:15 AM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37656

  5. Markus Klein voted on patch set 1 V +1 CR +1 10/25/19, 10:32

  6. Michael Telgkamp voted on patch set 1 V +1 CR +1 10/25/19, 10:32

  7. Oliver Klee voted on patch set 1 CR +1 10/25/19, 11:00

  8. Daniel Goerz voted on patch set 1 V +2 CR +2 10/25/19, 15:24

  9. Daniel Goerz merged patch set 2 10/25/19, 15:24