Review main Merged

62108[FEATURE] Add DataProcessor to resolve FlexForm data

Jo Hasenau CR +2 V +2 Hard +470 −0 updated 01/13/21, 08:09

Commit message

This adds a new data processor which converts the
XML structure of a given FlexForm field into a PHP
array to be used in Fluid templates.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jo Hasenau +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jo Hasenau +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 5478

Show 3553 earlier messages
  1. Jo Hasenau uploaded patch set 1 10/25/19, 09:58

  2. TYPO3com voted on patch set 1 V +1 10/25/19, 10:20 Completed build in 16m 14s on Fri, 25 Oct, 10:20 AM Test Summary: 48019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37657

  3. Oliver Klee commented on patch set 1 10/25/19, 11:00

    Can we cover this with tests, please?
  4. Andreas Kienast commented on patch set 1 CR -1 10/25/19, 12:34

    Since this is a feature, can you please provide a ReST file?
  5. Jo Hasenau uploaded patch set 2 10/25/19, 12:52

  6. Jo Hasenau commented on patch set 1 10/25/19, 12:53

    > Patch Set 1: Code-Review-1 > > Since this is a feature, can you please provide a ReST file? Done
  7. TYPO3com voted on patch set 2 V -1 10/25/19, 13:06 Completed build in 13m 12s on Fri, 25 Oct, 01:06 PM Test Summary: 1 of 48378 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37673

  8. Jo Hasenau commented on patch set 2 10/25/19, 13:39

    > Patch Set 1: > > Can we cover this with tests, please? Please go ahead :-)
  9. Oliver Klee commented on patch set 2 10/25/19, 14:01

    > Patch Set 2: > > > Patch Set 1: > > > > Can we cover this with tests, please? > > Please go ahead :-) Um, I have no idea how the code should behave. Usually, it's the responsibility of the person writing the code to also provide tests for it.
  10. Jo Hasenau commented on patch set 2 10/25/19, 14:09

    > Patch Set 2: > > > Patch Set 2: > > > > > Patch Set 1: > > > > > > Can we cover this with tests, please? > > > > Please go ahead :-) > > Um, I have no idea how the code should behave. Usually, it's the responsibility of the person writing the code to also provide tests for it. Since you wrote "we" I thought there could be more people involved ;-) Anyway: We have a lot of data processors already in the core and just two covered with some tests. So it does not seem to be a requirement to have tests for everything. Since I am not a big fan of test driven development and therefore not familiar with writing tests, maybe someone could take over that task, while I will take care of other data processors we are going to provide for the content rendering group of the structured content initiative.
  11. Oliver Klee commented on patch set 2 10/25/19, 14:19

    > Anyway: We have a lot of data processors already in the core and just two covered with some tests. So it does not seem to be a requirement to have tests for everything. That is because the core started out with zero tests, and tests got added over time. In general, if it's okay for the code to break or to be removed, it does not need tests. Otherwise, if the code is required to work correctly (even if people change it), it needs tests.
  12. Jo Hasenau uploaded patch set 3 10/25/19, 14:30

  13. TYPO3com voted on patch set 3 V +1 10/25/19, 15:16 Completed build in 34m 30s on Fri, 25 Oct, 03:16 PM Test Summary: 48019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37691

  14. Daniel Siepmann rebased onto patch set 4 10/26/19, 11:01

  15. TYPO3com voted on patch set 4 V -1 10/26/19, 11:13 Completed build in 11m 47s on Sat, 26 Oct, 11:13 AM Test Summary: 1 of 48426 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37780

  16. Georg Ringer commented on patch set 4 CR -1 10/26/19, 11:16

    FlexFormProcessor.php:81

    there is a fallback parameter in stdWrapValue, so the if condition is not needed

    FlexFormProcessor.php:120

    not needed
  17. Jörg Bösche uploaded patch set 5 01/14/20, 14:43

  18. TYPO3com voted on patch set 5 V -1 01/14/20, 14:44 Completed build in 22s on Tue, 14 Jan, 02:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39908

  19. Jörg Bösche uploaded patch set 6 01/14/20, 14:46

  20. TYPO3com voted on patch set 6 V -1 01/14/20, 14:49 Completed build in 29s on Tue, 14 Jan, 02:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39910

  21. Jörg Bösche uploaded patch set 7 01/14/20, 14:50

  22. TYPO3com voted on patch set 7 V +1 01/14/20, 15:04 Completed build in 11m 08s on Tue, 14 Jan, 03:04 PM Test Summary: 69614 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39912

  23. Daniel Siepmann uploaded patch set 8 01/15/20, 07:57

  24. TYPO3com voted on patch set 8 V -1 01/15/20, 08:06 Completed build in 08m 42s on Wed, 15 Jan, 08:06 AM Test Summary: 69559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39951

  25. TYPO3com voted on patch set 8 V +1 01/15/20, 08:14 Completed build in 07m 23s on Wed, 15 Jan, 08:14 AM Test Summary: 69560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39952

  26. Jörg Bösche voted on patch set 8 V +1 CR +1 01/15/20, 14:59

  27. Georg Ringer commented on patch set 8 CR -1 01/15/20, 19:14

    Feature-89509-DataProcessorToResolveFlexFormData.rst:49

    one ` is enough, also below

    FlexFormProcessor.php:57

    remove comment, also below as those don't improve anything
  28. Daniel Siepmann rebased onto patch set 9 01/15/20, 19:55

  29. TYPO3com voted on patch set 9 V +1 01/15/20, 20:07 Completed build in 11m 14s on Wed, 15 Jan, 08:07 PM Test Summary: 70373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39995

  30. Jörg Bösche uploaded patch set 10 01/16/20, 08:01

  31. Jörg Bösche commented on patch set 10 01/16/20, 08:02

    Feature-89509-DataProcessorToResolveFlexFormData.rst:49 Reply

    Done

    FlexFormProcessor.php:57 Reply

    Done

    FlexFormProcessor.php:81 Reply

    Done

    FlexFormProcessor.php:120 Reply

    Done
  32. TYPO3com voted on patch set 10 V -1 01/16/20, 08:12 Completed build in 10m 21s on Thu, 16 Jan, 08:12 AM Test Summary: 70108 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40004

  33. TYPO3com commented on patch set 10 01/16/20, 08:31 Completed build in 09m 05s on Thu, 16 Jan, 08:30 AM Test Summary: 69796 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40005

  34. TYPO3com commented on patch set 10 01/16/20, 08:51 Completed build in 10m 29s on Thu, 16 Jan, 08:51 AM Test Summary: 70090 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40006

  35. Daniel Siepmann uploaded patch set 11 01/16/20, 10:22

  36. Daniel Siepmann commented on patch set 11 01/16/20, 10:27

    Don't know what happened, but for some reason I've pushed an update. No idea where it came from.
  37. TYPO3com voted on patch set 11 V -1 01/16/20, 11:08 Completed build in 24m 52s on Thu, 16 Jan, 11:08 AM Test Summary: 70398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40018

  38. TYPO3com voted on patch set 11 V +1 01/16/20, 12:21 Completed build in 13m 30s on Thu, 16 Jan, 12:21 PM Test Summary: 70403 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40032

  39. Benni Mack commented on patch set 11 01/18/20, 15:44

    FlexFormProcessor.php:80

    when using the $flexformData variable here, it is impossible to access the actual $processedData of this DataProcessor then, correct?
  40. Benni Mack commented on patch set 11 01/18/20, 15:46

    Feature-89509-DataProcessorToResolveFlexFormData.rst:22

    "Alternative"? Alternative to what? I guess you mean "pi_flexform", which is the default case for tt_content. Let's either require this value so it has to be set at all times, or document that if nothing given that it falls back to `pi_flexform`.
  41. Anja Leichsenring commented on patch set 11 02/13/20, 11:16

    *ping* Feature Freeze drows near :)
  42. Benni Mack commented on patch set 11 CR -1 05/06/20, 08:02

    see my comments, still apply
  43. Benni Mack commented on patch set 11 06/03/20, 10:27

    ping, would still love to have an answer on my question...
  44. Jo Hasenau commented on patch set 12 08/07/20, 14:54

    Published edit on patch set 11.
  45. TYPO3com voted on patch set 12 V -1 08/07/20, 14:54 Completed build in 23s on Fri, 7 Aug, 02:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4481

  46. Jo Hasenau commented on patch set 12 08/07/20, 14:56

    > Patch Set 11: > > (1 comment)
  47. Jo Hasenau commented on patch set 12 08/07/20, 14:57

    > Patch Set 11: > > (1 comment) Yes - since this processor is about processing of flexform data only, the subprocessors will be applied only to the processed flexform data too.
  48. Jo Hasenau rebased onto patch set 13 08/07/20, 15:17

  49. TYPO3com voted on patch set 13 V -1 08/07/20, 15:18 Completed build in 26s on Fri, 7 Aug, 03:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4483

  50. Oliver Klee wrote 08/07/20, 15:27

    Removed reviewer Oliver Klee.
  51. Jörg Bösche uploaded patch set 14 08/25/20, 06:43

  52. TYPO3com voted on patch set 14 V -1 08/25/20, 06:44 Completed build in 50s on Tue, 25 Aug, 06:44 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4930

  53. Jörg Bösche uploaded patch set 15 08/25/20, 06:47

  1. TYPO3com voted on patch set 15 V -1 08/25/20, 07:00 Completed build in 12m 52s on Tue, 25 Aug, 07:00 AM Test Summary: 6 of 73595 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4931

  2. Jörg Bösche uploaded patch set 16 08/25/20, 07:12

  3. TYPO3com voted on patch set 16 V +1 08/25/20, 07:24 Completed build in 12m 08s on Tue, 25 Aug, 07:24 AM Test Summary: 73110 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4934

  4. Jonas Eberle voted on patch set 16 V +1 CR +1 11/22/20, 11:30

  5. Jonas Eberle commented on patch set 16 11/25/20, 12:24

    Feature-89509-DataProcessorToResolveFlexFormData.rst:22 Reply

    Done

    FlexFormProcessor.php:80 Reply Unresolved

    Yes. But I would say it is by design that subprocessors are overlaying the data of their parent processor. Relaying Jo's answer: Yes - since this processor is about processing of flexform data only, the subprocessors will be applied only to the processed flexform data too.
  6. Sybille Peters voted on patch set 16 CR +1 12/04/20, 18:17

  7. Jo Hasenau voted on patch set 16 V +1 CR +1 12/15/20, 09:33

  8. Oli Bartsch commented on patch set 16 12/15/20, 11:22

    FlexFormProcessor.php:90 Unresolved

    Don't know if the raw data should really be overwritten. Can not find such functionality in any other processor. I would suggest to add a default value in L:74 (to unify with other processors). If "as" is not defined, the user then still has both versions, raw and resolved.
  9. Oli Bartsch uploaded patch set 17 01/05/21, 16:10

  10. TYPO3com voted on patch set 17 V +1 01/05/21, 16:22 Completed build in 11m 49s on Tue, 5 Jan, 04:22 PM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8630

  11. Oli Bartsch uploaded patch set 18 01/05/21, 16:23

  12. Oli Bartsch voted on patch set 18 V +1 CR +1 01/05/21, 16:23

  13. TYPO3com voted on patch set 18 V +1 01/05/21, 16:35 Completed build in 11m 42s on Tue, 5 Jan, 04:35 PM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8631

  14. Jo Hasenau commented on patch set 18 V -1 CR -1 01/05/21, 16:45

    Is there a reason why the subprocessor has been removed now? The goal of the whole refactoring and adding of new processors still is to provide a unified way of dealing with data processors. So each of them (instead of just a few) must have a subprocessor to be able to i.e. add references or other things based on information which has been processed already.
  15. Jo Hasenau commented on patch set 18 01/05/21, 16:52

    Reply

    Just to clarify this a bit: If the subprocessor is defined and executed within the process-method, we can not make sure it will be available by using interfaces and/or abstract classes later on. So the separate method was there for a reason ;-)
  16. Oli Bartsch commented on patch set 18 01/05/21, 16:59

    Reply

    What makes you think that the subprocessor has been removed? It's still there. This is also verified by the unit tests. See: FlexFormProcessorTest::subDataProcessorIsResolved().
  17. Oli Bartsch uploaded patch set 19 01/05/21, 17:29

  18. Jo Hasenau voted on patch set 19 V +1 CR +1 01/05/21, 17:35

  19. Oli Bartsch voted on patch set 19 V +1 CR +1 01/05/21, 17:37

  20. TYPO3com voted on patch set 19 V -1 01/05/21, 17:46 Completed build in 16m 04s on Tue, 5 Jan, 05:46 PM Test Summary: 32556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8638

  21. TYPO3com voted on patch set 19 V +1 01/05/21, 18:00 Completed build in 10m 03s on Tue, 5 Jan, 06:00 PM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8640

  22. Benni Mack commented on patch set 19 01/05/21, 18:32

    Reply Unresolved

    @Jo: Is your issue resolved?
  23. Benni Mack voted on patch set 19 V +2 CR +2 01/05/21, 19:54

  24. Benni Mack merged patch set 20 01/05/21, 19:54

  25. Jonas Eberle commented on patch set 20 01/13/21, 08:09