Review main Merged

62110[BUGFIX] Fix missed assert* call in test file

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 10/25/19, 12:47

Commit message

The newly introduced php-cs-fixer rule was not applied to this
test file, so it breaks the nightly cgl integration job.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 46

  1. Anja Leichsenring uploaded patch set 1 10/25/19, 12:32

  2. Andreas Kienast voted on patch set 1 V +2 CR +2 10/25/19, 12:33

  3. Oliver Klee voted on patch set 1 CR +1 10/25/19, 12:42

  4. TYPO3com voted on patch set 1 V -1 10/25/19, 12:45 Completed build in 12m 31s on Fri, 25 Oct, 12:45 PM Test Summary: 2 of 48378 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37669

  5. TYPO3com voted on patch set 1 V +1 10/25/19, 12:46 Completed build in 25m 57s on Fri, 25 Oct, 12:46 PM Test Summary: 48019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37669

  6. Andreas Kienast merged patch set 2 10/25/19, 12:47