Review main Merged

62111[BUGFIX] Use strict type checking for in_array() calls in JsonView

Markus Klein CR +2 V +2 Easy +31 −4 updated 10/28/19, 19:14

Commit message

If the JsonView traverses array with numeric indexes and an exclude
configuration is set, the first array element is now handled correctly.

The comparison of array index 0 with a string within in_array() yields
TRUE, hence the first element was skipped.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Florian Weiss +1
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Susi Moog +2
    • Florian Weiss +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Markus Klein uploaded patch set 1 10/25/19, 12:36

  2. Oliver Klee voted on patch set 1 CR +1 10/25/19, 12:41

  3. TYPO3com voted on patch set 1 V -1 10/25/19, 12:48 Completed build in 11m 06s on Fri, 25 Oct, 12:48 PM Test Summary: 1 of 48382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37670

  4. TYPO3com voted on patch set 1 V +1 10/25/19, 12:50 Completed build in 24m 17s on Fri, 25 Oct, 12:50 PM Test Summary: 48023 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37670

  5. Florian Weiss voted on patch set 1 CR +1 10/25/19, 13:31

  6. Florian Weiss voted on patch set 1 V +1 10/25/19, 13:31

  7. Oli Bartsch voted on patch set 1 CR +1 10/27/19, 22:50

  8. Susi Moog voted on patch set 1 V +2 CR +2 10/28/19, 19:14

  9. Susi Moog merged patch set 2 10/28/19, 19:14