Review main Abandoned

62113[FEATURE] Introduce new system_log table

Alexander Schnitzler CR 0 V 0 Normal +176 −2 updated 08/08/22, 14:53

Commit message

When the logging framework has been introduced in TYPO3
6.0 a DatabaseWriter class has been implemented to write
log messages to the database. To achieve this properly the
sys_log table had been enhanced with a couple of new fields.

That led to the issue that the logging framework uses one
half of the sys_log fields while the DataHandler (mostly)
and other classes write log messages to the other half of
sys_log fields, which is chaotic.

To prepare the implementation of monolog into the core,
there is a feature switch now that enables the DatabaseWriter
of the logging framework to log into a new, dedicated database
table called system_log. Additionally, there is a new table
called system_log_exception that stores information about
exceptions that are part of the log context data.

See https://www.php-fig.org/psr/psr-3/#13-context for more
information about exception logging.

Exceptions are stored deduplicated which results in a n:1
relation between system_log and system_log_exception.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 1829

Show 24 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 10/25/19, 13:04

  2. TYPO3com voted on patch set 1 V -1 10/25/19, 13:11 Completed build in 06m 30s on Fri, 25 Oct, 01:11 PM Test Summary: 7536 of 47975 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37676

  3. Alexander Schnitzler uploaded patch set 2 10/25/19, 14:43

  4. TYPO3com voted on patch set 2 V -1 10/25/19, 15:27 Completed build in 15m 54s on Fri, 25 Oct, 03:27 PM Test Summary: 7780 of 48219 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37695

  1. Alexander Schnitzler uploaded patch set 3 10/25/19, 15:42

  2. Alexander Schnitzler uploaded patch set 4 10/25/19, 15:58

  3. TYPO3com voted on patch set 4 V -1 10/25/19, 16:02 Completed build in 04m 25s on Fri, 25 Oct, 04:02 PM Test Summary: 7780 of 48259 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37708

  4. Alexander Schnitzler uploaded patch set 5 10/25/19, 16:07

  5. TYPO3com voted on patch set 5 V -1 10/25/19, 16:22 Completed build in 14m 53s on Fri, 25 Oct, 04:22 PM Test Summary: 3 of 48418 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37712

  6. Alexander Schnitzler uploaded patch set 6 10/25/19, 17:35

  7. TYPO3com voted on patch set 6 V -1 10/25/19, 17:35 Completed build in 07s on Fri, 25 Oct, 05:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37723

  8. TYPO3com commented on patch set 6 10/25/19, 17:48 Completed build in 13m 42s on Fri, 25 Oct, 05:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37723

  9. Alexander Schnitzler uploaded patch set 7 10/25/19, 18:00

  10. TYPO3com voted on patch set 7 V -1 10/25/19, 18:11 Completed build in 11m 05s on Fri, 25 Oct, 06:11 PM Test Summary: 47814 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37726

  11. TYPO3com voted on patch set 3 V -1 10/25/19, 18:42 Completed build in 2h 54m 35s on Fri, 25 Oct, 06:42 PM Test Summary: 5268 of 45747 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37706

  12. TYPO3com voted on patch set 7 V +1 10/25/19, 18:54 Completed build in 1h 04m 51s on Fri, 25 Oct, 06:54 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37726

  13. Alexander Schnitzler commented on patch set 7 10/29/19, 11:00

    This change is ready for review.
  14. Alexander Schnitzler wrote 11/04/19, 15:03

    Topic set to logging
  15. Alexander Schnitzler uploaded patch set 8 11/04/19, 15:04

  16. TYPO3com voted on patch set 8 V -1 11/04/19, 15:16 Completed build in 11m 19s on Mon, 4 Nov, 03:16 PM Test Summary: 8 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37978

  17. Alexander Schnitzler uploaded patch set 9 11/04/19, 16:30

  18. TYPO3com voted on patch set 9 V +1 11/04/19, 16:45 Completed build in 11m 30s on Mon, 4 Nov, 04:45 PM Test Summary: 48123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37988

  19. Markus Klein commented on patch set 9 CR -1 11/05/19, 08:15

    DatabaseWriter.php:93 Unresolved

    such docblocks are useless. lets remove them

    DatabaseWriter.php:112 Unresolved

    I think this is insufficient. The trace to the same exception might not be the same for every logged entry. So IMO we need to log every exception. (run a hash function over it and compare that hash)
  20. Markus Klein commented on patch set 9 11/05/19, 08:17

    ext_tables.sql:434 Unresolved

    add a key for the excpetion too please
  21. Alexander Schnitzler commented on patch set 9 CR -2 11/12/19, 16:43

    Talked to Benni and he would like to solve this later and differently. On hold for now.
  22. Alexander Schnitzler marked it work in progress 02/28/20, 15:59

  23. Benni Mack wrote 11/29/21, 10:01

    Change destination moved from master to main
  24. Benni Mack updated the commit message in patch set 10 11/29/21, 13:16

  25. Alexander Schnitzler abandoned the change 08/08/22, 14:53