Review main Merged

62115[TASK] Update eslint packages

Andreas Kienast CR +2 V +2 Normal +69 −25 updated 10/25/19, 17:13

Commit message

This patch updates all related eslint packages to their latest versions.

Executed commands:

  yarn add --dev eslint@^6.5.1
  yarn add --dev @typescript-eslint/eslint-plugin@^2.5.0
  yarn add --dev @typescript-eslint/parser@^2.5.0
  yarn add --dev @typescript-eslint/typescript-estree@^2.5.0

The `eslint` also fixes a security vulnerability, which is "very
unlikely to be exploited" and may hit in core development context only.

See
- https://github.com/eslint/eslint/issues/10002
- https://github.com/eslint/eslint/commit/f6901d0b

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Andreas Kienast uploaded patch set 1 10/25/19, 14:11

  2. TYPO3com voted on patch set 1 V -1 10/25/19, 14:30 Completed build in 15m 48s on Fri, 25 Oct, 02:30 PM Test Summary: 1 of 48378 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37685

  3. TYPO3com voted on patch set 1 V +1 10/25/19, 14:40 Completed build in 41m 54s on Fri, 25 Oct, 02:40 PM Test Summary: 48019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37685

  4. Frank Nägler voted on patch set 1 V +1 CR +1 10/25/19, 14:45

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 10/25/19, 15:45

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 10/25/19, 17:13

  7. Andreas Kienast merged patch set 2 10/25/19, 17:13