Review main Merged

62121[FEATURE] Add possibility to configure the path to sitemap xslFile

Kevin Appelt CR +2 V +2 Normal +210 −7 updated 01/15/20, 21:25

Commit message

The xsl file to create a layout for a XML sitemap can now be configured
on three levels:

1. for all sitemaps
2. for all sitemaps of a certain sitemapType
3. for a specific sitemap

The value is inherited until it is overwritten.
If no value is specified at all, EXT:seo/Resources/Public/CSS/Sitemap.xsl
is used as default like before.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1522

  1. Kevin Appelt uploaded patch set 1 10/25/19, 21:35

  2. TYPO3com voted on patch set 1 V -1 10/25/19, 21:35 Completed build in 12s on Fri, 25 Oct, 09:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37750

  3. Kevin Appelt uploaded patch set 2 10/25/19, 21:40

  4. TYPO3com voted on patch set 2 V -1 10/25/19, 21:51 Completed build in 11m 03s on Fri, 25 Oct, 09:51 PM Test Summary: 37496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37751

  5. TYPO3com voted on patch set 2 V +1 10/25/19, 22:07 Completed build in 09m 28s on Fri, 25 Oct, 10:07 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37754

  6. Simon Gilli commented on patch set 2 10/26/19, 02:28

    Feature-88147-AddPossibilityToConfigureThePathToSitemapXslFile.rst:1

  7. Kevin Appelt uploaded patch set 3 10/26/19, 07:10

  8. Kevin Appelt commented on patch set 3 10/26/19, 07:11

    Feature-88147-AddPossibilityToConfigureThePathToSitemapXslFile.rst:1 Reply

    Done
  9. TYPO3com voted on patch set 3 V +1 10/26/19, 07:21 Completed build in 10m 59s on Sat, 26 Oct, 07:21 AM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37757

  10. Guido Schmechel commented on patch set 3 10/26/19, 16:40

    XmlSitemapRenderer.php:167 Unresolved

    Can we cover this with an unit test?
  11. Georg Ringer commented on patch set 3 CR -1 11/01/19, 19:14

    also please add a unit test for the new method

    setup.typoscript:38 Unresolved

    change the wording to something like "Example to override the xsl file for all sitemaps, also below
  12. Daniel Siepmann uploaded patch set 4 11/07/19, 07:29

  13. TYPO3com voted on patch set 4 V +1 11/07/19, 07:42 Completed build in 12m 57s on Thu, 7 Nov, 07:42 AM Test Summary: 48147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38058

  14. Richard Haeser commented on patch set 4 CR -1 11/13/19, 20:34

    Kevin, can you add tests for this please?
  15. Jörg Bösche commented on patch set 4 01/15/20, 07:46

    ping. Are there any updates to this topic?
  16. Richard Haeser commented on patch set 4 01/15/20, 08:20

    Will check tonight
  17. Richard Haeser uploaded patch set 5 01/15/20, 20:56

  18. TYPO3com voted on patch set 5 V -1 01/15/20, 21:07 Completed build in 10m 55s on Wed, 15 Jan, 09:07 PM Test Summary: 70346 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39999

  19. Richard Haeser voted on patch set 5 V +1 CR +1 01/15/20, 21:09

  20. TYPO3com voted on patch set 5 V +1 01/15/20, 21:10 Completed build in 25m 21s on Wed, 15 Jan, 09:10 PM Test Summary: 70355 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39999

  21. Georg Ringer voted on patch set 5 V +2 CR +2 01/15/20, 21:25

  22. Georg Ringer merged patch set 6 01/15/20, 21:25