62121[FEATURE] Add possibility to configure the path to sitemap xslFile
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Richard Haeser +1
-
Verified V +2 Done
- Georg Ringer +2
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Feature-88147-AddPossibilityToConfigureThePathToSitemapXslFile.rst2new+35 −0
- typo3/sysext/seo/Classes/XmlSitemap/XmlSitemapRenderer.php1+15 −7
- typo3/sysext/seo/Configuration/TypoScript/XmlSitemap/setup.typoscript1+6 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl1.typoscriptnew+5 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl2.typoscriptnew+6 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl3.typoscriptnew+13 −0
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapXslTest.phpnew+130 −0
Review log 1522
-
Kevin Appelt uploaded patch set 1 10/25/19, 21:35
-
TYPO3com voted on patch set 1 V -1 10/25/19, 21:35 Completed build in 12s on Fri, 25 Oct, 09:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37750
-
Kevin Appelt uploaded patch set 2 10/25/19, 21:40
-
TYPO3com voted on patch set 2 V -1 10/25/19, 21:51 Completed build in 11m 03s on Fri, 25 Oct, 09:51 PM Test Summary: 37496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37751
-
TYPO3com voted on patch set 2 V +1 10/25/19, 22:07 Completed build in 09m 28s on Fri, 25 Oct, 10:07 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37754
-
Simon Gilli commented on patch set 2 10/26/19, 02:28
-
Kevin Appelt uploaded patch set 3 10/26/19, 07:10
-
Kevin Appelt commented on patch set 3 10/26/19, 07:11
Feature-88147-AddPossibilityToConfigureThePathToSitemapXslFile.rst:1ReplyDone -
TYPO3com voted on patch set 3 V +1 10/26/19, 07:21 Completed build in 10m 59s on Sat, 26 Oct, 07:21 AM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37757
-
Guido Schmechel commented on patch set 3 10/26/19, 16:40
XmlSitemapRenderer.php:167UnresolvedCan we cover this with an unit test? -
Georg Ringer commented on patch set 3 CR -1 11/01/19, 19:14
also please add a unit test for the new methodsetup.typoscript:38Unresolvedchange the wording to something like "Example to override the xsl file for all sitemaps, also below -
Daniel Siepmann uploaded patch set 4 11/07/19, 07:29
-
TYPO3com voted on patch set 4 V +1 11/07/19, 07:42 Completed build in 12m 57s on Thu, 7 Nov, 07:42 AM Test Summary: 48147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38058
-
Richard Haeser commented on patch set 4 CR -1 11/13/19, 20:34
Kevin, can you add tests for this please? -
Jörg Bösche commented on patch set 4 01/15/20, 07:46
ping. Are there any updates to this topic? -
Richard Haeser commented on patch set 4 01/15/20, 08:20
Will check tonight -
Richard Haeser uploaded patch set 5 01/15/20, 20:56
-
TYPO3com voted on patch set 5 V -1 01/15/20, 21:07 Completed build in 10m 55s on Wed, 15 Jan, 09:07 PM Test Summary: 70346 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39999
-
Richard Haeser voted on patch set 5 V +1 CR +1 01/15/20, 21:09
-
TYPO3com voted on patch set 5 V +1 01/15/20, 21:10 Completed build in 25m 21s on Wed, 15 Jan, 09:10 PM Test Summary: 70355 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39999
-
Georg Ringer voted on patch set 5 V +2 CR +2 01/15/20, 21:25
-
Georg Ringer merged patch set 6 01/15/20, 21:25
Feature-88147-AddPossibilityToConfigureThePathToSitemapXslFile.rst:1