Review main Abandoned

62125[FEATURE] Refactor HrefLangGenerator

Kevin Appelt CR 0 V 0 Normal +74 −10 updated 01/25/20, 10:24

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 45

  1. Kevin Appelt uploaded patch set 1 10/26/19, 11:48

  2. Kevin Appelt marked it work in progress 10/26/19, 11:48

  3. TYPO3com voted on patch set 1 V -1 10/26/19, 11:48 Completed build in 24s on Sat, 26 Oct, 11:48 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37783

  4. Daniel Goerz commented on patch set 1 01/22/20, 11:53

    Hi Kevin, with https://review.typo3.org/c/Packages/TYPO3.CMS/+/59059 the HrefLangGenerator was refactored to be an event listener. Do you plan on updating your patch or can we abandon it?
  5. Susi Moog abandoned the change 01/25/20, 10:24

    As there is no linked issue and further description, a refactoring took place already and there has been no activity here for 3 months, I'm abandoning the patch now. Please restore the change if you plan on continuing your work.