Review main Merged

62126[BUGFIX] Backup last typolink URL before processing ATagParams

Alexander Stehlik CR +2 V +2 Easy +3 −1 updated 10/28/19, 19:25

Commit message

This prevents typolinks called in the stdWrap of ATagParams
from modifying the original link URL.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1217

  1. Alexander Stehlik uploaded patch set 1 10/27/19, 10:37

  2. Alexander Stehlik rebased onto patch set 2 10/27/19, 10:38

  3. TYPO3com voted on patch set 1 V +1 10/27/19, 10:49 Completed build in 11m 44s on Sun, 27 Oct, 10:49 AM Test Summary: 48067 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37800

  4. TYPO3com voted on patch set 2 V -1 10/27/19, 10:58 Completed build in 16m 28s on Sun, 27 Oct, 10:58 AM Test Summary: 1 of 48426 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37801

  5. Alexander Stehlik uploaded patch set 3 10/27/19, 21:39

  6. TYPO3com commented on patch set 3 10/27/19, 21:50 Completed build in 10m 30s on Sun, 27 Oct, 09:50 PM Test Summary: 47815 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37811

  7. Alexander Stehlik uploaded patch set 4 10/27/19, 21:51

  8. TYPO3com commented on patch set 4 10/27/19, 22:01 Completed build in 10m 00s on Sun, 27 Oct, 10:01 PM Test Summary: 47823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37812

  9. Alexander Stehlik uploaded patch set 5 10/28/19, 08:34

  10. Alexander Stehlik commented on patch set 5 10/28/19, 08:41

    I'll keep pushing and hoping that on some point I do not get a random build error :|
  11. TYPO3com voted on patch set 5 V +1 10/28/19, 08:43 Completed build in 08m 45s on Mon, 28 Oct, 08:43 AM Test Summary: 48067 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37819

  12. Alexander Stehlik commented on patch set 5 10/28/19, 08:43

    Yay \o/ :D
  13. Oli Bartsch voted on patch set 5 V +1 CR +1 10/28/19, 12:25

  14. Tymoteusz Motylewski commented on patch set 5 CR +1 10/28/19, 14:52

    @Alexander would you be able to also add an unit test for this case? I'm sure this will help to shorten the time this patch spends in the review queue. Thanks.
  15. Susi Moog commented on patch set 5 V +2 CR +2 10/28/19, 19:04

    Unit tests in that context are problematic and require an undue amount of setup due to the nested calls to stdWrap / ATagParams, so I'm going to go ahead and merge it without them (as long as typolink is not more isolated).
  16. Susi Moog merged patch set 6 10/28/19, 19:04

  17. Alexander Stehlik commented on patch set 6 10/28/19, 19:25

    Thank you ❤️