Review main Merged

62127[FEATURE] Provide feature flag for new translation server's export

Georg Ringer CR +2 V +2 Easy +44 −1 updated 10/30/19, 12:58

Commit message

The feature switch `betaTranslationServer` makes it possible for users
to test and use the new translation server.

The integration is currently work in progress but will be finished before
the LTS release of version 10.
Once the work has been stabilized and tested well,
the feature flag will be removed for 10 and backported for 9.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Joerg Kummer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1015

  1. Georg Ringer uploaded patch set 1 10/28/19, 12:51

  2. TYPO3com voted on patch set 1 V -1 10/28/19, 13:01 Completed build in 10m 13s on Mon, 28 Oct, 01:01 PM Test Summary: 47815 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37821

  3. TYPO3com voted on patch set 1 V +1 10/28/19, 13:16 Completed build in 35m 31s on Mon, 28 Oct, 01:16 PM Test Summary: 48065 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37821

  4. Georg Ringer uploaded patch set 2 10/29/19, 04:18

  5. Georg Ringer commented on patch set 2 10/29/19, 04:18

    This change is ready for review.
  6. TYPO3com voted on patch set 2 V -1 10/29/19, 04:34 Completed build in 14m 36s on Tue, 29 Oct, 04:34 AM Test Summary: 47819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37835

  7. TYPO3com voted on patch set 2 V +1 10/29/19, 05:15 Completed build in 1h 10m 39s on Tue, 29 Oct, 05:15 AM Test Summary: 48071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37835

  8. Joerg Kummer voted on patch set 2 V +1 CR +1 10/29/19, 06:09

  9. Markus Klein voted on patch set 2 V +1 CR +1 10/29/19, 07:54

  10. Benni Mack commented on patch set 2 CR -1 10/30/19, 09:55

    Feature-89526-FeatureFlagBetaTranslationServer.rst:16 Unresolved

    I'd recommend to have a few more lines to that: The feature switch `betaTranslationServer` makes it possible for installations to fetch translations from the new translation server (beta status). The new translation server is building labels from Crowdin instead of the current translation server based on Pootle. Integration is currently a work-in-progress....
  11. Georg Ringer uploaded patch set 3 10/30/19, 10:49

  12. Joerg Kummer voted on patch set 3 V +1 CR +1 10/30/19, 10:55

  13. TYPO3com voted on patch set 3 V +1 10/30/19, 10:59 Completed build in 09m 44s on Wed, 30 Oct, 10:59 AM Test Summary: 48070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37859

  14. Benni Mack voted on patch set 3 V +2 CR +2 10/30/19, 12:58

  15. Benni Mack merged patch set 4 10/30/19, 12:58