Review main Merged

62131[BUGFIX] Remove more options from LinkBrowser in redirects

Georg Ringer CR +2 V +2 Easy +1 −1 updated 10/30/19, 12:01

Commit message

Hide the following options in the LinkBrowser of a sys_redirect record
because those don't work for redirects and confuse users:

 - mail
 - folder
 - telephone

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Joerg Kummer +1
    • Guido Schmechel +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Joerg Kummer +1
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1418

  1. Georg Ringer uploaded patch set 1 10/28/19, 21:02

  2. Georg Ringer commented on patch set 1 10/28/19, 21:02

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 10/28/19, 21:12 Completed build in 10m 08s on Mon, 28 Oct, 09:12 PM Test Summary: 48071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37832

  4. Guido Schmechel commented on patch set 1 CR -1 10/28/19, 22:22

    My two cents: - v10: "telephone" instead of "tel" - v9: telephone is not available. I dont know if this could be a problem? Maybe we can make this patch a little bit generic and remove the field "title" (blindLinkFields), too?
  5. Joerg Kummer uploaded patch set 2 10/28/19, 22:38

  6. Joerg Kummer commented on patch set 2 10/28/19, 22:42

    Version 9.5 requires a modified backport patch, cause of missing telephone option.
  7. TYPO3com voted on patch set 2 V -1 10/28/19, 22:49 Completed build in 10m 11s on Mon, 28 Oct, 10:49 PM Test Summary: 38003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37834

  8. TYPO3com voted on patch set 2 V +1 10/29/19, 05:09 Completed build in 6h 40m 43s on Tue, 29 Oct, 05:09 AM Test Summary: 48071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37834

  9. Oli Bartsch commented on patch set 2 10/29/19, 06:18

    Unresolved

    As far as I can see the patch adds ‚folder’ an ‚telephone’. ‚mail‘ is already removed.
  10. Markus Klein updated the commit message in patch set 3 10/29/19, 08:03

  11. Markus Klein voted on patch set 3 CR +1 10/29/19, 08:03

  12. Oli Bartsch voted on patch set 3 CR +1 10/29/19, 08:05

  13. TYPO3com voted on patch set 3 V +1 10/29/19, 08:13 Completed build in 09m 59s on Tue, 29 Oct, 08:13 AM Test Summary: 48071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37839

  14. Joerg Kummer voted on patch set 3 V +1 CR +1 10/29/19, 08:16

  15. Guido Schmechel voted on patch set 3 V +1 CR +1 10/29/19, 09:46

  16. Oli Bartsch voted on patch set 3 V +1 10/29/19, 09:52

  17. Benni Mack voted on patch set 3 V +2 CR +2 10/30/19, 12:01

  18. Benni Mack merged patch set 4 10/30/19, 12:01