Review 9.5 Merged

62138[BUGFIX] Correctly check TSFE->rootLine

Benni Mack CR +2 V +2 Easy +1 −1 updated 10/30/19, 12:58

Commit message

The existing check on the data-type of $rootLine has to be adjusted
since the default value is now an array.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 68

  1. Benni Mack commented on patch set 1 10/30/19, 12:06

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
  2. Benni Mack commented on patch set 2 10/30/19, 12:07

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 3 10/30/19, 12:08

    Published edit on patch set 2.
  4. Benni Mack commented on patch set 3 10/30/19, 12:08

    This change is ready for review.
  5. TYPO3com voted on patch set 3 V -1 10/30/19, 12:45 Completed build in 16m 04s on Wed, 30 Oct, 12:45 PM Test Summary: 50774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1402

  6. TYPO3com voted on patch set 3 V +1 10/30/19, 12:57 Completed build in 43m 54s on Wed, 30 Oct, 12:57 PM Test Summary: 50784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1402

  7. Benni Mack voted on patch set 3 V +2 CR +2 10/30/19, 12:58

  8. Benni Mack merged patch set 4 10/30/19, 12:58