Review 9.5 Merged

62139[BUGFIX] Properly trimExplode allowed file extensions in IRRE / FAL

Susi Moog CR +2 V +2 Normal +87 −3 updated 10/30/19, 15:05

Commit message

When a custom FAL / sys_file_reference inline element is registered, and
there are custom allowed file extensions, the property "elementBrowserAllowed"
is not properly run through "GeneralUtility::trimExplode()", however, all other
places do this properly.

The changes moves the trimExplode to the correct place, so uploading
of files directly in FormEngine works properly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 812

  1. Susi Moog commented on patch set 1 10/30/19, 12:58

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php * typo3/sysext/backend/Classes/Form/FieldControl/ElementBrowser.php
  2. TYPO3com voted on patch set 1 V -1 10/30/19, 12:59 Completed build in 32s on Wed, 30 Oct, 12:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1409

  3. Susi Moog uploaded patch set 2 10/30/19, 13:07

  4. Susi Moog commented on patch set 2 10/30/19, 13:08

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V -1 10/30/19, 13:25 Completed build in 16m 19s on Wed, 30 Oct, 01:25 PM Test Summary: 9 of 51261 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1411

  6. Susi Moog uploaded patch set 3 10/30/19, 13:26

  7. TYPO3com voted on patch set 3 V -1 10/30/19, 13:39 Completed build in 12m 43s on Wed, 30 Oct, 01:39 PM Test Summary: 50478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1412

  8. TYPO3com voted on patch set 3 V +1 10/30/19, 13:43 Completed build in 29m 02s on Wed, 30 Oct, 01:43 PM Test Summary: 50792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1412

  9. Georg Ringer voted on patch set 3 V +1 CR +1 10/30/19, 13:49

  10. Daniel Gorges voted on patch set 3 V +1 CR +1 10/30/19, 15:03

  11. Benni Mack voted on patch set 3 V +2 CR +2 10/30/19, 15:05

  12. Benni Mack merged patch set 4 10/30/19, 15:05