Review main Merged

62152[BUGFIX] Support unicode characters for redirects

Guido Schmechel CR +2 V +2 Easy +30 −3 updated 01/14/20, 15:57

Commit message

Add rawurldecode for the given path. Now it is possible
to set unicode characters and umlauts in the source path.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 710

  1. Guido Schmechel uploaded patch set 1 10/28/19, 22:06

  2. TYPO3com voted on patch set 1 V -1 10/28/19, 22:15 Completed build in 09m 20s on Mon, 28 Oct, 10:15 PM Test Summary: 47605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37833

  3. TYPO3com voted on patch set 1 V +1 10/29/19, 05:16 Completed build in 7h 19m 02s on Tue, 29 Oct, 05:15 AM Test Summary: 48087 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37833

  4. Guido Schmechel commented on patch set 1 10/29/19, 09:11

    RedirectServiceTest.php:90 Unresolved

    Update phpDoc and default value
  5. Guido Schmechel uploaded patch set 2 10/31/19, 06:03

  6. TYPO3com voted on patch set 2 V +1 10/31/19, 06:17 Completed build in 13m 56s on Thu, 31 Oct, 06:17 AM Test Summary: 48095 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37879

  7. Benni Mack voted on patch set 2 V +1 CR +1 12/27/19, 21:09

  8. Jörg Bösche commented on patch set 2 V +1 CR +1 01/13/20, 13:39

    verified on v10.3.0-dev.
  9. Daniel Goerz voted on patch set 2 V +2 CR +2 01/14/20, 15:56

  10. Daniel Goerz merged patch set 3 01/14/20, 15:57