Review main Merged

62155[BUGFIX] Properly trimExplode allowed file extensions in IRRE / FAL

Benni Mack CR +2 V +2 Normal +86 −3 updated 11/07/19, 21:52

Commit message

When a custom FAL / sys_file_reference inline element is registered, and
there are custom allowed file extensions, the property "elementBrowserAllowed"
is not properly run through "GeneralUtility::trimExplode()", however, all other
places do this properly.

The changes moves the trimExplode to the correct place, so uploading
of files directly in FormEngine works properly.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Gorges +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Gorges +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1519

  1. Benni Mack uploaded patch set 1 10/30/19, 10:21

  2. Daniel Goerz voted on patch set 1 CR +1 10/30/19, 10:24

  3. Daniel Gorges voted on patch set 1 V +1 CR +1 10/30/19, 10:27

  4. Georg Ringer commented on patch set 1 10/30/19, 10:38

    ElementBrowser.php:74

    shouldn't be there 3rd param set to true?
  5. Benni Mack commented on patch set 1 10/30/19, 10:39

    ElementBrowser.php:74 Reply Unresolved

    yes!
  6. Benni Mack commented on patch set 2 10/30/19, 10:40

    Published edit on patch set 1.
  7. Daniel Goerz voted on patch set 2 CR +1 10/30/19, 11:42

  8. TYPO3com voted on patch set 2 V -1 10/30/19, 11:52 Completed build in 09m 21s on Wed, 30 Oct, 11:52 AM Test Summary: 47818 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37861

  9. TYPO3com voted on patch set 2 V +1 10/30/19, 11:57 Completed build in 23m 42s on Wed, 30 Oct, 11:57 AM Test Summary: 48071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37861

  10. Susi Moog voted on patch set 2 CR +1 10/30/19, 12:07

  11. Daniel Gorges voted on patch set 2 V +1 CR +1 10/30/19, 12:21

  12. Susi Moog uploaded patch set 3 10/30/19, 12:21

  13. Susi Moog voted on patch set 3 V +1 CR +1 10/30/19, 12:23

  14. TYPO3com voted on patch set 3 V -1 10/30/19, 12:34 Completed build in 12m 56s on Wed, 30 Oct, 12:34 PM Test Summary: 38009 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37864

  15. TYPO3com voted on patch set 3 V +1 10/30/19, 12:56 Completed build in 47m 03s on Wed, 30 Oct, 12:55 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37864

  16. Daniel Gorges voted on patch set 3 V +1 CR +1 10/30/19, 12:57

  17. Susi Moog voted on patch set 3 V +2 CR +2 10/30/19, 12:58

  18. Susi Moog merged patch set 4 10/30/19, 12:58

  19. Oliver Hader voted on patch set 4 V +1 CR +1 11/07/19, 21:52