Review main Merged

62156[TASK] Update Fluid Standalone to 2.6.6

Benni Mack CR +2 V +2 Easy +15 −17 updated 10/30/19, 15:49

Commit message

A new fluid standalone version 2.6.6 reverted the changes
that had regressions in v2.6.5 and v2.6.4.

Composer command: composer req typo3fluid/fluid:^2.6.6

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 815

  1. Benni Mack uploaded patch set 1 10/30/19, 11:57

  2. TYPO3com voted on patch set 1 V -1 10/30/19, 12:42 Completed build in 14m 24s on Wed, 30 Oct, 12:42 PM Test Summary: 1 of 48142 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37865

  3. TYPO3com commented on patch set 1 10/30/19, 13:00 Completed build in 46m 27s on Wed, 30 Oct, 01:00 PM Test Summary: 1 of 48430 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37865

  4. TYPO3com commented on patch set 1 10/30/19, 13:13 Completed build in 1h 32m 05s on Wed, 30 Oct, 01:13 PM Test Summary: 48071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37865

  5. Benni Mack uploaded patch set 2 10/30/19, 13:21

  6. TYPO3com voted on patch set 2 V -1 10/30/19, 13:33 Completed build in 11m 27s on Wed, 30 Oct, 01:33 PM Test Summary: 48012 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37867

  7. TYPO3com voted on patch set 2 V +1 10/30/19, 13:33 Completed build in 23m 33s on Wed, 30 Oct, 01:33 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37867

  8. Oliver Klee commented on patch set 2 10/30/19, 13:48

    composer.json:97

    If version ^2.6.6 is required (see above), there is no way 2.6.4 or 2.6.5 can be installed. So this "conflicts" line can be removed. Ditto for the other parallel occurrences.
  9. Benni Mack uploaded patch set 3 10/30/19, 15:09

  10. Benni Mack commented on patch set 3 10/30/19, 15:24

    composer.json:97 Reply

    yup. took care of that for master! 9.5 and 8.7 need this!
  11. TYPO3com voted on patch set 3 V -1 10/30/19, 15:25 Completed build in 15m 20s on Wed, 30 Oct, 03:25 PM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37869

  12. TYPO3com voted on patch set 3 V +1 10/30/19, 15:30 Completed build in 36m 19s on Wed, 30 Oct, 03:30 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37869

  13. Oliver Hader voted on patch set 3 V +1 CR +1 10/30/19, 15:48

  14. Benni Mack voted on patch set 3 V +2 CR +2 10/30/19, 15:49

  15. Benni Mack merged patch set 4 10/30/19, 15:49